![[BACK]](/icons/back.gif){kind=icon}
Up to [freebsd] / src / sys / ufs / ffs
Up to [freebsd] / src / sys / ufs / ffs
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.153 / (download) - annotate - [select for diffs], Sun May 17 20:26:00 2009 UTC (6 weeks, 5 days ago) by alc
Branch: MAIN
CVS Tags: HEAD
Changes since 1.152: +6 -8
lines
Diff to previous 1.152 (colored)
SVN rev 192260 on 2009-05-17 20:26:00Z by alc Introduce vfs_bio_set_valid() and use it from ffs_realloccg(). This eliminates the misuse of vfs_bio_clrbuf() by ffs_realloccg(). In collaboration with: tegge
Revision 1.147.2.5.2.1 / (download) - annotate - [select for diffs], Wed Apr 15 03:14:26 2009 UTC (2 months, 2 weeks ago) by kensmith
Branch: RELENG_7_2
CVS Tags: RELENG_7_2_0_RELEASE
Changes since 1.147.2.5: +0 -0
lines
Diff to previous 1.147.2.5 (colored) next main 1.148 (colored)
SVN rev 191087 on 2009-04-15 03:14:26Z by kensmith Create releng/7.2 from stable/7 in preparation for 7.2-RELEASE. Approved by: re (implicit)
Revision 1.147.2.5 / (download) - annotate - [select for diffs], Sun Mar 1 11:20:35 2009 UTC (4 months ago) by trasz
Branch: RELENG_7
CVS Tags: RELENG_7_2_BP
Branch point for: RELENG_7_2
Changes since 1.147.2.4: +4 -4
lines
Diff to previous 1.147.2.4 (colored) to branchpoint 1.147 (colored) next main 1.148 (colored)
SVN rev 189229 on 2009-03-01 11:20:35Z by trasz MFC r188240: When a device containing mounted UFS filesystem disappears, the type of devvp becomes VBAD, which UFS incorrectly interprets as snapshot vnode, which in turns causes panic. Fix it by replacing '!= VCHR' with '== VREG'. With this fix in place, you should no longer be able to panic the system by removing a device with an UFS filesystem mounted from it - assuming you don't use softupdates. Reviewed by: kib Tested by: pho Approved by: rwatson (mentor) Sponsored by: FreeBSD Foundation
Revision 1.147.2.4 / (download) - annotate - [select for diffs], Sat Feb 14 21:08:40 2009 UTC (4 months, 2 weeks ago) by kib
Branch: RELENG_7
Changes since 1.147.2.3: +11 -1
lines
Diff to previous 1.147.2.3 (colored) to branchpoint 1.147 (colored)
SVN rev 188612 on 2009-02-14 21:08:40Z by kib MFC r182366: In ffs_valloc(), ffs_vget() may fail because insmntque() refused to insert new vnode into the mount vnode list. Then, for the SU-enabled mount, ffs_vfree could create freefile dependency. This dependency can hang around forever since inode is not marked as IN_MODIFIED and correspondingly inodeblock may be not marked as dirty. After ffs_vget() fails, retry with FFSV_FORCEINSMQ, mark the inode as modified, and vput() it immediately. Take care of the dup alloc.
Revision 1.152 / (download) - annotate - [select for diffs], Fri Feb 6 17:14:07 2009 UTC (4 months, 3 weeks ago) by trasz
Branch: MAIN
Changes since 1.151: +4 -4
lines
Diff to previous 1.151 (colored)
SVN rev 188240 on 2009-02-06 17:14:07Z by trasz When a device containing mounted UFS filesystem disappears, the type of devvp becomes VBAD, which UFS incorrectly interprets as snapshot vnode, which in turns causes panic. Fix it by replacing '!= VCHR' with '== VREG'. With this fix in place, you should no longer be able to panic the system by removing a device with an UFS filesystem mounted from it - assuming you don't use softupdates. Reviewed by: kib Tested by: pho Approved by: rwatson (mentor) Sponsored by: FreeBSD Foundation
Revision 1.147.2.3 / (download) - annotate - [select for diffs], Fri Feb 6 12:39:42 2009 UTC (4 months, 3 weeks ago) by rwatson
Branch: RELENG_7
Changes since 1.147.2.2: +16 -7
lines
Diff to previous 1.147.2.2 (colored) to branchpoint 1.147 (colored)
SVN rev 188231 on 2009-02-06 12:39:42Z by rwatson
Merge r187790 from head to stable/7:
Following a fair amount of real world experience with ACLs and
extended attributes since FreeBSD 5, make the following semantic
changes:
- Don't update the inode modification time (mtime) when extended
attributes (and hence also ACLs) are added, modified, or removed.
- Don't update the inode access tie (atime) when extended attributes
(and hence also ACLs) are queried.
This means that rsync (and related tools) won't improperly think
that the data in the file has changed when only the ACL has changed.
Note that ffs_reallocblks() has not been changed to not update on an
IO_EXT transaction, but currently EAs don't use the cluster write
routines so this shouldn't be a problem. If EAs grow support for
clustering, then VOP_REALLOCBLKS() will need to grow a flag argument
to carry down IO_EXT to UFS.
PR: ports/125739
Reported by: Alexander Zagrebin <alexz@visp.ru>
Tested by: pluknet <pluknet@gmail.com>,
Greg Byshenk <freebsd@byshenk.net>
Discussed with: kib, kientzle, timur, Alexander Bokovoy <ab@samba.org>
Revision 1.151 / (download) - annotate - [select for diffs], Tue Jan 27 21:48:47 2009 UTC (5 months ago) by rwatson
Branch: MAIN
Changes since 1.150: +16 -7
lines
Diff to previous 1.150 (colored)
SVN rev 187790 on 2009-01-27 21:48:47Z by rwatson
Following a fair amount of real world experience with ACLs and
extended attributes since FreeBSD 5, make the following semantic
changes:
- Don't update the inode modification time (mtime) when extended
attributes (and hence also ACLs) are added, modified, or removed.
- Don't update the inode access tie (atime) when extended attributes
(and hence also ACLs) are queried.
This means that rsync (and related tools) won't improperly think
that the data in the file has changed when only the ACL has changed.
Note that ffs_reallocblks() has not been changed to not update on an
IO_EXT transaction, but currently EAs don't use the cluster write
routines so this shouldn't be a problem. If EAs grow support for
clustering, then VOP_REALLOCBLKS() will need to grow a flag argument
to carry down IO_EXT to UFS.
MFC after: 1 week
PR: ports/125739
Reported by: Alexander Zagrebin <alexz@visp.ru>
Tested by: pluknet <pluknet@gmail.com>,
Greg Byshenk <freebsd@byshenk.net>
Discussed with: kib, kientzle, timur, Alexander Bokovoy <ab@samba.org>
Revision 1.147.2.2.2.1 / (download) - annotate - [select for diffs], Tue Nov 25 02:59:29 2008 UTC (7 months, 1 week ago) by kensmith
Branch: RELENG_7_1
CVS Tags: RELENG_7_1_0_RELEASE
Changes since 1.147.2.2: +0 -0
lines
Diff to previous 1.147.2.2 (colored) next main 1.147.2.3 (colored)
SVN rev 185281 on 2008-11-25 02:59:29Z by kensmith Create releng/7.1 in preparation for moving into RC phase of 7.1 release cycle. Approved by: re (implicit)
Revision 1.132.2.11.2.1 / (download) - annotate - [select for diffs], Thu Oct 2 02:57:24 2008 UTC (9 months ago) by kensmith
Branch: RELENG_6_4
CVS Tags: RELENG_6_4_0_RELEASE
Changes since 1.132.2.11: +0 -0
lines
Diff to previous 1.132.2.11 (colored) next main 1.133 (colored)
SVN rev 183531 on 2008-10-02 02:57:24Z by kensmith Create releng/6.4 from stable/6 in preparation for 6.4-RC1. Approved by: re (implicit)
Revision 1.150 / (download) - annotate - [select for diffs], Thu Aug 28 09:19:50 2008 UTC (10 months ago) by kib
Branch: MAIN
Changes since 1.149: +11 -1
lines
Diff to previous 1.149 (colored)
SVN rev 182366 on 2008-08-28 09:19:50Z by kib In ffs_valloc(), ffs_vget() may fail because insmntque() refused to insert new vnode into the mount vnode list. Then, for the SU-enabled mount, ffs_vfree could create freefile dependency. This dependency can hang around forever since inode is not marked as IN_MODIFIED and correspondingly inodeblock may be not marked as dirty. After ffs_vget() fails, retry with FFSV_FORCEINSMQ, mark the inode as modified, and vput() it immediately. Take care of the dup alloc. Tested by: pho Reviewed by: tegge MFC after: 1 month
Revision 1.132.2.11 / (download) - annotate - [select for diffs], Mon Feb 25 09:30:00 2008 UTC (16 months, 1 week ago) by obrien
Branch: RELENG_6
CVS Tags: RELENG_6_4_BP
Branch point for: RELENG_6_4
Changes since 1.132.2.10: +2 -2
lines
Diff to previous 1.132.2.10 (colored) to branchpoint 1.132 (colored) next main 1.133 (colored)
MFC: fix spelling, sync comments, malloc type short descriptions, don't use function initializers in varible definitions, add GJOURNAL place holder
Revision 1.132.2.10 / (download) - annotate - [select for diffs], Mon Feb 25 08:37:54 2008 UTC (16 months, 1 week ago) by obrien
Branch: RELENG_6
Changes since 1.132.2.9: +2 -2
lines
Diff to previous 1.132.2.9 (colored) to branchpoint 1.132 (colored)
MFC: rev 1.140: drop two unnecessary casts.
Revision 1.132.2.9 / (download) - annotate - [select for diffs], Mon Feb 25 06:30:23 2008 UTC (16 months, 1 week ago) by obrien
Branch: RELENG_6
Changes since 1.132.2.8: +17 -17
lines
Diff to previous 1.132.2.8 (colored) to branchpoint 1.132 (colored)
MFC: Turn most ffs 'DIAGNOSTIC's into INVARIANTS.
Revision 1.147.2.2 / (download) - annotate - [select for diffs], Fri Feb 15 16:43:01 2008 UTC (16 months, 2 weeks ago) by obrien
Branch: RELENG_7
CVS Tags: RELENG_7_1_BP
Branch point for: RELENG_7_1
Changes since 1.147.2.1: +17 -17
lines
Diff to previous 1.147.2.1 (colored) to branchpoint 1.147 (colored)
MFC: Turn most ffs 'DIAGNOSTIC's into INVARIANTS.
Revision 1.132.2.8 / (download) - annotate - [select for diffs], Tue Jan 1 03:01:03 2008 UTC (18 months ago) by obrien
Branch: RELENG_6
Changes since 1.132.2.7: +4 -2
lines
Diff to previous 1.132.2.7 (colored) to branchpoint 1.132 (colored)
MFC: rev 1.149: Fix a broken DIAGNOSTICS/INVARIANTS check to handle a
block range that spans two block maps.
Revision 1.147.2.1 / (download) - annotate - [select for diffs], Tue Jan 1 03:00:17 2008 UTC (18 months ago) by obrien
Branch: RELENG_7
Changes since 1.147: +4 -2
lines
Diff to previous 1.147 (colored)
MFC: rev 1.149: Fix a broken DIAGNOSTICS/INVARIANTS check to handle a block range that spans two block maps. Approved by: re(kensmith)
Revision 1.149 / (download) - annotate - [select for diffs], Sat Dec 1 13:12:43 2007 UTC (19 months ago) by kensmith
Branch: MAIN
Changes since 1.148: +4 -2
lines
Diff to previous 1.148 (colored)
Fix a broken check that recently became more annoying because it now gets enabled when INVARIANTS is on instead of DIAGNOSTIC (which apparently nobody uses). From Tor's description: This happens when the block range spans two block maps, the first in the inode (mapping up to NDADDR direct blocks) and the second being the first indirect block. The current check assumes that both block maps are indirect blocks. Work done by: tegge Tested by: kris, kensmith
Revision 1.148 / (download) - annotate - [select for diffs], Thu Nov 8 17:21:49 2007 UTC (19 months, 3 weeks ago) by obrien
Branch: MAIN
Changes since 1.147: +17 -17
lines
Diff to previous 1.147 (colored)
Turn most ffs 'DIAGNOSTIC's into INVARIANTS.
Revision 1.132.2.7 / (download) - annotate - [select for diffs], Mon Sep 24 13:39:06 2007 UTC (21 months, 1 week ago) by bz
Branch: RELENG_6
CVS Tags: RELENG_6_3_BP,
RELENG_6_3_0_RELEASE,
RELENG_6_3
Changes since 1.132.2.6: +4 -1
lines
Diff to previous 1.132.2.6 (colored) to branchpoint 1.132 (colored)
MFC rev. 1.147 Fix a DIV0 in case a large value for fs_avgfilesize or fs_avgfpdir is given (with newfs or tunefs) and dirsize overflows. In case dirsize is <= 0 because of an overflow set maxcontigdirs to 0 so it will be 1 later. This is what would happen for large fs_avgfilesize. [1] Submitted by: pjd [1]
Revision 1.147 / (download) - annotate - [select for diffs], Mon Sep 10 14:12:29 2007 UTC (21 months, 3 weeks ago) by bz
Branch: MAIN
CVS Tags: RELENG_7_BP,
RELENG_7_0_BP,
RELENG_7_0_0_RELEASE,
RELENG_7_0
Branch point for: RELENG_7
Changes since 1.146: +4 -1
lines
Diff to previous 1.146 (colored)
Fix a DIV0 in case a large value for fs_avgfilesize or fs_avgfpdir is given (with newfs or tunefs) and dirsize overflows. In case dirsize is <= 0 because of an overflow set maxcontigdirs to 0 so it will be 1 later. This is what would happen for large fs_avgfilesize. [1] Identified with help from: roberto, pjd Submitted by: pjd [1] Approved by: re (rwatson) MFC after: 8 days
Revision 1.146 / (download) - annotate - [select for diffs], Tue Jun 12 00:12:01 2007 UTC (2 years ago) by rwatson
Branch: MAIN
Changes since 1.145: +2 -2
lines
Diff to previous 1.145 (colored)
Eliminate now-unused SUSER_ALLOWJAIL arguments to priv_check_cred(); in some cases, move to priv_check() if it was an operation on a thread and no other flags were present. Eliminate caller-side jail exception checking (also now-unused); jail privilege exception code now goes solely in kern_jail.c. We can't yet eliminate suser() due to some cases in the KAME code where a privilege check is performed and then used in many different deferred paths. Do, however, move those prototypes to priv.h. Reviewed by: csjp Obtained from: TrustedBSD Project
Revision 1.132.2.6 / (download) - annotate - [select for diffs], Mon Mar 19 18:56:40 2007 UTC (2 years, 3 months ago) by brian
Branch: RELENG_6
Changes since 1.132.2.5: +28 -3
lines
Diff to previous 1.132.2.5 (colored) to branchpoint 1.132 (colored)
MFC: Account for di_blocks allocations when IN_SPACECOUNTED is set in an
inode's i_flag. This fixes an eventual df/du discrepency resulting
from fs_pendingblocks being reduced to less than zero.
Revision 1.145 / (download) - annotate - [select for diffs], Fri Feb 23 20:23:35 2007 UTC (2 years, 4 months ago) by brian
Branch: MAIN
Changes since 1.144: +28 -3
lines
Diff to previous 1.144 (colored)
Account for di_blocks allocations when IN_SPACECOUNTED is set in an
inode's i_flag.
It's possible that after ufs_infactive() calls softdep_releasefile(),
i_nlink stays >0 for a considerable amount of time (> 60 seconds here).
During this period, any ffs allocation routines that alter di_blocks
must also account for the blocks in the filesystem's fs_pendingblocks
value.
This change fixes an eventual df/du discrepency that will happen as
the result of fs_pendingblocks being reduced to <0.
The only manifestation of this that people may recognise is the
following message on boot:
/somefs: update error: blocks -N files M
at which point the negative pending block count is adjusted to zero.
Reviewed by: tegge
MFC after: 3 weeks
Revision 1.144 / (download) - annotate - [select for diffs], Sat Feb 17 08:25:43 2007 UTC (2 years, 4 months ago) by mckusick
Branch: MAIN
Changes since 1.143: +0 -0
lines
Diff to previous 1.143 (colored)
This README file is obsolete. The cited problems were fixed long ago and the code is installed by default so no longer requires action by the administrator to be included.
Revision 1.132.2.5 / (download) - annotate - [select for diffs], Thu Feb 1 04:45:42 2007 UTC (2 years, 5 months ago) by mpp
Branch: RELENG_6
Changes since 1.132.2.4: +1 -1
lines
Diff to previous 1.132.2.4 (colored) to branchpoint 1.132 (colored)
MFC: Quota system cleanup & disallow negative ids when accouting for quota usage. ffs/ffs_alloc.c rev 1.143 ffs/ffs_snapshot.c rev 1.132 ufs/quota.h rev 1.29 ufs/ufs_quota.c rev 1.86 - 1.88 ufs/ufs_vfsops.c rev 1.48
Revision 1.143 / (download) - annotate - [select for diffs], Sat Jan 20 11:58:31 2007 UTC (2 years, 5 months ago) by mpp
Branch: MAIN
Changes since 1.142: +1 -1
lines
Diff to previous 1.142 (colored)
Quota system cleanup.
1) Do not do quota accounting for the actual quota data files
or for file system snapshot files ("system" files). This
prevents a deadlock descibed in PR kern/30958 if the kernel
ever has to grow the quota file. Snapshot files were already
exempt from the quota checks, but this change generalized the check.
2) Fix a cast that caused extremely large uids/gids to incorrectly
write the quota information to the data file at a truncated
value for a uint_t32 id value. The incorrect cast caused quota
files in this case to be around 4GB in size, with the correct cast
they can now be 131GB in size. Also related to PR kern/30958.
3) Check for what appear to be negative UIDs/GIDs and not account
for them. This prevents the quota files from becoming 131GB in
size and causing quotacheck to run forever at bootup. This could
also cause the kernel to try and expand the quota file, which might
deadlock due to the issue in #1. kern/30958 and kern/38156
(and some much older closed PR's).
4) With the deadlock problems gone, the kernel can now expand the
size of the quota database files if it needs to.
5) Pass in the i-node count change value to chkiq and chkiqchg as an
int, like it used to be before the common routine was split up
into 2 different routines to increase / decrease the i-node in-use
count. Prevents an underflow on the i-node count. Related
to PR kern/89247.
6) Prevent the block usage from growing slowly if a file system is
full and the write was denied due to that fact. PR kern/89247.
Some of these changes require an updated quotacheck to prevent
the creation of huge (131GB) quota data files (item #3).
#1/#4 probably fixes a lot of the random hangs when quotas are enabled,
possibly some of the jail hangs.
Revision 1.142 / (download) - annotate - [select for diffs], Tue Jan 16 19:35:43 2007 UTC (2 years, 5 months ago) by mpp
Branch: MAIN
Changes since 1.141: +2 -2
lines
Diff to previous 1.141 (colored)
Fix a spelling error in some comments. heirarchy -> hierarchy. Obtained from: OpenBSD
Revision 1.141 / (download) - annotate - [select for diffs], Mon Nov 6 13:42:09 2006 UTC (2 years, 7 months ago) by rwatson
Branch: MAIN
Changes since 1.140: +3 -2
lines
Diff to previous 1.140 (colored)
Sweep kernel replacing suser(9) calls with priv(9) calls, assigning
specific privilege names to a broad range of privileges. These may
require some future tweaking.
Sponsored by: nCircle Network Security, Inc.
Obtained from: TrustedBSD Project
Discussed on: arch@
Reviewed (at least in part) by: mlaier, jmg, pjd, bde, ceri,
Alex Lyashkov <umka at sevcity dot net>,
Skip Ford <skip dot ford at verizon dot net>,
Antoine Brodin <antoine dot brodin at laposte dot net>
Revision 1.140 / (download) - annotate - [select for diffs], Tue Jul 18 07:03:43 2006 UTC (2 years, 11 months ago) by stefanf
Branch: MAIN
Changes since 1.139: +2 -2
lines
Diff to previous 1.139 (colored)
Drop two unnecessary casts.
Revision 1.132.2.4 / (download) - annotate - [select for diffs], Mon Mar 13 03:07:32 2006 UTC (3 years, 3 months ago) by jeff
Branch: RELENG_6
CVS Tags: RELENG_6_2_BP,
RELENG_6_2_0_RELEASE,
RELENG_6_2,
RELENG_6_1_BP,
RELENG_6_1_0_RELEASE,
RELENG_6_1
Changes since 1.132.2.3: +3 -3
lines
Diff to previous 1.132.2.3 (colored) to branchpoint 1.132 (colored)
MFC Rev 1.139 VFS SMP fixes, stack api, softupdates fixes. Sponsored by: Isilon Systems, Inc. Approved by: re (scottl)
Revision 1.139 / (download) - annotate - [select for diffs], Thu Mar 2 05:50:23 2006 UTC (3 years, 4 months ago) by jeff
Branch: MAIN
Changes since 1.138: +3 -3
lines
Diff to previous 1.138 (colored)
- Move softdep from using a global worklist to per-mount worklists. This has many positive effects including improved smp locking, reducing interdependencies between mounts that can lead to deadlocks, etc. - Add the softdep worklist and various counters to the ufsmnt structure. - Add a mount pointer to the workitem and remove mount pointers from the various structures derived from the workitem as they are now redundant. - Remove the poor-man's semaphore protecting softdep_process_worklist and softdep_flushworklist. Several threads may now process the list simultaneously. - Add softdep_waitidle() to block the thread until all pending dependencies being operated on by other threads have been flushed. - Use softdep_waitidle() in unmount and snapshots to block either operation until the fs is stable. - Remove softdep worklist processing from the syncer and move it into the softdep_flush() thread. This thread processes all softdep mounts once each second and when it is called via the new softdep_speedup() when there is a resource shortage. This removes the softdep hook from the kernel and various hacks in header files to support it. Reviewed by/Discussed with: tegge, truckman, mckusick Tested by: kris
Revision 1.132.2.3 / (download) - annotate - [select for diffs], Wed Dec 28 20:11:51 2005 UTC (3 years, 6 months ago) by ps
Branch: RELENG_6
Changes since 1.132.2.2: +21 -6
lines
Diff to previous 1.132.2.2 (colored) to branchpoint 1.132 (colored)
MFC: - rate limit vnode_pager_putpages printfs to once a second. - rate limit filesystem full and out of inodes messages to once a second.
Revision 1.138 / (download) - annotate - [select for diffs], Mon Oct 31 20:33:28 2005 UTC (3 years, 8 months ago) by ps
Branch: MAIN
Changes since 1.137: +21 -6
lines
Diff to previous 1.137 (colored)
Rate limit filesystem full and out of inodes messages to once a second.
Revision 1.132.2.1.2.1 / (download) - annotate - [select for diffs], Sat Oct 29 07:00:45 2005 UTC (3 years, 8 months ago) by scottl
Branch: RELENG_6_0
CVS Tags: RELENG_6_0_0_RELEASE
Changes since 1.132.2.1: +6 -0
lines
Diff to previous 1.132.2.1 (colored) next main 1.132.2.2 (colored)
Sync RELENG_6_0 with all of the FFS fixes from Tor. Submitted by: tegge Approved by: re
Revision 1.132.2.2 / (download) - annotate - [select for diffs], Sat Oct 29 06:38:13 2005 UTC (3 years, 8 months ago) by scottl
Branch: RELENG_6
Changes since 1.132.2.1: +6 -0
lines
Diff to previous 1.132.2.1 (colored) to branchpoint 1.132 (colored)
MFC rev 1.136 and 1.137 Submitted by: tegge Approved by: re
Revision 1.137 / (download) - annotate - [select for diffs], Mon Oct 10 19:02:04 2005 UTC (3 years, 8 months ago) by tegge
Branch: MAIN
Changes since 1.136: +1 -0
lines
Diff to previous 1.136 (colored)
Avoid unintended VMIO on directories and symlinks due to leftover object not having been destroyed.
Revision 1.136 / (download) - annotate - [select for diffs], Sun Oct 9 19:06:34 2005 UTC (3 years, 8 months ago) by tegge
Branch: MAIN
Changes since 1.135: +5 -0
lines
Diff to previous 1.135 (colored)
Reinitialize v_type and v_op fields in case vnode has been reused without reclamation. If the vnode previously was a fifo then v_op would point to ffs_fifoops[12] instead of the expected ffs_vnodeops[12], causing a panic at the end of ffsext_strategy.
Revision 1.123.2.5 / (download) - annotate - [select for diffs], Sat Oct 8 20:04:28 2005 UTC (3 years, 8 months ago) by truckman
Branch: RELENG_5
CVS Tags: RELENG_5_5_BP,
RELENG_5_5_0_RELEASE,
RELENG_5_5
Changes since 1.123.2.4: +1 -0
lines
Diff to previous 1.123.2.4 (colored) to branchpoint 1.123 (colored) next main 1.124 (colored)
MFC ffs_alloc.c 1.135 - clear i_flag field in recycled inodes
The IN_HASHED bit should not be cleared here in RELENG_5.
Original commit message:
truckman 2005-10-03 21:57:43 UTC
FreeBSD src repository
Modified files:
sys/ufs/ffs ffs_alloc.c
Log:
Initialize the inode i_flag field in ffs_valloc() to clean up any
stale flag bits left over from before the inode was recycled.
Without this change, a leftover IN_SPACECOUNTED flag could prevent
softdep_freefile() and softdep_releasefile() from incrementing
fs_pendinginodes. Because handle_workitem_freefile() unconditionally
decrements fs_pendinginodes, a negative value could be reported at
file system unmount time with a message like:
unmount pending error: blocks 0 files -3
The pending block count in fs_pendingblocks could also be negative
for similar reasons. These errors can cause the data returned by
statfs() to be slightly incorrect. Some other cleanup code in
softdep_releasefile() could also be incorrectly bypassed.
MFC after: 3 days
Revision Changes Path
1.135 +1 -0 src/sys/ufs/ffs/ffs_alloc.c
Revision 1.132.2.1 / (download) - annotate - [select for diffs], Wed Oct 5 05:24:53 2005 UTC (3 years, 8 months ago) by truckman
Branch: RELENG_6
CVS Tags: RELENG_6_0_BP
Branch point for: RELENG_6_0
Changes since 1.132: +1 -0
lines
Diff to previous 1.132 (colored)
MFC ffs_alloc.c 1.135 - clear i_flag field in recycled inodes
Original commit message:
FreeBSD src repository
Modified files:
sys/ufs/ffs ffs_alloc.c
Log:
Initialize the inode i_flag field in ffs_valloc() to clean up any
stale flag bits left over from before the inode was recycled.
Without this change, a leftover IN_SPACECOUNTED flag could prevent
softdep_freefile() and softdep_releasefile() from incrementing
fs_pendinginodes. Because handle_workitem_freefile() unconditionally
decrements fs_pendinginodes, a negative value could be reported at
file system unmount time with a message like:
unmount pending error: blocks 0 files -3
The pending block count in fs_pendingblocks could also be negative
for similar reasons. These errors can cause the data returned by
statfs() to be slightly incorrect. Some other cleanup code in
softdep_releasefile() could also be incorrectly bypassed.
Reviewed by: tegge
Approved by: re (scottl)
Revision 1.135 / (download) - annotate - [select for diffs], Mon Oct 3 21:57:43 2005 UTC (3 years, 9 months ago) by truckman
Branch: MAIN
Changes since 1.134: +1 -0
lines
Diff to previous 1.134 (colored)
Initialize the inode i_flag field in ffs_valloc() to clean up any
stale flag bits left over from before the inode was recycled.
Without this change, a leftover IN_SPACECOUNTED flag could prevent
softdep_freefile() and softdep_releasefile() from incrementing
fs_pendinginodes. Because handle_workitem_freefile() unconditionally
decrements fs_pendinginodes, a negative value could be reported at
file system unmount time with a message like:
unmount pending error: blocks 0 files -3
The pending block count in fs_pendingblocks could also be negative
for similar reasons. These errors can cause the data returned by
statfs() to be slightly incorrect. Some other cleanup code in
softdep_releasefile() could also be incorrectly bypassed.
MFC after: 3 days
Revision 1.134 / (download) - annotate - [select for diffs], Wed Sep 28 07:03:03 2005 UTC (3 years, 9 months ago) by rwatson
Branch: MAIN
Changes since 1.133: +0 -6
lines
Diff to previous 1.133 (colored)
Back out alpha/alpha/trap.c:1.124, osf1_ioctl.c:1.14, osf1_misc.c:1.57, osf1_signal.c:1.41, amd64/amd64/trap.c:1.291, linux_socket.c:1.60, svr4_fcntl.c:1.36, svr4_ioctl.c:1.23, svr4_ipc.c:1.18, svr4_misc.c:1.81, svr4_signal.c:1.34, svr4_stat.c:1.21, svr4_stream.c:1.55, svr4_termios.c:1.13, svr4_ttold.c:1.15, svr4_util.h:1.10, ext2_alloc.c:1.43, i386/i386/trap.c:1.279, vm86.c:1.58, unaligned.c:1.12, imgact_elf.c:1.164, ffs_alloc.c:1.133: Now that Giant is acquired in uprintf() and tprintf(), the caller no longer leads to acquire Giant unless it also holds another mutex that would generate a lock order reversal when calling into these functions. Specifically not backed out is the acquisition of Giant in nfs_socket.c and rpcclnt.c, where local mutexes are held and would otherwise violate the lock order with Giant. This aligns this code more with the eventual locking of ttys. Suggested by: bde
Revision 1.133 / (download) - annotate - [select for diffs], Mon Sep 19 16:51:43 2005 UTC (3 years, 9 months ago) by rwatson
Branch: MAIN
Changes since 1.132: +6 -0
lines
Diff to previous 1.132 (colored)
Add GIANT_REQUIRED and WITNESS sleep warnings to uprintf() and tprintf(), as they both interact with the tty code (!MPSAFE) and may sleep if the tty buffer is full (per comment). Modify all consumers of uprintf() and tprintf() to hold Giant around calls into these functions. In most cases, this means adding an acquisition of Giant immediately around the function. In some cases (nfs_timer()), it means acquiring Giant higher up in the callout. With these changes, UFS no longer panics on SMP when either blocks are exhausted or inodes are exhausted under load due to races in the tty code when running without Giant. NB: Some reduction in calls to uprintf() in the svr4 code is probably desirable. NB: In the case of nfs_timer(), calling uprintf() while holding a mutex, or even in a callout at all, is a bad idea, and will generate warnings and potential upset. This needs to be fixed, but was a problem before this change. NB: uprintf()/tprintf() sleeping is generally a bad ideas, as is having non-MPSAFE tty code. MFC after: 1 week
Revision 1.123.2.4 / (download) - annotate - [select for diffs], Mon Feb 28 16:04:52 2005 UTC (4 years, 4 months ago) by delphij
Branch: RELENG_5
CVS Tags: RELENG_5_4_BP,
RELENG_5_4_0_RELEASE,
RELENG_5_4
Changes since 1.123.2.3: +68 -1
lines
Diff to previous 1.123.2.3 (colored) to branchpoint 1.123 (colored)
MFC: Transferr the responsibility of recomputation of the superblock summary to background fsck. This will improve startup speed when mounting a large volume. Original commit log: The recomputation of file system summary at mount time can be a very slow process, especially for large file systems that is just recovered from a crash. Since the summary is already re-sync'ed every 30 second, we will not lag behind too much after a crash. With this consideration in mind, it is more reasonable to transfer the responsibility to background fsck, to reduce the delay after a crash. Add a new sysctl variable, vfs.ffs.compute_summary_at_mount, to control this behavior. When set to nonzero, we will get the "old" behavior, that the summary is computed immediately at mount time. Add five new sysctl variables to adjust ndir, nbfree, nifree, nffree and numclusters respectively. Teach fsck_ffs about these API, however, intentionally not to check the existence, since kernels without these sysctls must have recomputed the summary and hence no adjustments are necessary. This change has eliminated the usual tens of minutes of delay of mounting large dirty volumes. Reviewed by: mckusick Revision Changes Path 1.35 +5 -0 src/sbin/fsck_ffs/fsck.h 1.41 +55 -0 src/sbin/fsck_ffs/pass5.c 1.132 +68 -1 src/sys/ufs/ffs/ffs_alloc.c 1.176 +12 -3 src/sys/ufs/ffs/ffs_softdep.c 1.48 +6 -1 src/sys/ufs/ffs/fs.h
Revision 1.123.2.3 / (download) - annotate - [select for diffs], Mon Feb 28 10:33:20 2005 UTC (4 years, 4 months ago) by delphij
Branch: RELENG_5
Changes since 1.123.2.2: +5 -5
lines
Diff to previous 1.123.2.2 (colored) to branchpoint 1.123 (colored)
MFC a part of static'ify of the FFS/UFS code, originally by phk: Make a some SYSCTL_NODEs and some of FFS's VFS_ methods static. Revision Changes Path 1.131 +5 -5 src/sys/ufs/ffs/ffs_alloc.c 1.68 +0 -5 src/sys/ufs/ffs/ffs_extern.h 1.278 +12 -7 src/sys/ufs/ffs/ffs_vfsops.c 1.21 +1 -1 src/sys/ufs/ufs/ufs_dirhash.c Discussed with: phk
Revision 1.132 / (download) - annotate - [select for diffs], Sun Feb 20 08:02:15 2005 UTC (4 years, 4 months ago) by delphij
Branch: MAIN
CVS Tags: RELENG_6_BP
Branch point for: RELENG_6
Changes since 1.131: +68 -1
lines
Diff to previous 1.131 (colored)
The recomputation of file system summary at mount time can be a very slow process, especially for large file systems that is just recovered from a crash. Since the summary is already re-sync'ed every 30 second, we will not lag behind too much after a crash. With this consideration in mind, it is more reasonable to transfer the responsibility to background fsck, to reduce the delay after a crash. Add a new sysctl variable, vfs.ffs.compute_summary_at_mount, to control this behavior. When set to nonzero, we will get the "old" behavior, that the summary is computed immediately at mount time. Add five new sysctl variables to adjust ndir, nbfree, nifree, nffree and numclusters respectively. Teach fsck_ffs about these API, however, intentionally not to check the existence, since kernels without these sysctls must have recomputed the summary and hence no adjustments are necessary. This change has eliminated the usual tens of minutes of delay of mounting large dirty volumes. Reviewed by: mckusick MFC After: 1 week
Revision 1.131 / (download) - annotate - [select for diffs], Thu Feb 10 12:20:08 2005 UTC (4 years, 4 months ago) by phk
Branch: MAIN
Changes since 1.130: +5 -5
lines
Diff to previous 1.130 (colored)
Make a some SYSCTL_NODEs and some of FFS's VFS_ methods static.
Revision 1.130 / (download) - annotate - [select for diffs], Tue Feb 8 17:40:01 2005 UTC (4 years, 4 months ago) by phk
Branch: MAIN
Changes since 1.129: +6 -6
lines
Diff to previous 1.129 (colored)
Don't use the UFS_* and VFS_* functions where a direct call is possble. The UFS_ functions are for UFS to call back into VFS. The VFS functions are external entry points into the filesystem.
Revision 1.123.2.2 / (download) - annotate - [select for diffs], Mon Jan 31 23:26:59 2005 UTC (4 years, 5 months ago) by imp
Branch: RELENG_5
Changes since 1.123.2.1: +22 -1
lines
Diff to previous 1.123.2.1 (colored) to branchpoint 1.123 (colored)
MFC: /*- and related license changes
Revision 1.129 / (download) - annotate - [select for diffs], Mon Jan 24 10:08:35 2005 UTC (4 years, 5 months ago) by jeff
Branch: MAIN
Changes since 1.128: +183 -96
lines
Diff to previous 1.128 (colored)
- Don't use atomic operations to deal with the active array, instead it is now quite naturally protected by the ufsmount mutex. - Use the ufs lock to protect various fields in struct fs, primarily the cg summary needs protection to avoid allocation races. Several functions have been slightly re-arranged to reduce the number of lock operations. - Adjust several functions (blkfree, freefile, etc.) to accept a ufsmount as an argument so that we may access the ufs lock. Sponsored By: Isilon Systems, Inc.
Revision 1.128 / (download) - annotate - [select for diffs], Fri Jan 7 02:29:25 2005 UTC (4 years, 5 months ago) by imp
Branch: MAIN
Changes since 1.127: +1 -1
lines
Diff to previous 1.127 (colored)
/* -> /*- for license, minor formatting changes
Revision 1.123.2.1 / (download) - annotate - [select for diffs], Sat Jan 1 00:38:00 2005 UTC (4 years, 6 months ago) by mckusick
Branch: RELENG_5
Changes since 1.123: +9 -9
lines
Diff to previous 1.123 (colored)
MFC from 1.127 2004/12/09 of the main tree: Fixes a bug that caused UFS2 filesystems bigger than 2TB to prematurely report that they were full and/or to panic the kernel with the message ``ffs_clusteralloc: allocated out of group''. Submitted by: Henry Whincup <henry@jot.to>
Revision 1.127 / (download) - annotate - [select for diffs], Thu Dec 9 21:24:00 2004 UTC (4 years, 6 months ago) by mckusick
Branch: MAIN
Changes since 1.126: +9 -9
lines
Diff to previous 1.126 (colored)
Fixes a bug that caused UFS2 filesystems bigger than 2TB to prematurely report that they were full and/or to panic the kernel with the message ``ffs_clusteralloc: allocated out of group''. Submitted by: Henry Whincup <henry@jot.to> MFC after: 1 week
Revision 1.126 / (download) - annotate - [select for diffs], Fri Oct 29 10:15:55 2004 UTC (4 years, 8 months ago) by phk
Branch: MAIN
Changes since 1.125: +0 -3
lines
Diff to previous 1.125 (colored)
Move UFS from DEVFS backing to GEOM backing. This eliminates a bunch of vnode overhead (approx 1-2 % speed improvement) and gives us more control over the access to the storage device. Access counts on the underlying device are not correctly tracked and therefore it is possible to read-only mount the same disk device multiple times: syv# mount -p /dev/md0 /var ufs rw 2 2 /dev/ad0 /mnt ufs ro 1 1 /dev/ad0 /mnt2 ufs ro 1 1 /dev/ad0 /mnt3 ufs ro 1 1 Since UFS/FFS is not a synchrousely consistent filesystem (ie: it caches things in RAM) this is not possible with read-write mounts, and the system will correctly reject this. Details: Add a geom consumer and a bufobj pointer to ufsmount. Eliminate the vnode argument from softdep_disk_prewrite(). Pick the vnode out of bp->b_vp for now. Eventually we should find it through bp->b_bufobj->b_private. In the mountcode, use g_vfs_open() once we have used VOP_ACCESS() to check permissions. When upgrading and downgrading between r/o and r/w do the right thing with GEOM access counts. Remove all the workarounds for not being able to do this with VOP_OPEN(). If we are the root mount, drop the exclusive access count until we upgrade to r/w. This allows fsck of the root filesystem and the MNT_RELOAD to work correctly. Set bo_private to the GEOM consumer on the device bufobj. Change the ffs_ops->strategy function to call g_vfs_strategy() In ufs_strategy() directly call the strategy on the disk bufobj. Same in rawread. In ffs_fsync() we will no longer see VCHR device nodes, so remove code which synced the filesystem mounted on it, in case we came there. I'm not sure this code made sense in the first place since we would have taken the specfs route on such a vnode. Redo the highly bogus readblock() function in the snapshot code to something slightly less bogus: Constructing an uio and using physio was really quite a detour. Instead just fill in a bio and ship it down.
Revision 1.125 / (download) - annotate - [select for diffs], Wed Oct 20 08:04:36 2004 UTC (4 years, 8 months ago) by rwatson
Branch: MAIN
Changes since 1.124: +21 -0
lines
Diff to previous 1.124 (colored)
Explicitly break out NETA license from Berkeley license to clearly indicate license grant, as well as to indicate that NETA is asserting only two clauses, not four clauses. Requested by: imp
Revision 1.124 / (download) - annotate - [select for diffs], Mon Sep 13 06:50:42 2004 UTC (4 years, 9 months ago) by phk
Branch: MAIN
Changes since 1.123: +0 -1
lines
Diff to previous 1.123 (colored)
Remove the buffercache/vnode side of BIO_DELETE processing in preparation for integration of p4::phk_bufwork. In the future, local filesystems will talk to GEOM directly and they will consequently be able to issue BIO_DELETE directly. Since the removal of the fla driver, BIO_DELETE has effectively been a no-op anyway.
Revision 1.123 / (download) - annotate - [select for diffs], Wed Jul 28 06:41:26 2004 UTC (4 years, 11 months ago) by kan
Branch: MAIN
CVS Tags: RELENG_5_BP,
RELENG_5_3_BP,
RELENG_5_3_0_RELEASE,
RELENG_5_3
Branch point for: RELENG_5
Changes since 1.122: +8 -8
lines
Diff to previous 1.122 (colored)
Avoid using casts as lvalues. Introduce DIP_SET macro which sets proper inode field based on UFS version. Use DIP ro read values and DIP_SET to modify them throughout FFS code base.
Revision 1.122 / (download) - annotate - [select for diffs], Mon Jul 26 07:24:04 2004 UTC (4 years, 11 months ago) by cperciva
Branch: MAIN
Changes since 1.121: +2 -2
lines
Diff to previous 1.121 (colored)
Rename suser_cred()'s PRISON_ROOT flag to SUSER_ALLOWJAIL. This is somewhat clearer, but more importantly allows for a consistent naming scheme for suser_cred flags. The old name is still defined, but will be removed in a few days (unless I hear any complaints...) Discussed with: rwatson, scottl Requested by: jhb
Revision 1.121 / (download) - annotate - [select for diffs], Wed Jun 16 09:47:25 2004 UTC (5 years ago) by phk
Branch: MAIN
Changes since 1.120: +2 -2
lines
Diff to previous 1.120 (colored)
Do the dreaded s/dev_t/struct cdev */ Bump __FreeBSD_version accordingly.
Revision 1.64.2.5 / (download) - annotate - [select for diffs], Wed May 19 18:07:15 2004 UTC (5 years, 1 month ago) by kensmith
Branch: RELENG_4
CVS Tags: RELENG_4_11_BP,
RELENG_4_11_0_RELEASE,
RELENG_4_11
Changes since 1.64.2.4: +2 -4
lines
Diff to previous 1.64.2.4 (colored) to branchpoint 1.64 (colored) next main 1.65 (colored)
Style fixup in previous commit. Noticed by: bde (thanks!)
Revision 1.120 / (download) - annotate - [select for diffs], Wed May 19 18:06:21 2004 UTC (5 years, 1 month ago) by kensmith
Branch: MAIN
Changes since 1.119: +2 -4
lines
Diff to previous 1.119 (colored)
Style fixup in previous commit. Noticed by: bde (thanks!)
Revision 1.64.2.3.2.1 / (download) - annotate - [select for diffs], Fri May 14 23:03:50 2004 UTC (5 years, 1 month ago) by kensmith
Branch: RELENG_4_10
CVS Tags: RELENG_4_10_0_RELEASE
Changes since 1.64.2.3: +10 -2
lines
Diff to previous 1.64.2.3 (colored) next main 1.64.2.4 (colored)
MFS of rev 1.64.2.4: Change ffs_realloccg() to set the valid bits for the extended part of the fragment to zero the valid parts of a VM_IO buffer. Approved by: re (bmah)
Revision 1.64.2.4 / (download) - annotate - [select for diffs], Fri May 14 22:02:36 2004 UTC (5 years, 1 month ago) by kensmith
Branch: RELENG_4
Changes since 1.64.2.3: +10 -2
lines
Diff to previous 1.64.2.3 (colored) to branchpoint 1.64 (colored)
MFC of 1.119, Change ffs_realloccg() to set the valid bits for the extended part of the fragment to zero the valid parts of a VM_IO buffer. Reviewed by: alc, tegge MFS: immediately
Revision 1.119 / (download) - annotate - [select for diffs], Fri May 14 22:00:08 2004 UTC (5 years, 1 month ago) by kensmith
Branch: MAIN
Changes since 1.118: +10 -2
lines
Diff to previous 1.118 (colored)
Change ffs_realloccg() to set the valid bits for the extended part of the fragment to zero the valid parts of a VM_IO buffer. RE would like this to be part of 4.10-RC3 so this will be MFC-ed immediately. Reviewed by: alc, tegge
Revision 1.118 / (download) - annotate - [select for diffs], Wed Apr 7 03:47:20 2004 UTC (5 years, 2 months ago) by imp
Branch: MAIN
Changes since 1.117: +0 -4
lines
Diff to previous 1.117 (colored)
Remove advertising clause from University of California Regent's license, per letter dated July 22, 1999 and irc message from Robert Watson saying that clause 3 can be removed from those files with an NAI copyright that also have only a University of California copyrights. Approved by: core, rwatson
Revision 1.117 / (download) - annotate - [select for diffs], Tue Mar 16 22:06:32 2004 UTC (5 years, 3 months ago) by kan
Branch: MAIN
Changes since 1.116: +3 -1
lines
Diff to previous 1.116 (colored)
Avoid doing bawrite to initialize inode block while holding cylinder group block locked. If filesystem has any active snapshots, bawrite can come back trying to allocate new snapshot data block from the same cylinder group and cause panic due to recursive lock attempt. PR: 64206 Reviewed by: mckusick Tested by: pjd
Revision 1.64.2.3 / (download) - annotate - [select for diffs], Tue Nov 18 03:36:23 2003 UTC (5 years, 7 months ago) by truckman
Branch: RELENG_4
CVS Tags: RELENG_4_10_BP
Branch point for: RELENG_4_10
Changes since 1.64.2.2: +8 -8
lines
Diff to previous 1.64.2.2 (colored) to branchpoint 1.64 (colored)
MFC 1.116 which tweaks the minbfree, minifree, maxcontigdirs calculations to give results that work better.
Revision 1.116 / (download) - annotate - [select for diffs], Fri Oct 31 07:25:06 2003 UTC (5 years, 8 months ago) by truckman
Branch: MAIN
CVS Tags: RELENG_5_2_BP,
RELENG_5_2_1_RELEASE,
RELENG_5_2_0_RELEASE,
RELENG_5_2
Changes since 1.115: +7 -7
lines
Diff to previous 1.115 (colored)
Tweak the calculation of minbfree in ffs_dirpref() so that only those cylinder groups that have at least 75% of the average free space per cylinder group for that file system are considered as candidates for the creation of a new directory. The previous formula for minbfree would set it to zero if the file system was more than 75% full, which allowed cylinder groups with no free space at all to be chosen as candidates for directory creation, which resulted in an expensive search for free blocks for each file that was subsequently created in that directory. Modify the calculation of minifree in the same way. Decrease maxcontigdirs as the file system fills to decrease the likelyhood that a cluster of directories will overflow the available space in a cylinder group. Reviewed by: mckusick Tested by: kmarx@vicor.com MFC after: 2 weeks
Revision 1.115 / (download) - annotate - [select for diffs], Wed Jun 11 06:31:28 2003 UTC (6 years ago) by obrien
Branch: MAIN
Changes since 1.114: +3 -1
lines
Diff to previous 1.114 (colored)
Use __FBSDID().
Revision 1.114 / (download) - annotate - [select for diffs], Sat May 31 18:17:32 2003 UTC (6 years, 1 month ago) by phk
Branch: MAIN
Changes since 1.113: +4 -4
lines
Diff to previous 1.113 (colored)
Remove unused local variables. Found by: FlexeLint
Revision 1.113 / (download) - annotate - [select for diffs], Thu Mar 20 21:15:54 2003 UTC (6 years, 3 months ago) by jhb
Branch: MAIN
CVS Tags: RELENG_5_1_BP,
RELENG_5_1_0_RELEASE,
RELENG_5_1
Changes since 1.112: +3 -3
lines
Diff to previous 1.112 (colored)
Minor fixes to ffs_fserr(): - Assume that curthread is not NULL. It never is in -current. - Use td_ucred instead of p_ucred.
Revision 1.112 / (download) - annotate - [select for diffs], Tue Mar 18 08:45:24 2003 UTC (6 years, 3 months ago) by phk
Branch: MAIN
Changes since 1.111: +0 -1
lines
Diff to previous 1.111 (colored)
Including <sys/stdint.h> is (almost?) universally only to be able to use %j in printfs, so put a newsted include in <sys/systm.h> where the printf prototype lives and save everybody else the trouble.
Revision 1.111 / (download) - annotate - [select for diffs], Tue Mar 4 00:04:43 2003 UTC (6 years, 4 months ago) by jeff
Branch: MAIN
Changes since 1.110: +1 -1
lines
Diff to previous 1.110 (colored)
- Add a new 'flags' parameter to getblk(). - Define one flag GB_LOCK_NOWAIT that tells getblk() to pass the LK_NOWAIT flag to the initial BUF_LOCK(). This will eventually be used in cases were we want to use a buffer only if it is not currently in use. - Convert all consumers of the getblk() api to use this extra parameter. Reviwed by: arch Not objected to by: mckusick
Revision 1.110 / (download) - annotate - [select for diffs], Sat Feb 22 00:29:51 2003 UTC (6 years, 4 months ago) by mckusick
Branch: MAIN
Changes since 1.109: +41 -0
lines
Diff to previous 1.109 (colored)
This patch fixes a bug on an active filesystem on which a snapshot is being taken from panicing with either "freeing free block" or "freeing free inode". The problem arises when the snapshot code is scanning the filesystem looking for inodes with a reference count of zero (e.g., unlinked but still open) so that it can expunge them from its view. If it encounters a reclaimed vnode and has to restart its scan, then it will panic if it encounters and tries to free an inode that it has already processed. The fix is to check each candidate inode to see if it has already been processed before trying to delete it from the snapshot image. Sponsored by: DARPA & NAI Labs.
Revision 1.109 / (download) - annotate - [select for diffs], Fri Feb 14 21:31:57 2003 UTC (6 years, 4 months ago) by mckusick
Branch: MAIN
Changes since 1.108: +2 -2
lines
Diff to previous 1.108 (colored)
Replace use of random() with arc4random() to provide less guessable values for the initial inode generation numbers in newfs and for newly allocated inode generation numbers in the kernel. Submitted by: Theo de Raadt <deraadt@cvs.openbsd.org> Sponsored by: DARPA & NAI Labs.
Revision 1.103.2.1 / (download) - annotate - [select for diffs], Fri Feb 14 00:31:06 2003 UTC (6 years, 4 months ago) by mckusick
Branch: RELENG_5_0
Changes since 1.103: +0 -3
lines
Diff to previous 1.103 (colored) next main 1.104 (colored)
Correct lines incorrectly added to the copyright message. Submitted by: Frank van der Linden <fvdl@wasabisystems.com> Sponsored by: DARPA & NAI Labs.
Revision 1.108 / (download) - annotate - [select for diffs], Fri Feb 14 00:28:49 2003 UTC (6 years, 4 months ago) by mckusick
Branch: MAIN
Changes since 1.107: +0 -3
lines
Diff to previous 1.107 (colored)
Correct lines incorrectly added to the copyright message. Submitted by: Frank van der Linden <fvdl@wasabisystems.com> Sponsored by: DARPA & NAI Labs.
Revision 1.107 / (download) - annotate - [select for diffs], Mon Jan 13 00:28:58 2003 UTC (6 years, 5 months ago) by dillon
Branch: MAIN
Changes since 1.106: +1 -1
lines
Diff to previous 1.106 (colored)
Bow to the whining masses and change a union back into void *. Retain removal of unnecessary casts and throw in some minor cleanups to see if anyone complains, just for the hell of it.
Revision 1.106 / (download) - annotate - [select for diffs], Sun Jan 12 01:37:09 2003 UTC (6 years, 5 months ago) by dillon
Branch: MAIN
Changes since 1.105: +1 -1
lines
Diff to previous 1.105 (colored)
Change struct file f_data to un_data, a union of the correct struct pointer types, and remove a huge number of casts from code using it. Change struct xfile xf_data to xun_data (ABI is still compatible). If we need to add a #define for f_data and xf_data we can, but I don't think it will be necessary. There are no operational changes in this commit.
Revision 1.105 / (download) - annotate - [select for diffs], Wed Jan 1 01:56:19 2003 UTC (6 years, 6 months ago) by alfred
Branch: MAIN
Changes since 1.104: +1 -0
lines
Diff to previous 1.104 (colored)
When compiling the kernel do not implicitly include filedesc.h from proc.h, this was causing filedesc work to be very painful. In order to make this work split out sigio definitions to thier own header (sigio.h) which is included from proc.h for the time being.
Revision 1.104 / (download) - annotate - [select for diffs], Wed Dec 18 00:53:45 2002 UTC (6 years, 6 months ago) by mckusick
Branch: MAIN
Changes since 1.103: +5 -5
lines
Diff to previous 1.103 (colored)
Cosmetic cleanup of unsigned buglets. Submitted by: Bruce Evans <bde@zeta.org.au> Sponsored by: DARPA & NAI Labs.
Revision 1.103 / (download) - annotate - [select for diffs], Fri Dec 6 02:08:46 2002 UTC (6 years, 6 months ago) by mckusick
Branch: MAIN
CVS Tags: RELENG_5_0_BP,
RELENG_5_0_0_RELEASE
Branch point for: RELENG_5_0
Changes since 1.102: +1 -1
lines
Diff to previous 1.102 (colored)
More tightly verify the preference returned for the new inode. Submitted by: Kris Kennaway <kris@obsecurity.org> Sponsored by: DARPA & NAI Labs. Approved by: re
Revision 1.102 / (download) - annotate - [select for diffs], Thu Sep 19 03:55:30 2002 UTC (6 years, 9 months ago) by obrien
Branch: MAIN
Changes since 1.101: +7 -7
lines
Diff to previous 1.101 (colored)
intmax_t is printed with %jd, not %lld.
Revision 1.101 / (download) - annotate - [select for diffs], Sun Aug 4 10:29:35 2002 UTC (6 years, 11 months ago) by jeff
Branch: MAIN
Changes since 1.100: +4 -2
lines
Diff to previous 1.100 (colored)
- Replace v_flag with v_iflag and v_vflag - v_vflag is protected by the vnode lock and is used when synchronization with VOP calls is needed. - v_iflag is protected by interlock and is used for dealing with vnode management issues. These flags include X/O LOCK, FREE, DOOMED, etc. - All accesses to v_iflag and v_vflag have either been locked or marked with mp_fixme's. - Many ASSERT_VOP_LOCKED calls have been added where the locking was not clear. - Many functions in vfs_subr.c were restructured to provide for stronger locking. Idea stolen from: BSD/OS
Revision 1.100 / (download) - annotate - [select for diffs], Tue Jul 30 12:02:41 2002 UTC (6 years, 11 months ago) by phk
Branch: MAIN
Changes since 1.99: +0 -3
lines
Diff to previous 1.99 (colored)
Fix braino in last commit.
Revision 1.99 / (download) - annotate - [select for diffs], Tue Jul 30 11:54:48 2002 UTC (6 years, 11 months ago) by phk
Branch: MAIN
Changes since 1.98: +25 -0
lines
Diff to previous 1.98 (colored)
Move ffs_isfreeblock() to ffs_alloc.c and make it static. Sponsored by: DARPA & NAI Labs.
Revision 1.98 / (download) - annotate - [select for diffs], Fri Jul 19 07:29:38 2002 UTC (6 years, 11 months ago) by mckusick
Branch: MAIN
Changes since 1.97: +4 -3
lines
Diff to previous 1.97 (colored)
Add support to UFS2 to provide storage for extended attributes.
As this code is not actually used by any of the existing
interfaces, it seems unlikely to break anything (famous
last words).
The internal kernel interface to manipulate these attributes
is invoked using two new IO_ flags: IO_NORMAL and IO_EXT.
These flags may be specified in the ioflags word of VOP_READ,
VOP_WRITE, and VOP_TRUNCATE. Specifying IO_NORMAL means that
you want to do I/O to the normal data part of the file and
IO_EXT means that you want to do I/O to the extended attributes
part of the file. IO_NORMAL and IO_EXT are mutually exclusive
for VOP_READ and VOP_WRITE, but may be specified individually
or together in the case of VOP_TRUNCATE. For example, when
removing a file, VOP_TRUNCATE is called with both IO_NORMAL
and IO_EXT set. For backward compatibility, if neither IO_NORMAL
nor IO_EXT is set, then IO_NORMAL is assumed.
Note that the BA_ and IO_ flags have been `merged' so that they
may both be used in the same flags word. This merger is possible
by assigning the IO_ flags to the low sixteen bits and the BA_
flags the high sixteen bits. This works because the high sixteen
bits of the IO_ word is reserved for read-ahead and help with
write clustering so will never be used for flags. This merge
lets us get away from code of the form:
if (ioflags & IO_SYNC)
flags |= BA_SYNC;
For the future, I have considered adding a new field to the
vattr structure, va_extsize. This addition could then be
exported through the stat structure to allow applications to
find out the size of the extended attribute storage and also
would provide a more standard interface for truncating them
(via VOP_SETATTR rather than VOP_TRUNCATE).
I am also contemplating adding a pathconf parameter (for
concreteness, lets call it _PC_MAX_EXTSIZE) which would
let an application determine the maximum size of the extended
atribute storage.
Sponsored by: DARPA & NAI Labs.
Revision 1.97 / (download) - annotate - [select for diffs], Tue Jul 16 22:35:59 2002 UTC (6 years, 11 months ago) by mckusick
Branch: MAIN
Changes since 1.96: +2 -2
lines
Diff to previous 1.96 (colored)
Change the name of st_createtime to st_birthtime. This change is made to reduce confusion between st_ctime and st_createtime. Submitted by: Eric Allman <eric@sendmail.org> Sponsored by: DARPA & NAI Labs.
Revision 1.96 / (download) - annotate - [select for diffs], Mon Jul 8 12:42:29 2002 UTC (6 years, 11 months ago) by bde
Branch: MAIN
Changes since 1.95: +7 -7
lines
Diff to previous 1.95 (colored)
Fixed some printf format errors (4 new ones reported by gcc and 5 nearby old ones not reported by gcc). This helps unbreak LINT.
Revision 1.95 / (download) - annotate - [select for diffs], Sun Jun 23 18:17:26 2002 UTC (7 years ago) by mux
Branch: MAIN
Changes since 1.94: +4 -4
lines
Diff to previous 1.94 (colored)
Warning fixes for 64 bits platforms. This eliminates all the warnings I have had in the FFS code on sparc64. Reviewed by: mckusick
Revision 1.94 / (download) - annotate - [select for diffs], Sat Jun 22 21:24:58 2002 UTC (7 years ago) by mckusick
Branch: MAIN
Changes since 1.93: +2 -2
lines
Diff to previous 1.93 (colored)
This patch fixes a problem whereby filesystems that ran out of inodes in a cylinder group would fail to check for free inodes in other cylinder groups. This bug was introduced in the UFS2 code merge two days ago. An inode is allocated by calling ffs_valloc which calls ffs_hashalloc to do the filesystem scan. Ffs_hashalloc walks around the cylinder groups calling its passed allocator (ffs_nodealloccg in this case) until the allocator returns a non-zero result. The bug is that ffs_hashalloc expects the passed allocator function to return a 64-bit ufs2_daddr_t. When allocating inodes, it calls ffs_nodealloccg which was returning a 32-bit ino_t. The ffs_hashalloc code checked a 64-bit return value and usually found random non-zero bits in the high 32-bits so decided that the allocation had succeeded (in this case in the only cylinder group that it checked). When the result was passed back to ffs_valloc it looked at only the bottom 32-bits, saw zero and declared the system out of inodes. But ffs_hashalloc had really only checked one cylinder group. The fix is to change ffs_nodealloccg to return 64-bit results. Sponsored by: DARPA & NAI Labs. Submitted by: Poul-Henning Kamp <phk@critter.freebsd.dk> Reviewed by: Maxime Henrion <mux@freebsd.org>
Revision 1.93 / (download) - annotate - [select for diffs], Fri Jun 21 06:18:03 2002 UTC (7 years ago) by mckusick
Branch: MAIN
Changes since 1.92: +452 -231
lines
Diff to previous 1.92 (colored)
This commit adds basic support for the UFS2 filesystem. The UFS2 filesystem expands the inode to 256 bytes to make space for 64-bit block pointers. It also adds a file-creation time field, an ability to use jumbo blocks per inode to allow extent like pointer density, and space for extended attributes (up to twice the filesystem block size worth of attributes, e.g., on a 16K filesystem, there is space for 32K of attributes). UFS2 fully supports and runs existing UFS1 filesystems. New filesystems built using newfs can be built in either UFS1 or UFS2 format using the -O option. In this commit UFS1 is the default format, so if you want to build UFS2 format filesystems, you must specify -O 2. This default will be changed to UFS2 when UFS2 proves itself to be stable. In this commit the boot code for reading UFS2 filesystems is not compiled (see /sys/boot/common/ufsread.c) as there is insufficient space in the boot block. Once the size of the boot block is increased, this code can be defined. Things to note: the definition of SBSIZE has changed to SBLOCKSIZE. The header file <ufs/ufs/dinode.h> must be included before <ufs/ffs/fs.h> so as to get the definitions of ufs2_daddr_t and ufs_lbn_t. Still TODO: Verify that the first level bootstraps work for all the architectures. Convert the utility ffsinfo to understand UFS2 and test growfs. Add support for the extended attribute storage. Update soft updates to ensure integrity of extended attribute storage. Switch the current extended attribute interfaces to use the extended attribute storage. Add the extent like functionality (framework is there, but is currently never used). Sponsored by: DARPA & NAI Labs. Reviewed by: Poul-Henning Kamp <phk@freebsd.org>
Revision 1.92 / (download) - annotate - [select for diffs], Thu May 16 21:28:28 2002 UTC (7 years, 1 month ago) by trhodes
Branch: MAIN
Changes since 1.91: +7 -7
lines
Diff to previous 1.91 (colored)
More s/file system/filesystem/g
Revision 1.91 / (download) - annotate - [select for diffs], Mon May 13 09:22:28 2002 UTC (7 years, 1 month ago) by phk
Branch: MAIN
Changes since 1.90: +22 -22
lines
Diff to previous 1.90 (colored)
Remove register keyword. Sponsored by: DARPA & NAI Labs. Submitted by: mckusick
Revision 1.90 / (download) - annotate - [select for diffs], Mon Apr 1 21:31:12 2002 UTC (7 years, 3 months ago) by jhb
Branch: MAIN
Changes since 1.89: +2 -2
lines
Diff to previous 1.89 (colored)
Change the suser() API to take advantage of td_ucred as well as do a general cleanup of the API. The entire API now consists of two functions similar to the pre-KSE API. The suser() function takes a thread pointer as its only argument. The td_ucred member of this thread must be valid so the only valid thread pointers are curthread and a few kernel threads such as thread0. The suser_cred() function takes a pointer to a struct ucred as its first argument and an integer flag as its second argument. The flag is currently only used for the PRISON_ROOT flag. Discussed on: smp@
Revision 1.89 / (download) - annotate - [select for diffs], Tue Mar 19 22:40:46 2002 UTC (7 years, 3 months ago) by alfred
Branch: MAIN
Changes since 1.88: +13 -15
lines
Diff to previous 1.88 (colored)
Remove __P.
Revision 1.88 / (download) - annotate - [select for diffs], Sun Mar 17 01:25:45 2002 UTC (7 years, 3 months ago) by mckusick
Branch: MAIN
Changes since 1.87: +3 -3
lines
Diff to previous 1.87 (colored)
Add a flags parameter to VFS_VGET to pass through the desired locking flags when acquiring a vnode. The immediate purpose is to allow polling lock requests (LK_NOWAIT) needed by soft updates to avoid deadlock when enlisting other processes to help with the background cleanup. For the future it will allow the use of shared locks for read access to vnodes. This change touches a lot of files as it affects most filesystems within the system. It has been well tested on FFS, loopback, and CD-ROM filesystems. only lightly on the others, so if you find a problem there, please let me (mckusick@mckusick.com) know.
Revision 1.87 / (download) - annotate - [select for diffs], Thu Feb 7 22:13:56 2002 UTC (7 years, 4 months ago) by mckusick
Branch: MAIN
Changes since 1.86: +4 -0
lines
Diff to previous 1.86 (colored)
Occationally background fsck would cause a spurious ``freeing free inode'' panic. This change corrects that problem by setting the fs_active flag when the inode map changes to notify the snapshot code that the cylinder group must be rescanned. Submitted by: Robert Watson <rwatson@FreeBSD.org>
Revision 1.86 / (download) - annotate - [select for diffs], Sat Feb 2 01:42:44 2002 UTC (7 years, 5 months ago) by mckusick
Branch: MAIN
Changes since 1.85: +74 -65
lines
Diff to previous 1.85 (colored)
When taking a snapshot, we must check for active files that have been unlinked (e.g., with a zero link count). We have to expunge all trace of these files from the snapshot so that they are neither reclaimed prematurely by fsck nor saved unnecessarily by dump.
Revision 1.85 / (download) - annotate - [select for diffs], Tue Jan 22 06:17:22 2002 UTC (7 years, 5 months ago) by mckusick
Branch: MAIN
Changes since 1.84: +22 -6
lines
Diff to previous 1.84 (colored)
This patch fixes a long standing complaint with soft updates in which small and/or nearly full filesystems would fail with `file system full' messages when trying to replace a number of existing files (for example during a system installation). When the allocation routines are about to fail with a file system full condition, they make a call to softdep_request_cleanup() which attempts to accelerate the flushing of pending deletion requests in an effort to free up space. In the face of filesystem I/O requests that exceed the available disk transfer capacity, the cleanup request could take an unbounded amount of time. Thus, the softdep_request_cleanup() routine will only try for tickdelay seconds (default 2 seconds) before giving up and returning a filesystem full error. Under typical conditions, the softdep_request_cleanup() routine is able to free up space in under fifty milliseconds.
Revision 1.84 / (download) - annotate - [select for diffs], Sun Jan 13 11:58:06 2002 UTC (7 years, 5 months ago) by alfred
Branch: MAIN
Changes since 1.83: +3 -0
lines
Diff to previous 1.83 (colored)
SMP Lock struct file, filedesc and the global file list.
Seigo Tanimura (tanimura) posted the initial delta.
I've polished it quite a bit reducing the need for locking and
adapting it for KSE.
Locks:
1 mutex in each filedesc
protects all the fields.
protects "struct file" initialization, while a struct file
is being changed from &badfileops -> &pipeops or something
the filedesc should be locked.
1 mutex in each struct file
protects the refcount fields.
doesn't protect anything else.
the flags used for garbage collection have been moved to
f_gcflag which was the FILLER short, this doesn't need
locking because the garbage collection is a single threaded
container.
could likely be made to use a pool mutex.
1 sx lock for the global filelist.
struct file * fhold(struct file *fp);
/* increments reference count on a file */
struct file * fhold_locked(struct file *fp);
/* like fhold but expects file to locked */
struct file * ffind_hold(struct thread *, int fd);
/* finds the struct file in thread, adds one reference and
returns it unlocked */
struct file * ffind_lock(struct thread *, int fd);
/* ffind_hold, but returns file locked */
I still have to smp-safe the fget cruft, I'll get to that asap.
Revision 1.83 / (download) - annotate - [select for diffs], Tue Dec 18 18:05:17 2001 UTC (7 years, 6 months ago) by mckusick
Branch: MAIN
Changes since 1.82: +6 -8
lines
Diff to previous 1.82 (colored)
Change the atomic_set_char to atomic_set_int and atomic_clear_char to atomic_clear_int to ease the implementation for the sparc64. Requested by: Jake Burkholder <jake@locore.ca>
Revision 1.82 / (download) - annotate - [select for diffs], Fri Dec 14 00:15:05 2001 UTC (7 years, 6 months ago) by mckusick
Branch: MAIN
Changes since 1.81: +15 -1
lines
Diff to previous 1.81 (colored)
Minimize the time necessary to suspend operations on a filesystem when taking a snapshot. The two time consuming operations are scanning all the filesystem bitmaps to determine which blocks are in use and scanning all the other snapshots so as to be able to expunge their blocks from the view of the current snapshot. The bitmap scanning is broken into two passes. Before suspending the filesystem all bitmaps are scanned. After the suspension, those bitmaps that changed after being scanned the first time are rescanned. Typically there are few bitmaps that need to be rescanned. The expunging of other snapshots is now done after the suspension is released by observing that we can easily identify any blocks that were allocated to them after the suspension (they will be maked as `not needing to be copied' in the just created snapshot). For all the gory details, see the ``Running fsck in the Background'' paper in the Usenix BSDCon 2002 Conference Proceedings, pages 55-64.
Revision 1.81 / (download) - annotate - [select for diffs], Tue Oct 2 14:41:43 2001 UTC (7 years, 9 months ago) by rwatson
Branch: MAIN
Changes since 1.80: +3 -3
lines
Diff to previous 1.80 (colored)
o Replace two direct uid!=0 comparisons with suser_xxx() calls. Obtained from: TrustedBSD Project
Revision 1.64.2.2 / (download) - annotate - [select for diffs], Fri Sep 21 19:15:21 2001 UTC (7 years, 9 months ago) by dillon
Branch: RELENG_4
CVS Tags: RELENG_4_9_BP,
RELENG_4_9_0_RELEASE,
RELENG_4_9,
RELENG_4_8_BP,
RELENG_4_8_0_RELEASE,
RELENG_4_8,
RELENG_4_7_BP,
RELENG_4_7_0_RELEASE,
RELENG_4_7,
RELENG_4_6_BP,
RELENG_4_6_2_RELEASE,
RELENG_4_6_1_RELEASE,
RELENG_4_6_0_RELEASE,
RELENG_4_6,
RELENG_4_5_BP,
RELENG_4_5_0_RELEASE,
RELENG_4_5
Changes since 1.64.2.1: +113 -18
lines
Diff to previous 1.64.2.1 (colored) to branchpoint 1.64 (colored)
MFC dirpref code, including patches that deal with old fsck's clearing dirpref fields in the superblock and alternative superblock errors reported due to the fields added to the superblock. Additionally, MFCd the space reservation and fsck/superblock support in the superblock for snapshots so the -stable fsck remains compatible with the -current fsck. The following has been MFC'd: 1.36 src/sbin/newfs/mkfs.c 1.35 src/sbin/newfs/newfs.c 1.16 src/sbin/tunefs/tunefs.c 1.75 src/sys/ufs/ffs/ffs_alloc.c 1.144, 1.148, 1.159 src/sys/ufs/ffs/ffs_vfsops.c 1.20 src/sys/ufs/ffs/fs.h 1.37 src/sbin/newfs/newfs.8 1.15 src/sbin/tunefs/tunefs.8 1.22, 1.25 src/sbin/fsck_ffs/setup.c (note: fsck/setup.c in -stable) Reviewed by: iedowse, silby, mckusick
Revision 1.80 / (download) - annotate - [select for diffs], Fri Jun 15 07:44:39 2001 UTC (8 years ago) by peter
Branch: MAIN
CVS Tags: KSE_PRE_MILESTONE_2,
KSE_MILESTONE_2
Changes since 1.79: +2 -2
lines
Diff to previous 1.79 (colored)
Fix warning: 1973: warning: int format, long int arg (arg 5)
Revision 1.79 / (download) - annotate - [select for diffs], Fri May 4 05:49:28 2001 UTC (8 years, 2 months ago) by mckusick
Branch: MAIN
Changes since 1.78: +2 -4
lines
Diff to previous 1.78 (colored)
Refinement to revision 1.16 of ufs/ffs/ffs_snapshot.c to reduce the amount of time that the filesystem must be suspended. The current snapshot is elided as well as the earlier snapshots.
Revision 1.78 / (download) - annotate - [select for diffs], Sun Apr 29 02:45:12 2001 UTC (8 years, 2 months ago) by grog
Branch: MAIN
Changes since 1.77: +1 -3
lines
Diff to previous 1.77 (colored)
Revert consequences of changes to mount.h, part 2. Requested by: bde
Revision 1.77 / (download) - annotate - [select for diffs], Mon Apr 23 08:58:55 2001 UTC (8 years, 2 months ago) by grog
Branch: MAIN
Changes since 1.76: +3 -1
lines
Diff to previous 1.76 (colored)
Correct #includes to work with fixed sys/mount.h.
Revision 1.76 / (download) - annotate - [select for diffs], Tue Apr 17 05:06:37 2001 UTC (8 years, 2 months ago) by mckusick
Branch: MAIN
Changes since 1.75: +15 -9
lines
Diff to previous 1.75 (colored)
Background fsck sysctl operations must use vn_start_write and vn_finished_write so that they do not attempt to modify a suspended filesystem.
Revision 1.75 / (download) - annotate - [select for diffs], Tue Apr 10 08:38:59 2001 UTC (8 years, 2 months ago) by mckusick
Branch: MAIN
Changes since 1.74: +113 -18
lines
Diff to previous 1.74 (colored)
Directory layout preference improvements from Grigoriy Orlov <gluk@ptci.ru>.
His description of the problem and solution follow. My own tests show
speedups on typical filesystem intensive workloads of 5% to 12% which
is very impressive considering the small amount of code change involved.
------
One day I noticed that some file operations run much faster on
small file systems then on big ones. I've looked at the ffs
algorithms, thought about them, and redesigned the dirpref algorithm.
First I want to describe the results of my tests. These results are old
and I have improved the algorithm after these tests were done. Nevertheless
they show how big the perfomance speedup may be. I have done two file/directory
intensive tests on a two OpenBSD systems with old and new dirpref algorithm.
The first test is "tar -xzf ports.tar.gz", the second is "rm -rf ports".
The ports.tar.gz file is the ports collection from the OpenBSD 2.8 release.
It contains 6596 directories and 13868 files. The test systems are:
1. Celeron-450, 128Mb, two IDE drives, the system at wd0, file system for
test is at wd1. Size of test file system is 8 Gb, number of cg=991,
size of cg is 8m, block size = 8k, fragment size = 1k OpenBSD-current
from Dec 2000 with BUFCACHEPERCENT=35
2. PIII-600, 128Mb, two IBM DTLA-307045 IDE drives at i815e, the system
at wd0, file system for test is at wd1. Size of test file system is 40 Gb,
number of cg=5324, size of cg is 8m, block size = 8k, fragment size = 1k
OpenBSD-current from Dec 2000 with BUFCACHEPERCENT=50
You can get more info about the test systems and methods at:
http://www.ptci.ru/gluk/dirpref/old/dirpref.html
Test Results
tar -xzf ports.tar.gz rm -rf ports
mode old dirpref new dirpref speedup old dirprefnew dirpref speedup
First system
normal 667 472 1.41 477 331 1.44
async 285 144 1.98 130 14 9.29
sync 768 616 1.25 477 334 1.43
softdep 413 252 1.64 241 38 6.34
Second system
normal 329 81 4.06 263.5 93.5 2.81
async 302 25.7 11.75 112 2.26 49.56
sync 281 57.0 4.93 263 90.5 2.9
softdep 341 40.6 8.4 284 4.76 59.66
"old dirpref" and "new dirpref" columns give a test time in seconds.
speedup - speed increasement in times, ie. old dirpref / new dirpref.
------
Algorithm description
The old dirpref algorithm is described in comments:
/*
* Find a cylinder to place a directory.
*
* The policy implemented by this algorithm is to select from
* among those cylinder groups with above the average number of
* free inodes, the one with the smallest number of directories.
*/
A new directory is allocated in a different cylinder groups than its
parent directory resulting in a directory tree that is spreaded across
all the cylinder groups. This spreading out results in a non-optimal
access to the directories and files. When we have a small filesystem
it is not a problem but when the filesystem is big then perfomance
degradation becomes very apparent.
What I mean by a big file system ?
1. A big filesystem is a filesystem which occupy 20-30 or more percent
of total drive space, i.e. first and last cylinder are physically
located relatively far from each other.
2. It has a relatively large number of cylinder groups, for example
more cylinder groups than 50% of the buffers in the buffer cache.
The first results in long access times, while the second results in
many buffers being used by metadata operations. Such operations use
cylinder group blocks and on-disk inode blocks. The cylinder group
block (fs->fs_cblkno) contains struct cg, inode and block bit maps.
It is 2k in size for the default filesystem parameters. If new and
parent directories are located in different cylinder groups then the
system performs more input/output operations and uses more buffers.
On filesystems with many cylinder groups, lots of cache buffers are
used for metadata operations.
My solution for this problem is very simple. I allocate many directories
in one cylinder group. I also do some things, so that the new allocation
method does not cause excessive fragmentation and all directory inodes
will not be located at a location far from its file's inodes and data.
The algorithm is:
/*
* Find a cylinder group to place a directory.
*
* The policy implemented by this algorithm is to allocate a
* directory inode in the same cylinder group as its parent
* directory, but also to reserve space for its files inodes
* and data. Restrict the number of directories which may be
* allocated one after another in the same cylinder group
* without intervening allocation of files.
*
* If we allocate a first level directory then force allocation
* in another cylinder group.
*/
My early versions of dirpref give me a good results for a wide range of
file operations and different filesystem capacities except one case:
those applications that create their entire directory structure first
and only later fill this structure with files.
My solution for such and similar cases is to limit a number of
directories which may be created one after another in the same cylinder
group without intervening file creations. For this purpose, I allocate
an array of counters at mount time. This array is linked to the superblock
fs->fs_contigdirs[cg]. Each time a directory is created the counter
increases and each time a file is created the counter decreases. A 60Gb
filesystem with 8mb/cg requires 10kb of memory for the counters array.
The maxcontigdirs is a maximum number of directories which may be created
without an intervening file creation. I found in my tests that the best
performance occurs when I restrict the number of directories in one cylinder
group such that all its files may be located in the same cylinder group.
There may be some deterioration in performance if all the file inodes
are in the same cylinder group as its containing directory, but their
data partially resides in a different cylinder group. The maxcontigdirs
value is calculated to try to prevent this condition. Since there is
no way to know how many files and directories will be allocated later
I added two optimization parameters in superblock/tunefs. They are:
int32_t fs_avgfilesize; /* expected average file size */
int32_t fs_avgfpdir; /* expected # of files per directory */
These parameters have reasonable defaults but may be tweeked for special
uses of a filesystem. They are only necessary in rare cases like better
tuning a filesystem being used to store a squid cache.
I have been using this algorithm for about 3 months. I have done
a lot of testing on filesystems with different capacities, average
filesize, average number of files per directory, and so on. I think
this algorithm has no negative impact on filesystem perfomance. It
works better than the default one in all cases. The new dirpref
will greatly improve untarring/removing/coping of big directories,
decrease load on cvs servers and much more. The new dirpref doesn't
speedup a compilation process, but also doesn't slow it down.
Obtained from: Grigoriy Orlov <gluk@ptci.ru>
Revision 1.74 / (download) - annotate - [select for diffs], Sat Mar 24 15:25:04 2001 UTC (8 years, 3 months ago) by asmodai
Branch: MAIN
Changes since 1.73: +2 -2
lines
Diff to previous 1.73 (colored)
Fix typo ); -> ,
Revision 1.73 / (download) - annotate - [select for diffs], Fri Mar 23 20:58:25 2001 UTC (8 years, 3 months ago) by mckusick
Branch: MAIN
Changes since 1.72: +3 -1
lines
Diff to previous 1.72 (colored)
Check that background fsck operation is being done on a ufs filesystem. Obtained from: Robert Watson <rwatson@FreeBSD.org>
Revision 1.72 / (download) - annotate - [select for diffs], Wed Mar 21 04:08:54 2001 UTC (8 years, 3 months ago) by mckusick
Branch: MAIN
Changes since 1.71: +220 -15
lines
Diff to previous 1.71 (colored)
Add kernel support for running fsck on active filesystems.
Revision 1.71 / (download) - annotate - [select for diffs], Wed Mar 21 04:01:02 2001 UTC (8 years, 3 months ago) by mckusick
Branch: MAIN
Changes since 1.70: +15 -15
lines
Diff to previous 1.70 (colored)
Report the correct inode number when panicing with freeing free inode. Report the correct block number when panicing with freeing free block.
Revision 1.70 / (download) - annotate - [select for diffs], Sun Feb 18 10:43:24 2001 UTC (8 years, 4 months ago) by asmodai
Branch: MAIN
Changes since 1.69: +2 -2
lines
Diff to previous 1.69 (colored)
Preceed/preceeding are not english words. Use precede and preceding.
Revision 1.69 / (download) - annotate - [select for diffs], Fri Jul 28 22:27:00 2000 UTC (8 years, 11 months ago) by peter
Branch: MAIN
CVS Tags: PRE_SMPNG
Changes since 1.68: +3 -1
lines
Diff to previous 1.68 (colored)
Minor change: fix warning - move a 'struct vnode *vp' declaration inside a #ifdef DIAGNOSTIC to match its corresponding usage.
Revision 1.68 / (download) - annotate - [select for diffs], Tue Jul 11 22:07:54 2000 UTC (8 years, 11 months ago) by mckusick
Branch: MAIN
Changes since 1.67: +17 -2
lines
Diff to previous 1.67 (colored)
Add snapshots to the fast filesystem. Most of the changes support the gating of system calls that cause modifications to the underlying filesystem. The gating can be enabled by any filesystem that needs to consistently suspend operations by adding the vop_stdgetwritemount to their set of vnops. Once gating is enabled, the function vfs_write_suspend stops all new write operations to a filesystem, allows any filesystem modifying system calls already in progress to complete, then sync's the filesystem to disk and returns. The function vfs_write_resume allows the suspended write operations to begin again. Gating is not added by default for all filesystems as for SMP systems it adds two extra locks to such critical kernel paths as the write system call. Thus, gating should only be added as needed. Details on the use and current status of snapshots in FFS can be found in /sys/ufs/ffs/README.snapshot so for brevity and timelyness is not included here. Unless and until you create a snapshot file, these changes should have no effect on your system (famous last words).
Revision 1.67 / (download) - annotate - [select for diffs], Fri May 5 09:59:01 2000 UTC (9 years, 2 months ago) by phk
Branch: MAIN
Changes since 1.66: +2 -1
lines
Diff to previous 1.66 (colored)
Separate the struct bio related stuff out of <sys/buf.h> into <sys/bio.h>. <sys/bio.h> is now a prerequisite for <sys/buf.h> but it shall not be made a nested include according to bdes teachings on the subject of nested includes. Diskdrivers and similar stuff below specfs::strategy() should no longer need to include <sys/buf.> unless they need caching of data. Still a few bogus uses of struct buf to track down. Repocopy by: peter
Revision 1.66 / (download) - annotate - [select for diffs], Sat Apr 15 03:34:15 2000 UTC (9 years, 2 months ago) by rwatson
Branch: MAIN
Changes since 1.65: +2 -1
lines
Diff to previous 1.65 (colored)
Introduce extended attribute support for FFS, allowing arbitrary
(name, value) pairs to be associated with inodes. This support is
used for ACLs, MAC labels, and Capabilities in the TrustedBSD
security extensions, which are currently under development.
In this implementation, attributes are backed to data vnodes in the
style of the quota support in FFS. Support for FFS extended
attributes may be enabled using the FFS_EXTATTR kernel option
(disabled by default). Userland utilities and man pages will be
committed in the next batch. VFS interfaces and man pages have
been in the repo since 4.0-RELEASE and are unchanged.
o ufs/ufs/extattr.h: UFS-specific extattr defines
o ufs/ufs/ufs_extattr.c: bulk of support routines
o ufs/{ufs,ffs,mfs}/*.[ch]: hooks and extattr.h includes
o contrib/softupdates/ffs_softdep.c: extattr.h includes
o conf/options, conf/files, i386/conf/LINT: added FFS_EXTATTR
o coda/coda_vfsops.c: XXX required extattr.h due to ufsmount.h
(This should not be the case, and will be fixed in a future commit)
Currently attributes are not supported in MFS. This will be fixed.
Reviewed by: adrian, bp, freebsd-fs, other unthanked souls
Obtained from: TrustedBSD Project
Revision 1.64.2.1 / (download) - annotate - [select for diffs], Thu Mar 16 08:15:53 2000 UTC (9 years, 3 months ago) by ps
Branch: RELENG_4
CVS Tags: RELENG_4_4_BP,
RELENG_4_4_0_RELEASE,
RELENG_4_4,
RELENG_4_3_BP,
RELENG_4_3_0_RELEASE,
RELENG_4_3,
RELENG_4_2_0_RELEASE,
RELENG_4_1_1_RELEASE,
RELENG_4_1_0_RELEASE
Changes since 1.64: +49 -31
lines
Diff to previous 1.64 (colored)
MFC: 1.65 Use 64-bit math to decide if optimization needs to be changed. Kirk also made structural changes, which he did not mention in the previous commit. Merge those as well.
Revision 1.65 / (download) - annotate - [select for diffs], Wed Mar 15 07:08:36 2000 UTC (9 years, 3 months ago) by mckusick
Branch: MAIN
Changes since 1.64: +49 -31
lines
Diff to previous 1.64 (colored)
Use 64-bit math to decide if optimization needs to be changed. Necessary for coherent results on filesystems bigger than 0.5Tb. Submitted by: Paul Saab <ps@yahoo-inc.com>
Revision 1.64 / (download) - annotate - [select for diffs], Mon Jan 10 00:24:22 2000 UTC (9 years, 5 months ago) by mckusick
Branch: MAIN
CVS Tags: RELENG_4_BP,
RELENG_4_0_0_RELEASE
Branch point for: RELENG_4
Changes since 1.63: +8 -1
lines
Diff to previous 1.63 (colored)
Several performance improvements for soft updates have been added: 1) Fastpath deletions. When a file is being deleted, check to see if it was so recently created that its inode has not yet been written to disk. If so, the delete can proceed to immediately free the inode. 2) Background writes: No file or block allocations can be done while the bitmap is being written to disk. To avoid these stalls, the bitmap is copied to another buffer which is written thus leaving the original available for futher allocations. 3) Link count tracking. Constantly track the difference in i_effnlink and i_nlink so that inodes that have had no change other than i_effnlink need not be written. 4) Identify buffers with rollback dependencies so that the buffer flushing daemon can choose to skip over them.
Revision 1.63 / (download) - annotate - [select for diffs], Tue Dec 21 11:14:12 1999 UTC (9 years, 6 months ago) by eivind
Branch: MAIN
Changes since 1.62: +2 -2
lines
Diff to previous 1.62 (colored)
Change incorrect NULLs to 0s
Revision 1.62 / (download) - annotate - [select for diffs], Wed Dec 1 19:33:12 1999 UTC (9 years, 7 months ago) by mckusick
Branch: MAIN
Changes since 1.61: +2 -2
lines
Diff to previous 1.61 (colored)
Preferentially allocate the first indirect block in the same cylinder group as the inode. This makes a 15% difference in read speed for files in the 96K to 500K size range.
Revision 1.14.4.2 / (download) - annotate - [select for diffs], Sun Sep 5 08:38:28 1999 UTC (9 years, 10 months ago) by peter
Branch: RELENG_2_1_0
Changes since 1.14.4.1: +1 -1
lines
Diff to previous 1.14.4.1 (colored) to branchpoint 1.14 (colored) next main 1.15 (colored)
$Id$ -> $FreeBSD$
Revision 1.26.2.2 / (download) - annotate - [select for diffs], Sun Sep 5 08:23:31 1999 UTC (9 years, 10 months ago) by peter
Branch: RELENG_2_2
Changes since 1.26.2.1: +1 -1
lines
Diff to previous 1.26.2.1 (colored) to branchpoint 1.26 (colored) next main 1.27 (colored)
$Id$ -> $FreeBSD$
Revision 1.56.2.2 / (download) - annotate - [select for diffs], Mon Aug 30 12:30:11 1999 UTC (9 years, 10 months ago) by sheldonh
Branch: RELENG_3
CVS Tags: RELENG_3_5_0_RELEASE,
RELENG_3_4_0_RELEASE,
RELENG_3_3_0_RELEASE
Changes since 1.56.2.1: +4 -2
lines
Diff to previous 1.56.2.1 (colored) to branchpoint 1.56 (colored) next main 1.57 (colored)
MFC 1.60: Fix for the case where DEBUG is used without DIAGNOSTIC.
Revision 1.56.2.1 / (download) - annotate - [select for diffs], Sun Aug 29 16:33:08 1999 UTC (9 years, 10 months ago) by peter
Branch: RELENG_3
Changes since 1.56: +1 -1
lines
Diff to previous 1.56 (colored)
$Id$ -> $FreeBSD$
Revision 1.61 / (download) - annotate - [select for diffs], Sat Aug 28 00:52:20 1999 UTC (9 years, 10 months ago) by peter
Branch: MAIN
Changes since 1.60: +1 -1
lines
Diff to previous 1.60 (colored)
$Id$ -> $FreeBSD$
Revision 1.60 / (download) - annotate - [select for diffs], Tue Aug 24 08:39:41 1999 UTC (9 years, 10 months ago) by sheldonh
Branch: MAIN
Changes since 1.59: +4 -2
lines
Diff to previous 1.59 (colored)
Fix bug introduced in rev 1.28, which causes kernel build to break for the case where DEBUG is defined but not DIAGNOSTIC. ffs_checkblk is declared conditionally on DIAGNOSTIC, not DEBUG. PR: 13314 Reviewed by: bde
Revision 1.59 / (download) - annotate - [select for diffs], Mon Aug 23 20:35:19 1999 UTC (9 years, 10 months ago) by bde
Branch: MAIN
Changes since 1.58: +20 -17
lines
Diff to previous 1.58 (colored)
Use devtoname() to print dev_t's instead of casting them to long or u_long for misprinting in %lx format.
Revision 1.58 / (download) - annotate - [select for diffs], Wed May 12 22:32:07 1999 UTC (10 years, 1 month ago) by peter
Branch: MAIN
Changes since 1.57: +3 -3
lines
Diff to previous 1.57 (colored)
Try and fix a dev_t/major/minor etc nit.
Revision 1.57 / (download) - annotate - [select for diffs], Thu May 6 18:13:11 1999 UTC (10 years, 2 months ago) by peter
Branch: MAIN
Changes since 1.56: +3 -2
lines
Diff to previous 1.56 (colored)
Add sufficient braces to keep egcs happy about potentially ambiguous if/else nesting.
Revision 1.56 / (download) - annotate - [select for diffs], Thu Jan 7 16:14:16 1999 UTC (10 years, 5 months ago) by bde
Branch: MAIN
CVS Tags: RELENG_3_BP,
RELENG_3_2_PAO_BP,
RELENG_3_2_PAO,
RELENG_3_2_0_RELEASE,
RELENG_3_1_0_RELEASE,
PRE_VFS_BIO_NFS_PATCH,
PRE_SMP_VMSHARE,
PRE_NEWBUS,
POST_VFS_BIO_NFS_PATCH,
POST_SMP_VMSHARE,
POST_NEWBUS
Branch point for: RELENG_3
Changes since 1.55: +3 -6
lines
Diff to previous 1.55 (colored)
Don't pass unused unused timestamp args to UFS_UPDATE() or waste time initializing them. This almost finishes centralizing (in-core) timestamp updates in ufs_itimes().
Revision 1.55 / (download) - annotate - [select for diffs], Wed Jan 6 17:04:33 1999 UTC (10 years, 5 months ago) by bde
Branch: MAIN
Changes since 1.54: +4 -2
lines
Diff to previous 1.54 (colored)
Ifdefed the conditionally used variable `prtrealloc'. Declare it as volatile so that there is no chance that the code that it controls is optimised away.
Revision 1.54 / (download) - annotate - [select for diffs], Fri Nov 13 01:01:44 1998 UTC (10 years, 7 months ago) by dg
Branch: MAIN
Changes since 1.53: +4 -14
lines
Diff to previous 1.53 (colored)
Restored the "reallocblks" code to its former glory. What this does is basically do a on-the-fly defragmentation of the FFS filesystem, changing file block allocations to make them contiguous. Thanks to Kirk McKusick for providing hints on what needed to be done to get this working.
Revision 1.53 / (download) - annotate - [select for diffs], Mon Sep 7 11:50:18 1998 UTC (10 years, 9 months ago) by bde
Branch: MAIN
CVS Tags: RELENG_3_0_0_RELEASE
Changes since 1.52: +3 -1
lines
Diff to previous 1.52 (colored)
Put the zombie ffs sysctl node in "notyet" state together with its few remaining children. Prepare it for MOUNT_UFS going away.
Revision 1.52 / (download) - annotate - [select for diffs], Sat Sep 5 14:13:12 1998 UTC (10 years, 10 months ago) by phk
Branch: MAIN
Changes since 1.51: +2 -1
lines
Diff to previous 1.51 (colored)
Add a new vnode op, VOP_FREEBLKS(), which filesystems can use to inform device drivers about sectors no longer in use. Device-drivers receive the call through d_strategy, if they have D_CANFREE in d_flags. This allows flash based devices to erase the sectors and avoid pointlessly carrying them around in compactions. Reviewed by: Kirk Mckusick, bde Sponsored by: M-Systems (www.m-sys.com)
Revision 1.51 / (download) - annotate - [select for diffs], Mon Aug 17 19:09:36 1998 UTC (10 years, 10 months ago) by bde
Branch: MAIN
Changes since 1.50: +3 -2
lines
Diff to previous 1.50 (colored)
Removed unused includes.
Revision 1.50 / (download) - annotate - [select for diffs], Sat Jul 11 07:46:04 1998 UTC (10 years, 11 months ago) by bde
Branch: MAIN
Changes since 1.49: +21 -19
lines
Diff to previous 1.49 (colored)
Fixed printf format errors.
Revision 1.49 / (download) - annotate - [select for diffs], Mon Mar 30 09:55:50 1998 UTC (11 years, 3 months ago) by phk
Branch: MAIN
CVS Tags: PRE_NOBDEV,
PRE_DEVFS_SLICE,
POST_DEVFS_SLICE
Changes since 1.48: +6 -6
lines
Diff to previous 1.48 (colored)
Eradicate the variable "time" from the kernel, using various measures. "time" wasn't a atomic variable, so splfoo() protection were needed around any access to it, unless you just wanted the seconds part. Most uses of time.tv_sec now uses the new variable time_second instead. gettime() changed to getmicrotime(0. Remove a couple of unneeded splfoo() protections, the new getmicrotime() is atomic, (until Bruce sets a breakpoint in it). A couple of places needed random data, so use read_random() instead of mucking about with time which isn't random. Add a new nfs_curusec() function. Mark a couple of bogosities involving the now disappeard time variable. Update ffs_update() to avoid the weird "== &time" checks, by fixing the one remaining call that passwd &time as args. Change profiling in ncr.c to use ticks instead of time. Resolution is the same. Add new function "tvtohz()" to avoid the bogus "splfoo(), add time, call hzto() which subtracts time" sequences. Reviewed by: bde
Revision 1.48 / (download) - annotate - [select for diffs], Sun Mar 8 09:58:42 1998 UTC (11 years, 3 months ago) by julian
Branch: MAIN
CVS Tags: POST_SOFTUPDATE
Changes since 1.47: +70 -23
lines
Diff to previous 1.47 (colored)
Reviewed by: dyson@freebsd.org (john Dyson), dg@root.com (david greenman) Submitted by: Kirk McKusick (mcKusick@mckusick.com) Obtained from: WHistle development tree
Revision 1.47 / (download) - annotate - [select for diffs], Fri Feb 6 12:14:13 1998 UTC (11 years, 4 months ago) by eivind
Branch: MAIN
CVS Tags: PRE_SOFTUPDATE
Changes since 1.46: +1 -2
lines
Diff to previous 1.46 (colored)
Back out DIAGNOSTIC changes.
Revision 1.46 / (download) - annotate - [select for diffs], Wed Feb 4 22:33:27 1998 UTC (11 years, 5 months ago) by eivind
Branch: MAIN
Changes since 1.45: +2 -1
lines
Diff to previous 1.45 (colored)
Turn DIAGNOSTIC into a new-style option.
Revision 1.45 / (download) - annotate - [select for diffs], Tue Dec 2 11:21:16 1997 UTC (11 years, 7 months ago) by bde
Branch: MAIN
Changes since 1.44: +2 -2
lines
Diff to previous 1.44 (colored)
Fix a small style bug in the generation number change (rev.1.33) before copying the change to other fs's.
Revision 1.44 / (download) - annotate - [select for diffs], Sat Nov 22 08:35:45 1997 UTC (11 years, 7 months ago) by bde
Branch: MAIN
Changes since 1.43: +6 -3
lines
Diff to previous 1.43 (colored)
Staticized.
Revision 1.43 / (download) - annotate - [select for diffs], Sat Nov 22 07:00:40 1997 UTC (11 years, 7 months ago) by bde
Branch: MAIN
Changes since 1.42: +9 -1
lines
Diff to previous 1.42 (colored)
Unremoved prtrealloc and the declaration of ffs_clusteralloc(). These are used in the `#ifdef notyet' case :-). This case is used except in the `#if !defined (not_yes)' case :-|. This has something to do with the `#ifdef notyet_block_reallocation_enabled' case in vfs_cluster.c :-(.
Revision 1.42 / (download) - annotate - [select for diffs], Fri Nov 7 08:53:34 1997 UTC (11 years, 7 months ago) by phk
Branch: MAIN
Changes since 1.41: +1 -5
lines
Diff to previous 1.41 (colored)
Remove a bunch of variables which were unused both in GENERIC and LINT. Found by: -Wunused
Revision 1.41 / (download) - annotate - [select for diffs], Thu Oct 16 20:32:33 1997 UTC (11 years, 8 months ago) by phk
Branch: MAIN
Changes since 1.40: +2 -2
lines
Diff to previous 1.40 (colored)
Another VFS cleanup "kilo commit"
1. Remove VOP_UPDATE, it is (also) an UFS/{FFS,LFS,EXT2FS,MFS}
intereface function, and now lives in the ufsmount structure.
2. Remove VOP_SEEK, it was unused.
3. Add mode default vops:
VOP_ADVLOCK vop_einval
VOP_CLOSE vop_null
VOP_FSYNC vop_null
VOP_IOCTL vop_enotty
VOP_MMAP vop_einval
VOP_OPEN vop_null
VOP_PATHCONF vop_einval
VOP_READLINK vop_einval
VOP_REALLOCBLKS vop_eopnotsupp
And remove identical functionality from filesystems
4. Add vop_stdpathconf, which returns the canonical stuff. Use
it in the filesystems. (XXX: It's probably wrong that specfs
and fifofs sets this vop, shouldn't it come from the "host"
filesystem, for instance ufs or cd9660 ?)
5. Try to make system wide VOP functions have vop_* names.
6. Initialize the um_* vectors in LFS.
(Recompile your LKMS!!!)
Revision 1.40 / (download) - annotate - [select for diffs], Thu Oct 16 10:49:19 1997 UTC (11 years, 8 months ago) by phk
Branch: MAIN
Changes since 1.39: +18 -24
lines
Diff to previous 1.39 (colored)
VFS mega cleanup commit (x/N)
1. Add new file "sys/kern/vfs_default.c" where default actions for
VOPs go. Implement proper defaults for ABORTOP, BWRITE, LEASE,
POLL, REVOKE and STRATEGY. Various stuff spread over the entire
tree belongs here.
2. Change VOP_BLKATOFF to a normal function in cd9660.
3. Kill VOP_BLKATOFF, VOP_TRUNCATE, VOP_VFREE, VOP_VALLOC. These
are private interface functions between UFS and the underlying
storage manager layer (FFS/LFS/MFS/EXT2FS). The functions now
live in struct ufsmount instead.
4. Remove a kludge of VOP_ functions in all filesystems, that did
nothing but obscure the simplicity and break the expandability.
If a filesystem doesn't implement VOP_FOO, it shouldn't have an
entry for it in its vnops table. The system will try to DTRT
if it is not implemented. There are still some cruft left, but
the bulk of it is done.
5. Fix another VCALL in vfs_cache.c (thanks Bruce!)
Revision 1.39 / (download) - annotate - [select for diffs], Tue Oct 14 18:46:41 1997 UTC (11 years, 8 months ago) by phk
Branch: MAIN
Changes since 1.38: +1 -4
lines
Diff to previous 1.38 (colored)
I think my previous change may have opened a race conditio. This patch does the same thing, with no change in semantics.
Revision 1.38 / (download) - annotate - [select for diffs], Tue Oct 14 14:22:23 1997 UTC (11 years, 8 months ago) by phk
Branch: MAIN
Changes since 1.37: +4 -1
lines
Diff to previous 1.37 (colored)
ufs_ihashrem() should not be called from the UFS layer, but from the lower layer (LFS/FFS/?) like the rest of the ihash functions. Otherwise it is impossible to make a lower layer that doesn't use the ihash facility.
Revision 1.37 / (download) - annotate - [select for diffs], Fri Sep 19 11:13:16 1997 UTC (11 years, 9 months ago) by phk
Branch: MAIN
Changes since 1.36: +5 -3
lines
Diff to previous 1.36 (colored)
[Regarding the previous patch] This is completely wrong. 1. ffs_alloc() actually allowed writing one block less one frag (normally 7 frags or 7/8 blocks) beyond the limit. 2. freebufspace() gives the free space in frags, but `size' is in bytes, so the change results in approximately `size' fragments too many being reserved. 3. ffs_realloccg() has the same bug but wasn't changed. PR: 3398 Submitted by: bde Eyeballed by: phk
Revision 1.36 / (download) - annotate - [select for diffs], Thu Sep 18 18:07:45 1997 UTC (11 years, 9 months ago) by phk
Branch: MAIN
Changes since 1.35: +2 -2
lines
Diff to previous 1.35 (colored)
Ffs_alloc allow users to write one block beyond the limit. PR: 3398 Reviewed by: phk Submitted by: Wolfram Schneider <wosch@apfel.de>
Revision 1.35 / (download) - annotate - [select for diffs], Tue Sep 2 20:06:44 1997 UTC (11 years, 10 months ago) by bde
Branch: MAIN
Changes since 1.34: +1 -4
lines
Diff to previous 1.34 (colored)
Removed unused #includes.
Revision 1.34 / (download) - annotate - [select for diffs], Mon Aug 4 07:30:43 1997 UTC (11 years, 11 months ago) by phk
Branch: MAIN
Changes since 1.33: +2 -2
lines
Diff to previous 1.33 (colored)
We got a couple of "map mismatch" panics from the following code. According to the crash dump, bpref is set to 445 and cgp->cg_nclusterblks is 444. Hence in the for loop, the test fails immediately but the following failure check (got == cgp->cg_nclusterblks) doesn't trigger because got > cgp->cg_nclusterblks. This wreaks havoc in the code after that. Fix: Move one source bit to the left :-) Noticed by: Mike Hibler <mike@fast.cs.utah.edu> Submitted by: Kirk McKusick <mckusick@McKusick.COM>
Revision 1.14.4.1 / (download) - annotate - [select for diffs], Wed Mar 26 20:29:10 1997 UTC (12 years, 3 months ago) by guido
Branch: RELENG_2_1_0
Changes since 1.14: +3 -6
lines
Diff to previous 1.14 (colored)
Get in the fsirand stuff.
Revision 1.26.2.1 / (download) - annotate - [select for diffs], Wed Mar 26 20:05:50 1997 UTC (12 years, 3 months ago) by guido
Branch: RELENG_2_2
CVS Tags: RELENG_2_2_8_RELEASE,
RELENG_2_2_7_RELEASE,
RELENG_2_2_6_RELEASE,
RELENG_2_2_5_RELEASE,
RELENG_2_2_2_RELEASE
Changes since 1.26: +3 -6
lines
Diff to previous 1.26 (colored)
Backport of the fsirand stuff to 2.2. I'm sorry this is too late for 2.2.1
Revision 1.33 / (download) - annotate - [select for diffs], Sun Mar 23 20:08:16 1997 UTC (12 years, 3 months ago) by guido
Branch: MAIN
CVS Tags: pre_smp_merge,
post_smp_merge,
WOLLMAN_MBUF,
BP_WOLLMAN_MBUF
Changes since 1.32: +3 -6
lines
Diff to previous 1.32 (colored)
Add generation number randomization. Newly created filesystems wil now automatically have random generation numbers. The kenel way of handling those also changed. Further it is advised to run fsirand on all your nfs exported filesystems. the code is mostly copied from OpenBSD, with the randomization chanegd to use /dev/urandom Reviewed by: Garrett Obtained from: OpenBSD
Revision 1.32 / (download) - annotate - [select for diffs], Sat Mar 22 06:53:28 1997 UTC (12 years, 3 months ago) by bde
Branch: MAIN
Changes since 1.31: +2 -2
lines
Diff to previous 1.31 (colored)
Fixed some invalid (non-atomic) accesses to `time', mostly ones of the form `tv = time'. Use a new function gettime(). The current version just forces atomicicity without fixing precision or efficiency bugs. Simplified some related valid accesses by using the central function.
Revision 1.31 / (download) - annotate - [select for diffs], Sun Mar 9 06:00:40 1997 UTC (12 years, 3 months ago) by mpp
Branch: MAIN
Changes since 1.30: +7 -7
lines
Diff to previous 1.30 (colored)
Update a number of panic messages to reflect the actual name of the routine that caused the panic.
Revision 1.30 / (download) - annotate - [select for diffs], Sat Feb 22 09:47:00 1997 UTC (12 years, 4 months ago) by peter
Branch: MAIN
Changes since 1.29: +1 -1
lines
Diff to previous 1.29 (colored)
Back out part 1 of the MCFH that changed $Id$ to $FreeBSD$. We are not ready for it yet.
Revision 1.29 / (download) - annotate - [select for diffs], Mon Feb 10 17:05:30 1997 UTC (12 years, 4 months ago) by mpp
Branch: MAIN
Changes since 1.28: +8 -11
lines
Diff to previous 1.28 (colored)
Correct the new Lite2 #ifdef DIAGNOSTIC ffs_checkblk routine to not return without setting a return value when it can't read a block error or detects a bad cylinder group, since the caller is expecting a return value. It will now panic at this point, since the thing to do in this case would be to return a "bad block" status to the caller, and the caller will panic anyways when that happens. Also updated to panic strings in this routine to read "ffs_checkblk: ..." instead of "checkblk: ...".
Revision 1.28 / (download) - annotate - [select for diffs], Mon Feb 10 02:20:18 1997 UTC (12 years, 4 months ago) by dyson
Branch: MAIN
Changes since 1.27: +185 -59
lines
Diff to previous 1.27 (colored)
This is the kernel Lite/2 commit. There are some requisite userland changes, so don't expect to be able to run the kernel as-is (very well) without the appropriate Lite/2 userland changes. The system boots and can mount UFS filesystems. Untested: ext2fs, msdosfs, NFS Known problems: Incorrect Berkeley ID strings in some files. Mount_std mounts will not work until the getfsent library routine is changed. Reviewed by: various people Submitted by: Jeffery Hsu <hsu@freebsd.org>
Revision 1.27 / (download) - annotate - [select for diffs], Tue Jan 14 06:56:36 1997 UTC (12 years, 5 months ago) by jkh
Branch: MAIN
Changes since 1.26: +1 -1
lines
Diff to previous 1.26 (colored)
Make the long-awaited change from $Id$ to $FreeBSD$ This will make a number of things easier in the future, as well as (finally!) avoiding the Id-smashing problem which has plagued developers for so long. Boy, I'm glad we're not using sup anymore. This update would have been insane otherwise.
Revision 1.26 / (download) - annotate - [select for diffs], Tue Sep 17 14:38:16 1996 UTC (12 years, 9 months ago) by peter
Branch: MAIN
CVS Tags: RELENG_2_2_BP,
RELENG_2_2_1_RELEASE,
RELENG_2_2_0_RELEASE
Branch point for: RELENG_2_2
Changes since 1.25: +4 -2
lines
Diff to previous 1.25 (colored)
Argh, I have had one "uid 0 on /: file system full" too many. The problem is that it doesn't say _what_ did it! (the core dumped console message is very useful for listing the process name and pid). This adds similar information.
Revision 1.25 / (download) - annotate - [select for diffs], Fri Jul 12 04:12:14 1996 UTC (12 years, 11 months ago) by bde
Branch: MAIN
Changes since 1.24: +16 -16
lines
Diff to previous 1.24 (colored)
Don't use NULL in non-pointer contexts.
Revision 1.24 / (download) - annotate - [select for diffs], Wed May 8 04:29:07 1996 UTC (13 years, 1 month ago) by gpalmer
Branch: MAIN
Changes since 1.23: +2 -2
lines
Diff to previous 1.23 (colored)
Clean up various compiler warnings. Most (if not all) were benign Reviewed by: bde
Revision 1.1.1.2 / (download) - annotate - [select for diffs] (vendor branch), Mon Mar 11 19:46:41 1996 UTC (13 years, 3 months ago) by peter
Branch: CSRG
CVS Tags: bsd_44_lite_2
Changes since 1.1.1.1: +187 -65
lines
Diff to previous 1.1.1.1 (colored)
Import 4.4BSD-Lite2 onto the vendor branch, note that in the kernel, all files are off the vendor branch, so this should not change anything. A "U" marker generally means that the file was not changed in between the 4.4Lite and Lite-2 releases, and does not need a merge. "C" generally means that there was a change.
Revision 1.23 / (download) - annotate - [select for diffs], Fri Jan 5 18:31:45 1996 UTC (13 years, 6 months ago) by wollman
Branch: MAIN
CVS Tags: wollman_polling
Changes since 1.22: +3 -1
lines
Diff to previous 1.22 (colored)
Convert QUOTA to new-style option.
Revision 1.22 / (download) - annotate - [select for diffs], Sun Dec 17 21:09:29 1995 UTC (13 years, 6 months ago) by phk
Branch: MAIN
Changes since 1.21: +11 -9
lines
Diff to previous 1.21 (colored)
Staticize.
Revision 1.21 / (download) - annotate - [select for diffs], Fri Dec 15 03:36:25 1995 UTC (13 years, 6 months ago) by peter
Branch: MAIN
Changes since 1.20: +3 -2
lines
Diff to previous 1.20 (colored)
Silence a harmless warning...
Revision 1.20 / (download) - annotate - [select for diffs], Sun Dec 3 11:16:21 1995 UTC (13 years, 7 months ago) by bde
Branch: MAIN
Changes since 1.19: +12 -11
lines
Diff to previous 1.19 (colored)
Completed function declarations and/or added prototypes and/or #includes to get the prototypes.
Revision 1.19 / (download) - annotate - [select for diffs], Sun Nov 19 19:55:26 1995 UTC (13 years, 7 months ago) by dyson
Branch: MAIN
Changes since 1.18: +5 -1
lines
Diff to previous 1.18 (colored)
General fixes to the vfs clustring code: 1) Make cluster buffer list be a non-malloced chain. This eliminates yet another 'evil' M_WAITOK and generally cleans up the code. 2) Fix write clustering for ext2fs. It was just broken. Also, ffs clustering had an efficiency problem that more bawrites were happening than should have been. 3) Make changes to buf.h to support the above, plus remove b_pfcent at the request of David Greenman. Note that the reallocblocks code is disabled pending rewrite for the cluster buffer list changes.
Revision 1.18 / (download) - annotate - [select for diffs], Tue Nov 14 09:40:04 1995 UTC (13 years, 7 months ago) by phk
Branch: MAIN
Changes since 1.17: +2 -2
lines
Diff to previous 1.17 (colored)
Get rid of the last debug sysctl variables of the old style.
Revision 1.17 / (download) - annotate - [select for diffs], Fri Sep 8 17:16:32 1995 UTC (13 years, 9 months ago) by davidg
Branch: MAIN
Changes since 1.16: +11 -11
lines
Diff to previous 1.16 (colored)
Slight optimization for the standard case of rotdelay=0.
Revision 1.16 / (download) - annotate - [select for diffs], Fri Aug 25 19:40:26 1995 UTC (13 years, 10 months ago) by bde
Branch: MAIN
Changes since 1.15: +6 -3
lines
Diff to previous 1.15 (colored)
Don't call VOP_UPDATE() with volatile timestamps.
Revision 1.15 / (download) - annotate - [select for diffs], Mon Aug 7 08:16:32 1995 UTC (13 years, 11 months ago) by davidg
Branch: MAIN
Changes since 1.14: +2 -2
lines
Diff to previous 1.14 (colored)
Use bdwrite() rather than brelse(). The cylinder group bitmap modification is not preserved otherwise. Note that this is a no-op in FreeBSD, however, as we have doreallocblks disabled. Submitted by: Kirk McKusick
Revision 1.14 / (download) - annotate - [select for diffs], Tue May 30 08:14:57 1995 UTC (14 years, 1 month ago) by rgrimes
Branch: MAIN
CVS Tags: RELENG_2_1_7_RELEASE,
RELENG_2_1_6_RELEASE,
RELENG_2_1_6_1_RELEASE,
RELENG_2_1_5_RELEASE,
RELENG_2_1_0_RELEASE,
RELENG_2_1_0_BP,
RELENG_2_0_5_RELEASE,
RELENG_2_0_5_BP,
RELENG_2_0_5
Branch point for: RELENG_2_1_0
Changes since 1.13: +19 -19
lines
Diff to previous 1.13 (colored)
Remove trailing whitespace.
Revision 1.13 / (download) - annotate - [select for diffs], Thu May 11 19:26:48 1995 UTC (14 years, 1 month ago) by rgrimes
Branch: MAIN
CVS Tags: RELENG_2_0_5_ALPHA
Changes since 1.12: +5 -3
lines
Diff to previous 1.12 (colored)
Fix -Wformat warnings from LINT kernel.
Revision 1.12 / (download) - annotate - [select for diffs], Sun Mar 26 23:29:09 1995 UTC (14 years, 3 months ago) by davidg
Branch: MAIN
Changes since 1.11: +3 -3
lines
Diff to previous 1.11 (colored)
Removed third arg (vmio) to allocbuf() that was added with the original merged cache changes, and figure it out based on the B_VMIO buffer flag. Fixes a problem where delayed write VMIO buffers would sometimes get recopied into kernel-alloced memory. Submitted by: John Dyson
Revision 1.11 / (download) - annotate - [select for diffs], Sun Mar 19 14:29:11 1995 UTC (14 years, 3 months ago) by davidg
Branch: MAIN
Changes since 1.10: +4 -4
lines
Diff to previous 1.10 (colored)
Removed redundant newlines that were in some panic strings.
Revision 1.10 / (download) - annotate - [select for diffs], Fri Mar 10 22:11:50 1995 UTC (14 years, 3 months ago) by davidg
Branch: MAIN
Changes since 1.9: +2 -2
lines
Diff to previous 1.9 (colored)
The threshold for switching from time-space and space-time is too small when minfree is 5%...so make it stay at space in this case. Submitted by: Kirk McKusick
Revision 1.9 / (download) - annotate - [select for diffs], Fri Mar 3 22:13:15 1995 UTC (14 years, 4 months ago) by davidg
Branch: MAIN
Changes since 1.8: +8 -2
lines
Diff to previous 1.8 (colored)
Fixes from John Dyson to work around vnode lock hang. Basically, remove the VOP_BMAP calls, and add one to bdwrite. Submitted by: John Dyson
Revision 1.8 / (download) - annotate - [select for diffs], Mon Feb 27 17:43:57 1995 UTC (14 years, 4 months ago) by se
Branch: MAIN
Changes since 1.7: +8 -8
lines
Diff to previous 1.7 (colored)
Don't try to make use of useless rotational position optimisation, if all free blocks are in the same bucket (i.e. NRPOS == 1). Else a free block is choosen, possibly from a different cylinder, even if the block succeeding bpref was free ... Submitted by: se
Revision 1.7 / (download) - annotate - [select for diffs], Tue Feb 14 06:14:28 1995 UTC (14 years, 4 months ago) by phk
Branch: MAIN
Changes since 1.6: +16 -11
lines
Diff to previous 1.6 (colored)
YF fix.
Revision 1.6 / (download) - annotate - [select for diffs], Mon Jan 9 16:05:17 1995 UTC (14 years, 5 months ago) by davidg
Branch: MAIN
Changes since 1.5: +4 -4
lines
Diff to previous 1.5 (colored)
These changes embody the support of the fully coherent merged VM buffer cache, much higher filesystem I/O performance, and much better paging performance. It represents the culmination of over 6 months of R&D. The majority of the merged VM/cache work is by John Dyson. The following highlights the most significant changes. Additionally, there are (mostly minor) changes to the various filesystem modules (nfs, msdosfs, etc) to support the new VM/buffer scheme. vfs_bio.c: Significant rewrite of most of vfs_bio to support the merged VM buffer cache scheme. The scheme is almost fully compatible with the old filesystem interface. Significant improvement in the number of opportunities for write clustering. vfs_cluster.c, vfs_subr.c Upgrade and performance enhancements in vfs layer code to support merged VM/buffer cache. Fixup of vfs_cluster to eliminate the bogus pagemove stuff. vm_object.c: Yet more improvements in the collapse code. Elimination of some windows that can cause list corruption. vm_pageout.c: Fixed it, it really works better now. Somehow in 2.0, some "enhancements" broke the code. This code has been reworked from the ground-up. vm_fault.c, vm_page.c, pmap.c, vm_object.c Support for small-block filesystems with merged VM/buffer cache scheme. pmap.c vm_map.c Dynamic kernel VM size, now we dont have to pre-allocate excessive numbers of kernel PTs. vm_glue.c Much simpler and more effective swapping code. No more gratuitous swapping. proc.h Fixed the problem that the p_lock flag was not being cleared on a fork. swap_pager.c, vnode_pager.c Removal of old vfs_bio cruft to support the past pseudo-coherency. Now the code doesn't need it anymore. machdep.c Changes to better support the parameter values for the merged VM/buffer cache scheme. machdep.c, kern_exec.c, vm_glue.c Implemented a seperate submap for temporary exec string space and another one to contain process upages. This eliminates all map fragmentation problems that previously existed. ffs_inode.c, ufs_inode.c, ufs_readwrite.c Changes for merged VM/buffer cache. Add "bypass" support for sneaking in on busy buffers. Submitted by: John Dyson and David Greenman
Revision 1.5 / (download) - annotate - [select for diffs], Mon Oct 10 01:04:34 1994 UTC (14 years, 8 months ago) by phk
Branch: MAIN
CVS Tags: RELEASE_2_0,
OLAH_TTCP,
BETA_2_0,
ALPHA_2_0
Changes since 1.4: +23 -19
lines
Diff to previous 1.4 (colored)
Cosmetics. make gcc less noisy. Still some way to go here.
Revision 1.4 / (download) - annotate - [select for diffs], Tue Sep 20 05:53:24 1994 UTC (14 years, 9 months ago) by bde
Branch: MAIN
Changes since 1.3: +2 -2
lines
Diff to previous 1.3 (colored)
Use `1' for a boolean value instead of something irrelevant (MNT_WAIT) that happens to be nonzero.
Revision 1.3 / (download) - annotate - [select for diffs], Tue Aug 2 07:54:17 1994 UTC (14 years, 11 months ago) by davidg
Branch: MAIN
Changes since 1.2: +1 -0
lines
Diff to previous 1.2 (colored)
Added $Id$
Revision 1.2 / (download) - annotate - [select for diffs], Wed May 25 09:15:36 1994 UTC (15 years, 1 month ago) by rgrimes
Branch: MAIN
Changes since 1.1: +10 -1
lines
Diff to previous 1.1 (colored)
The big 4.4BSD Lite to FreeBSD 2.0.0 (Development) patch. Reviewed by: Rodney W. Grimes Submitted by: John Dyson and David Greenman
Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Tue May 24 10:09:22 1994 UTC (15 years, 1 month ago) by rgrimes
Branch: CSRG
CVS Tags: bsd_44_lite,
REL_before_johndavid_2_0_0
Changes since 1.1: +0 -0
lines
Diff to previous 1.1 (colored)
BSD 4.4 Lite Kernel Sources
Revision 1.1 / (download) - annotate - [select for diffs], Tue May 24 10:09:21 1994 UTC (15 years, 1 month ago) by rgrimes
Branch: MAIN
Initial revision