![[BACK]](/icons/back.gif){kind=icon}
Up to [freebsd] / src / sys / pci
Up to [freebsd] / src / sys / pci
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.160.2.18 / (download) - annotate - [select for diffs], Mon Dec 15 21:39:31 2008 UTC (3 years, 1 month ago) by marius
Branch: RELENG_6
Changes since 1.160.2.17: +42 -34
lines
Diff to previous 1.160.2.17 (colored) to branchpoint 1.160 (colored) next main 1.161 (colored)
SVN rev 186139 on 2008-12-15 21:39:31Z by marius - According to the corresponding Linux, NetBSD and OpenSolaris drivers, there should be a 1us delay after every write when bit-banging the MII. Also insert barriers in order to ensure the intended ordering. These changes hopefully will solve the bus wedging occasionally experienced with DM9102A since r182461. - Deobfuscate dc_mii_readreg() a bit.
Revision 1.160.2.16.2.2 / (download) - annotate - [select for diffs], Mon Nov 24 21:26:26 2008 UTC (3 years, 2 months ago) by marius
Branch: RELENG_6_4
CVS Tags: RELENG_6_4_0_RELEASE
Changes since 1.160.2.16.2.1: +2 -6
lines
Diff to previous 1.160.2.16.2.1 (colored) to branchpoint 1.160.2.16 (colored) next main 1.160.2.17 (colored)
SVN rev 185264 on 2008-11-24 21:26:26Z by marius MF stable/6: r185263 Revert r182461 except for the introduction of the DC_HAS_BROKEN_RXSTATE() macro for the upcoming release as doing MII-operations on DM9102A while the link is up has turned out to occasionally cause panics. This again prevents the link state form ever being checked once it's up, which is considered less worse than the panics though. Approved by: re (kensmith)
Revision 1.160.2.17 / (download) - annotate - [select for diffs], Mon Nov 24 21:18:40 2008 UTC (3 years, 2 months ago) by marius
Branch: RELENG_6
Changes since 1.160.2.16: +2 -6
lines
Diff to previous 1.160.2.16 (colored) to branchpoint 1.160 (colored)
SVN rev 185263 on 2008-11-24 21:18:40Z by marius Revert r182461 except for the introduction of the DC_HAS_BROKEN_RXSTATE() macro for the upcoming release as doing MII-operations on DM9102A while the link is up has turned out to occasionally cause panics. This again prevents the link state form ever being checked once it's up, which is considered less worse than the panics tough. Approved by: re (kensmith)
Revision 1.160.2.16.2.1 / (download) - annotate - [select for diffs], Thu Oct 2 02:57:24 2008 UTC (3 years, 4 months ago) by kensmith
Branch: RELENG_6_4
Changes since 1.160.2.16: +0 -0
lines
Diff to previous 1.160.2.16 (colored)
SVN rev 183531 on 2008-10-02 02:57:24Z by kensmith Create releng/6.4 from stable/6 in preparation for 6.4-RC1. Approved by: re (implicit)
Revision 1.160.2.16 / (download) - annotate - [select for diffs], Mon Sep 1 00:46:14 2008 UTC (3 years, 5 months ago) by marius
Branch: RELENG_6
CVS Tags: RELENG_6_4_BP
Branch point for: RELENG_6_4
Changes since 1.160.2.15: +7 -5
lines
Diff to previous 1.160.2.15 (colored) to branchpoint 1.160 (colored)
SVN rev 182583 on 2008-09-01 00:46:14Z by marius MFC: r182461 For chips with a broken DC_ISR_RX_STATE which f.e. never signals stopped nor the waiting state and also no other means to check whether the receiver is idle (see also r163774), we have no choice than to call mii_tick(9) unconditionally even in the case of the DC_REDUCED_MII_POLL handling as far as the RX side is concerned. This isn't necessarily worse than checking whether RX is idle though because unlike as with TX we're racing with the hardware, which might receive packets any time while we poll the MII, anyway. Reported and tested by: Jacob Owens Reviewed by: yongari
Revision 1.160.2.15 / (download) - annotate - [select for diffs], Thu Jun 19 03:37:40 2008 UTC (3 years, 7 months ago) by yongari
Branch: RELENG_6
Changes since 1.160.2.14: +15 -5
lines
Diff to previous 1.160.2.14 (colored) to branchpoint 1.160 (colored)
SVN rev 179867 on 2008-06-19 03:37:40Z by yongari MFC: r179647 Ethernet hardware address stored in DC_AL_PAR0/DC_AL_PAR1 register is in little endian form. Likewise setting DC_AL_PAR0/DC_AL_PAR1 register expect the address to be in little endian form. For big endian architectures the address should be swapped to get correct one. Change setting/getting ethernet hardware address to big endian architecture frendly. Reported by: Robert Murillo ( billypilgrim782001 at yahoo dot com ) Tested by: Robert Murillo ( billypilgrim782001 at yahoo dot com )
Revision 1.160.2.14 / (download) - annotate - [select for diffs], Fri Apr 11 23:41:43 2008 UTC (3 years, 10 months ago) by marius
Branch: RELENG_6
Changes since 1.160.2.13: +87 -84
lines
Diff to previous 1.160.2.13 (colored) to branchpoint 1.160 (colored)
MFC: if_dc.c 1.195, 1.194; if_dcreg.h 1.55 - Fix function prototype for device_shutdown method. - Const'ify the dc_devs array. - Correct the maxsize parameter when creating the mbufs busdma tag to reflect the actual requirement of dc(4). - Move the KASSERT in dc_newbuf() to the right spot. - Also convert the TX side to take advantage of bus_dmamap_load_mbuf_sg(9). - Move the comment regarding dc_start_locked() to the right spot.
Revision 1.160.2.13 / (download) - annotate - [select for diffs], Sat Sep 15 10:00:51 2007 UTC (4 years, 4 months ago) by marius
Branch: RELENG_6
CVS Tags: RELENG_6_3_BP,
RELENG_6_3_0_RELEASE,
RELENG_6_3
Changes since 1.160.2.12: +71 -94
lines
Diff to previous 1.160.2.12 (colored) to branchpoint 1.160 (colored)
MFC: if_dc.c 1.166 1.171, 1.189 (partial), 1.190, 1.192; if_dcreg.h 1.54 - In detach method, move if_free() after bus_teardown_intr(). - Use our own callout (the dc_tick() callout uses varying periods depending on the NIC and isn't used at all with HomePNA links) instead of if_slowtimo() for driving dc_watchdog() in order to avoid races accessing if_timer. - Use bus_get_dma_tag() so dc(4) works on platforms requiring it. - Don't bother to set if_mtu to ETHERMTU, ether_ifattach() does that. - Fix a bug originally introduced in rev. 1.74; don't reloaded the watchdog timer in dc_txeof() in case there are still unhandled descriptors as dc_poll() invokes dc_poll() unconditionally. Otherwise this would result in the watchdog timer constantly being being reloaded and thus circumvent that the watchdog ever fires in the DEVICE_POLLING case.
Revision 1.160.2.12 / (download) - annotate - [select for diffs], Mon Nov 13 17:24:24 2006 UTC (5 years, 2 months ago) by marius
Branch: RELENG_6
CVS Tags: RELENG_6_2_BP,
RELENG_6_2_0_RELEASE,
RELENG_6_2
Changes since 1.160.2.11: +28 -16
lines
Diff to previous 1.160.2.11 (colored) to branchpoint 1.160 (colored)
MFC: sys/dev/dc/if_dc.c 1.185, 1.186 (partial); sys/dev/dc/if_dcreg.h 1.52 - Consistently use if_printf() only in interface methods: if_start(), if_watchdog, etc., or in functions used only in these methods. In all other functions in the driver use device_printf(). - Use __func__ instead of typing function name. - Wrap code optimized for architectures without alignment constraints in #ifdef __NO_STRICT_ALIGNMENT rather than #ifdef __i386__. This means that amd64 now also uses the optimized code. While at it, fix a nearby style(9) bug. - In dc_setcfg() suppress printing a warning when forcing the receiver and transceiver to idle state times out for chips where the status bits in question just never change (observed in detail with DM9102A) and therefore the warning would be highly likely false positive. - In dc_ifmedia_sts() add a missing DC_UNLOCK(). Approved by: re (kensmith)
Revision 1.160.2.11 / (download) - annotate - [select for diffs], Wed Jun 21 21:06:07 2006 UTC (5 years, 7 months ago) by jhb
Branch: RELENG_6
Changes since 1.160.2.10: +6 -0
lines
Diff to previous 1.160.2.10 (colored) to branchpoint 1.160 (colored)
MFC: Add two device IDs for Linksys PCMPC200 cards.
Revision 1.160.2.10 / (download) - annotate - [select for diffs], Wed Jun 21 21:03:24 2006 UTC (5 years, 7 months ago) by jhb
Branch: RELENG_6
Changes since 1.160.2.9: +88 -121
lines
Diff to previous 1.160.2.9 (colored) to branchpoint 1.160 (colored)
MFC various cleanups: - Switch on the full 32-bit device ID to avoid collisions between the vendor-specific device ids across vendors. - Include the revision in the dc_devs[] array instead of special casing the revid handling in dc_devtype(). - Use PCI bus accessors to read registers instead of pci_read_config() where possible. - Use an 8-bit write to update the latency timer. - Use PCIR_xxx constants and remove unused DC_xxx related to standard PCI config registers.
Revision 1.160.2.9 / (download) - annotate - [select for diffs], Tue Mar 21 21:10:58 2006 UTC (5 years, 10 months ago) by jhb
Branch: RELENG_6
CVS Tags: RELENG_6_1_BP,
RELENG_6_1_0_RELEASE,
RELENG_6_1
Changes since 1.160.2.8: +3 -0
lines
Diff to previous 1.160.2.8 (colored) to branchpoint 1.160 (colored)
MFC: Add device ID for the Neteasy DRP-32TXD cardbus 10/100 card. Approved by: re (hrs)
Revision 1.160.2.8 / (download) - annotate - [select for diffs], Fri Mar 17 21:30:56 2006 UTC (5 years, 10 months ago) by glebius
Branch: RELENG_6
Changes since 1.160.2.7: +0 -1
lines
Diff to previous 1.160.2.7 (colored) to branchpoint 1.160 (colored)
MFC: Do not touch ifp->if_baudrate in miibus aware drivers. Approved by: re (scottl)
Revision 1.148.2.8 / (download) - annotate - [select for diffs], Sun Jan 29 15:39:08 2006 UTC (6 years ago) by emaste
Branch: RELENG_5
CVS Tags: RELENG_5_5_BP,
RELENG_5_5_0_RELEASE,
RELENG_5_5
Changes since 1.148.2.7: +8 -0
lines
Diff to previous 1.148.2.7 (colored) to branchpoint 1.148 (colored) next main 1.149 (colored)
Merge IP multicast address list locking from HEAD to RELENG_5. if_ath.c:1.99 awi.c:1.39 if_bfe.c:1.26 if_bge.c:1.92 if_ed.c:1.255 if_em.c:1.67 if_ex.c:1.57 if_fe.c:1.92 if_fxp.c:1.242 if_gem.c:1.32 if_hme.c:1.38 if_ie.c:1.103 if_ndis.c:1.100 if_ixgb.c:1.12 if_lge.c:1.40 if_lnc.c:1.112 if_my.c:1.30 if_nge.c:1.76 if_nve.c:1.9 if_owi.c:1.11 pdq_ifsubr.c:1.27 if_ray.c:1.80 if_re.c:1.47 if_sn.c:1.47 dp83932.c:1.20 if_tx.c:1.90 if_txp.c:1.32 if_aue.c:1.91 if_axe.c:1.31 if_cue.c:1.58 if_kue.c:1.65 if_rue.c:1.22 if_udav.c:1.15 if_vge.c:1.15 if_wi.c:1.182 if_wl.c:1.67 if_xe.c:1.58 if_dc.c:1.161 if_de.c:1.167 if_pcn.c:1.70 if_rl.c:1.153 if_sf.c:1.83 if_sis.c:1.134 if_sk.c:1.107 if_ste.c:1.85 if_ti.c:1.108 if_tl.c:1.100 if_vr.c:1.105 if_wb.c:1.80 if_xl.c:1.193: Modify device drivers supporting multicast addresses to lock if_addr_mtx over iteration of their multicast address lists when synchronizing the hardware address filter with the network stack-maintained list. Note that with these changes, these drivers now depend on locking the global if_addr_mtx, so binary modules of these drivers will not work on 5.4 or earlier releases. Approved by: rwatson (mentor)
Revision 1.160.2.7 / (download) - annotate - [select for diffs], Tue Jan 10 10:24:05 2006 UTC (6 years, 1 month ago) by glebius
Branch: RELENG_6
Changes since 1.160.2.6: +3 -2
lines
Diff to previous 1.160.2.6 (colored) to branchpoint 1.160 (colored)
MFC: Check for IFF_DRV_RUNNING in the interrupt loop. Reported & tested by: Martin P. Hansen <mph lima.dyndns.dk>
Revision 1.172, Tue Oct 18 06:10:03 2005 UTC (6 years, 3 months ago) by imp
Branch: MAIN
CVS Tags: HEAD
Changes since 1.171: +1 -1
lines
FILE REMOVED
Remove dc after repo copy.
Revision 1.171 / (download) - annotate - [select for diffs], Thu Oct 13 21:11:20 2005 UTC (6 years, 3 months ago) by ru
Branch: MAIN
Changes since 1.170: +3 -2
lines
Diff to previous 1.170 (colored)
In detach method, move if_free() after bus_teardown_intr().
Revision 1.160.2.6 / (download) - annotate - [select for diffs], Sun Oct 9 04:11:19 2005 UTC (6 years, 4 months ago) by delphij
Branch: RELENG_6
CVS Tags: RELENG_6_0_BP,
RELENG_6_0_0_RELEASE,
RELENG_6_0
Changes since 1.160.2.5: +2 -2
lines
Diff to previous 1.160.2.5 (colored) to branchpoint 1.160 (colored)
MFC (by ru) | Fix "struct ifnet" leaks when attach() fails in the middle, e.g. | when mii_phy_probe() or bus_setup_intr() fails. For drivers that | call their detach() in this case, call if_free() there to cover | this case too. | | Revision Changes Path | 1.168 +2 -2 src/sys/pci/if_dc.c | 1.75 +2 -2 src/sys/pci/if_pcn.c | 1.156 +3 -5 src/sys/pci/if_rl.c (already merged) | 1.87 +2 -2 src/sys/pci/if_sf.c | 1.136 +2 -3 src/sys/pci/if_sis.c | 1.110 +2 -3 src/sys/pci/if_sk.c | 1.89 +2 -2 src/sys/pci/if_ste.c | 1.110 +2 -2 src/sys/pci/if_ti.c | 1.103 +2 -2 src/sys/pci/if_tl.c | 1.107 +2 -2 src/sys/pci/if_vr.c | 1.83 +2 -2 src/sys/pci/if_wb.c | 1.196 +2 -2 src/sys/pci/if_xl.c Approved by: re (scottl)
Revision 1.160.2.5 / (download) - annotate - [select for diffs], Fri Oct 7 14:00:06 2005 UTC (6 years, 4 months ago) by glebius
Branch: RELENG_6
Changes since 1.160.2.4: +45 -28
lines
Diff to previous 1.160.2.4 (colored) to branchpoint 1.160 (colored)
Big overall MFC of polling(4) cleanup: o First attempt on removing Giant from polling. Details: http://lists.freebsd.org/pipermail/cvs-src/2005-September/051848.html o Second attempt, and big polling cleanup including: - Functinal approach to turning polling on/off - Deprecating of poll_in_trap - Removal of ifnet knowledge from kern_poll.c Details: http://lists.freebsd.org/pipermail/cvs-src/2005-October/053267.html o Improved checking of user configurable sysctls. Details: http://lists.freebsd.org/pipermail/cvs-src/2005-October/053351.html o Moving DEVICE_POLLING from opt_global.h to opt_device_polling.h: http://lists.freebsd.org/pipermail/cvs-src/2005-October/053479.html o All related documentation fixes. Approved by: re (kensmith) Thanks to: everyone, who helped with testing
Revision 1.170 / (download) - annotate - [select for diffs], Wed Oct 5 10:09:16 2005 UTC (6 years, 4 months ago) by glebius
Branch: MAIN
Changes since 1.169: +4 -0
lines
Diff to previous 1.169 (colored)
- Don't pollute opt_global.h with DEVICE_POLLING and introduce opt_device_polling.h - Include opt_device_polling.h into appropriate files. - Embrace with HAVE_KERNEL_OPTION_HEADERS the include in the files that can be compiled as loadable modules. Reviewed by: bde
Revision 1.169 / (download) - annotate - [select for diffs], Sat Oct 1 18:56:18 2005 UTC (6 years, 4 months ago) by glebius
Branch: MAIN
Changes since 1.168: +41 -28
lines
Diff to previous 1.168 (colored)
Big polling(4) cleanup.
o Axe poll in trap.
o Axe IFF_POLLING flag from if_flags.
o Rework revision 1.21 (Giant removal), in such a way that
poll_mtx is not dropped during call to polling handler.
This fixes problem with idle polling.
o Make registration and deregistration from polling in a
functional way, insted of next tick/interrupt.
o Obsolete kern.polling.enable. Polling is turned on/off
with ifconfig.
Detailed kern_poll.c changes:
- Remove polling handler flags, introduced in 1.21. The are not
needed now.
- Forget and do not check if_flags, if_capenable and if_drv_flags.
- Call all registered polling handlers unconditionally.
- Do not drop poll_mtx, when entering polling handlers.
- In ether_poll() NET_LOCK_GIANT prior to locking poll_mtx.
- In netisr_poll() axe the block, where polling code asks drivers
to unregister.
- In netisr_poll() and ether_poll() do polling always, if any
handlers are present.
- In ether_poll_[de]register() remove a lot of error hiding code. Assert
that arguments are correct, instead.
- In ether_poll_[de]register() use standard return values in case of
error or success.
- Introduce poll_switch() that is a sysctl handler for kern.polling.enable.
poll_switch() goes through interface list and enabled/disables polling.
A message that kern.polling.enable is deprecated is printed.
Detailed driver changes:
- On attach driver announces IFCAP_POLLING in if_capabilities, but
not in if_capenable.
- On detach driver calls ether_poll_deregister() if polling is enabled.
- In polling handler driver obtains its lock and checks IFF_DRV_RUNNING
flag. If there is no, then unlocks and returns.
- In ioctl handler driver checks for IFCAP_POLLING flag requested to
be set or cleared. Driver first calls ether_poll_[de]register(), then
obtains driver lock and [dis/en]ables interrupts.
- In interrupt handler driver checks IFCAP_POLLING flag in if_capenable.
If present, then returns.This is important to protect from spurious
interrupts.
Reviewed by: ru, sam, jhb
Revision 1.160.2.4 / (download) - annotate - [select for diffs], Thu Sep 22 12:46:01 2005 UTC (6 years, 4 months ago) by keramida
Branch: RELENG_6
Changes since 1.160.2.3: +11 -5
lines
Diff to previous 1.160.2.3 (colored) to branchpoint 1.160 (colored)
MFC 1.167: panic on attach failure... % When bus_alloc_resource_any() fails, dc_detach() is called and it % attempts to deallocate busdma tags and resources that haven't been % allocated yet, causing a panic every time a dc interface fails to % attach. Fix by checking that we really have something to dealloc % before calling bus_dma*() functions. % % Approved by: jhb % MFC after: 1 week Approved by: re (kensmith)
Revision 1.168 / (download) - annotate - [select for diffs], Fri Sep 16 11:11:51 2005 UTC (6 years, 4 months ago) by ru
Branch: MAIN
Changes since 1.167: +2 -2
lines
Diff to previous 1.167 (colored)
Fix "struct ifnet" leaks when attach() fails in the middle, e.g. when mii_phy_probe() or bus_setup_intr() fails. For drivers that call their detach() in this case, call if_free() there to cover this case too.
Revision 1.167 / (download) - annotate - [select for diffs], Thu Sep 15 17:51:39 2005 UTC (6 years, 4 months ago) by keramida
Branch: MAIN
Changes since 1.166: +11 -5
lines
Diff to previous 1.166 (colored)
When bus_alloc_resource_any() fails, dc_detach() is called and it attempts to deallocate busdma tags and resources that haven't been allocated yet, causing a panic every time a dc interface fails to attach. Fix by checking that we really have something to dealloc before calling bus_dma*() functions. Approved by: jhb MFC after: 1 week
Revision 1.166 / (download) - annotate - [select for diffs], Mon Aug 29 18:45:21 2005 UTC (6 years, 5 months ago) by imp
Branch: MAIN
Changes since 1.165: +4 -1
lines
Diff to previous 1.165 (colored)
Better comment
Revision 1.165 / (download) - annotate - [select for diffs], Mon Aug 29 17:03:31 2005 UTC (6 years, 5 months ago) by imp
Branch: MAIN
Changes since 1.164: +1 -1
lines
Diff to previous 1.164 (colored)
Fix another instance of old info re: miibus
Revision 1.160.2.3 / (download) - annotate - [select for diffs], Fri Aug 26 14:52:36 2005 UTC (6 years, 5 months ago) by jhb
Branch: RELENG_6
Changes since 1.160.2.2: +108 -105
lines
Diff to previous 1.160.2.2 (colored) to branchpoint 1.160 (colored)
MFC: Fix up locking and mark MPSAFE. Approved by: re (scottl)
Revision 1.160.2.2 / (download) - annotate - [select for diffs], Thu Aug 25 05:01:23 2005 UTC (6 years, 5 months ago) by rwatson
Branch: RELENG_6
Changes since 1.160.2.1: +13 -12
lines
Diff to previous 1.160.2.1 (colored) to branchpoint 1.160 (colored)
Merge linux_ioctl.c:1.128 svr4_sockio.c:1.17 altq_cbq.c:1.3 if_oltr.c:1.38 if_pflog.c:1.14 if_pfsync.c:1.21 if_an.c:1.70 if_ar.c:1.72 if_arl.c:1.11 amrr.c:1.10 onoe.c:1.10 if_ath.c:1.101 awi.c:1.41 if_bfe.c:1.27 if_bge.c:1.93 if_cm_isa.c:1.7 smc90cx6.c:1.16 if_cnw.c:1.20 if_cp.c:1.25 if_cs.c:1.42 if_ct.c:1.26 if_cx.c:1.46 if_ed.c:1.256 if_em.c:1.68 if_en_pci.c:1.37 midway.c:1.66 if_ep.c:1.143 if_ex.c:1.58 if_fatm.c:1.20 if_fe.c:1.93 if_fwe.c:1.38 if_fwip.c:1.8 if_fxp.c:1.244 if_gem.c:1.33 if_hatm.c:1.25 if_hatm_intr.c:1.20 if_hatm_ioctl.c:1.13 if_hatm_rx.c:1.10 if_hatm_tx.c:1.14 if_hme.c:1.39 if_ie.c:1.104 if_ndis.c:1.101 if_ic.c:1.24 if_ipw.c:1.10 if_iwi.c:1.10 if_ixgb.c:1.13 if_lge.c:1.41 if_lnc.c:1.113 if_my.c:1.31 if_nge.c:1.77 if_nve.c:1.10 if_owi.c:1.12 if_patm.c:1.9 if_patm_intr.c:1.6 if_patm_ioctl.c:1.10 if_patm_tx.c:1.10 pdq_ifsubr.c:1.28 if_plip.c:1.38 if_ral.c:1.12 if_ral_pci.c:1.2 if_ray.c:1.81 if_rayvar.h:1.22 if_re.c:1.49 if_sbni.c:1.21 if_sbsh.c:1.14 if_sn.c:1.48 dp83932.c:1.21 if_snc_pccard.c:1.9 if_sr.c:1.70 if_tx.c:1.91 if_txp.c:1.33 if_aue.c:1.92 if_axe.c:1.32 if_cdce.c:1.8 if_cue.c:1.59 if_kue.c:1.66 if_rue.c:1.23 if_udav.c:1.16 if_ural.c:1.12 if_vge.c:1.16 if_vx.c:1.58 if_wi.c:1.185 if_wi_pci.c:1.26 if_wl.c:1.68 if_xe.c:1.60 if_xe_pccard.c:1.30 if_el.c:1.68 i4b_ipr.c:1.35 i4b_isppp.c:1.31 kern_poll.c:1.20 bridge.c:1.94 bridgestp.c:1.4 if_arcsubr.c:1.27 if_atm.h:1.24 if_atmsubr.c:1.40 if_bridge.c:1.16 if_ef.c:1.35 if_ethersubr.c:1.196 if_faith.c:1.37 if_fddisubr.c:1.100 if_fwsubr.c:1.14 if_gif.c:1.54 if_gre.c:1.34 if_iso88025subr.c:1.70 if_loop.c:1.107 if_ppp.c:1.106 if_spppsubr.c:1.121 if_tap.c:1.57 if_tun.c:1.154 if_vlan.c:1.80 ppp_tty.c:1.67 ieee80211_ioctl.c:1.32 atm_if.c:1.31 ng_eiface.c:1.33 ng_ether.c:1.50 ng_fec.c:1.19 ng_iface.c:1.44 ng_sppp.c:1.9 ip_carp.c:1.30 ip_fastfwd.c:1.30 in6.c:1.53 nd6_nbr.c:1.31 natm.c:1.40 if_dc.c:1.162 if_de.c:1.168 if_pcn.c:1.72 if_rl.c:1.154 if_sf.c:1.84 if_sis.c:1.135 if_sk.c:1.108 if_ste.c:1.86 if_ti.c:1.109 if_tl.c:1.101 if_vr.c:1.106 if_wb.c:1.81 if_xl.c:1.194 from HEAD to RELENG_6: Propagate rename of IFF_OACTIVE and IFF_RUNNING to IFF_DRV_OACTIVE and IFF_DRV_RUNNING, as well as the move from ifnet.if_flags to ifnet.if_drv_flags. Device drivers are now responsible for synchronizing access to these flags, as they are in if_drv_flags. This helps prevent races between the network stack and device driver in maintaining the interface flags field. Many __FreeBSD__ and __FreeBSD_version checks maintained and continued; some less so. Reviewed by: pjd, bz Approved by: re (scottl)
Revision 1.160.2.1 / (download) - annotate - [select for diffs], Wed Aug 24 16:50:45 2005 UTC (6 years, 5 months ago) by rwatson
Branch: RELENG_6
Changes since 1.160: +8 -0
lines
Diff to previous 1.160 (colored)
Merge if_ath.c:1.99 awi.c:1.39 if_bfe.c:1.26 if_bge.c:1.92 if_ed.c:1.255 if_em.c:1.67 if_ex.c:1.57 if_fe.c:1.92 if_fxp.c:1.242 if_gem.c:1.32 if_hme.c:1.38 if_ie.c:1.103 if_ndis.c:1.100 if_ixgb.c:1.12 if_lge.c:1.40 if_lnc.c:1.112 if_my.c:1.30 if_nge.c:1.76 if_nve.c:1.9 if_owi.c:1.11 pdq_ifsubr.c:1.27 if_ray.c:1.80 if_re.c:1.47 if_sn.c:1.47 dp83932.c:1.20 if_tx.c:1.90 if_txp.c:1.32 if_aue.c:1.91 if_axe.c:1.31 if_cue.c:1.58 if_kue.c:1.65 if_rue.c:1.22 if_udav.c:1.15 if_vge.c:1.15 if_wi.c:1.182 if_wl.c:1.67 if_xe.c:1.58 if_dc.c:1.161 if_de.c:1.167 if_pcn.c:1.70 if_rl.c:1.153 if_sf.c:1.83 if_sis.c:1.134 if_sk.c:1.107 if_ste.c:1.85 if_ti.c:1.108 if_tl.c:1.100 if_vr.c:1.105 if_wb.c:1.80 if_xl.c:1.193 from HEAD to RELENG_6: Modify device drivers supporting multicast addresses to lock if_addr_mtx over iteration of their multicast address lists when synchronizing the hardware address filter with the network stack-maintained list. Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca> Approved by: re (scottl)
Revision 1.164 / (download) - annotate - [select for diffs], Thu Aug 18 19:10:07 2005 UTC (6 years, 5 months ago) by jhb
Branch: MAIN
Changes since 1.163: +77 -70
lines
Diff to previous 1.163 (colored)
Fixup locking and mark MPSAFE: - Add locked versions of start and init. The SRM_MEDIA code in dc_init() stayed in dc_init() instead of moving to dc_init_locked() to make the locking saner. - Use callout_init_mtx(). - Fixup locking in detach and ioctl. - Lock the driver in the ifmedia callouts. - Don't recurse on the driver lock. - De-spl. MFC after: 3 days
Revision 1.163 / (download) - annotate - [select for diffs], Wed Aug 10 20:33:46 2005 UTC (6 years, 6 months ago) by jhb
Branch: MAIN
Changes since 1.162: +31 -35
lines
Diff to previous 1.162 (colored)
Use device_printf() and if_printf() and remove dc_unit from softc.
Revision 1.162 / (download) - annotate - [select for diffs], Tue Aug 9 10:20:00 2005 UTC (6 years, 6 months ago) by rwatson
Branch: MAIN
Changes since 1.161: +13 -12
lines
Diff to previous 1.161 (colored)
Propagate rename of IFF_OACTIVE and IFF_RUNNING to IFF_DRV_OACTIVE and IFF_DRV_RUNNING, as well as the move from ifnet.if_flags to ifnet.if_drv_flags. Device drivers are now responsible for synchronizing access to these flags, as they are in if_drv_flags. This helps prevent races between the network stack and device driver in maintaining the interface flags field. Many __FreeBSD__ and __FreeBSD_version checks maintained and continued; some less so. Reviewed by: pjd, bz MFC after: 7 days
Revision 1.161 / (download) - annotate - [select for diffs], Wed Aug 3 00:18:34 2005 UTC (6 years, 6 months ago) by rwatson
Branch: MAIN
Changes since 1.160: +8 -0
lines
Diff to previous 1.160 (colored)
Modify device drivers supporting multicast addresses to lock if_addr_mtx over iteration of their multicast address lists when synchronizing the hardware address filter with the network stack-maintained list. Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca> MFC after: 1 week
Revision 1.160 / (download) - annotate - [select for diffs], Fri Jun 10 16:49:22 2005 UTC (6 years, 8 months ago) by brooks
Branch: MAIN
CVS Tags: RELENG_6_BP
Branch point for: RELENG_6
Changes since 1.159: +30 -24
lines
Diff to previous 1.159 (colored)
Stop embedding struct ifnet at the top of driver softcs. Instead the struct ifnet or the layer 2 common structure it was embedded in have been replaced with a struct ifnet pointer to be filled by a call to the new function, if_alloc(). The layer 2 common structure is also allocated via if_alloc() based on the interface type. It is hung off the new struct ifnet member, if_l2com. This change removes the size of these structures from the kernel ABI and will allow us to better manage them as interfaces come and go. Other changes of note: - Struct arpcom is no longer referenced in normal interface code. Instead the Ethernet address is accessed via the IFP2ENADDR() macro. To enforce this ac_enaddr has been renamed to _ac_enaddr. - The second argument to ether_ifattach is now always the mac address from driver private storage rather than sometimes being ac_enaddr. Reviewed by: sobomax, sam
Revision 1.159 / (download) - annotate - [select for diffs], Sun May 29 04:42:29 2005 UTC (6 years, 8 months ago) by nyan
Branch: MAIN
Changes since 1.158: +0 -2
lines
Diff to previous 1.158 (colored)
Remove bus_{mem,p}io.h and related code for a micro-optimization on i386
and amd64. The optimization is a trivial on recent machines.
Reviewed by: -arch (imp, marcel, dfr)
Revision 1.148.2.4.2.3 / (download) - annotate - [select for diffs], Fri May 6 00:52:59 2005 UTC (6 years, 9 months ago) by scottl
Branch: RELENG_5_4
CVS Tags: RELENG_5_4_0_RELEASE
Changes since 1.148.2.4.2.2: +1 -1
lines
Diff to previous 1.148.2.4.2.2 (colored) to branchpoint 1.148.2.4 (colored) next main 1.148.2.5 (colored)
MFC: Don't forget a comma. Approved by: re
Revision 1.148.2.4.2.2 / (download) - annotate - [select for diffs], Fri May 6 00:51:29 2005 UTC (6 years, 9 months ago) by scottl
Branch: RELENG_5_4
Changes since 1.148.2.4.2.1: +3 -3
lines
Diff to previous 1.148.2.4.2.1 (colored) to branchpoint 1.148.2.4 (colored)
MFC: Don't ask busdma for an alignment for buffers. Approved by: re
Revision 1.148.2.7 / (download) - annotate - [select for diffs], Tue May 3 19:20:17 2005 UTC (6 years, 9 months ago) by scottl
Branch: RELENG_5
Changes since 1.148.2.6: +1 -1
lines
Diff to previous 1.148.2.6 (colored) to branchpoint 1.148 (colored)
Bugger, made the same typo in the previosu commit as the one to HEAD. Add a needed comma.
Revision 1.148.2.6 / (download) - annotate - [select for diffs], Tue May 3 19:09:15 2005 UTC (6 years, 9 months ago) by scottl
Branch: RELENG_5
Changes since 1.148.2.5: +3 -3
lines
Diff to previous 1.148.2.5 (colored) to branchpoint 1.148 (colored)
MFC rev 1.156: Don't ask busdma for an alignment for buffers. Fixes busdma from trying to exhaust all virtual memory. 5.4 candidate.
Revision 1.148.2.4.2.1 / (download) - annotate - [select for diffs], Fri Apr 22 03:41:09 2005 UTC (6 years, 9 months ago) by imp
Branch: RELENG_5_4
Changes since 1.148.2.4: +14 -13
lines
Diff to previous 1.148.2.4 (colored)
MFC: 1.158 Initialize mii/phy before probing same. Approved by: re@ (kensmith)
Revision 1.148.2.5 / (download) - annotate - [select for diffs], Thu Apr 21 17:54:11 2005 UTC (6 years, 9 months ago) by imp
Branch: RELENG_5
Changes since 1.148.2.4: +14 -13
lines
Diff to previous 1.148.2.4 (colored) to branchpoint 1.148 (colored)
MFC 1.158: enable mii/phy on Xircom cards before probing for the mii/phy rather than after. This should be merge to RELENG_5_4 too.
Revision 1.158 / (download) - annotate - [select for diffs], Mon Apr 18 03:31:29 2005 UTC (6 years, 9 months ago) by imp
Branch: MAIN
Changes since 1.157: +14 -13
lines
Diff to previous 1.157 (colored)
Fix newer Xircom CBE2-100 cards that were reporting dc0: MII without any PHY! We have to enable the connection to the MII first. Doing so fixes the problem cards without breaking the older, working cards. Bad card provided by: deischen
Revision 1.157 / (download) - annotate - [select for diffs], Wed Mar 9 00:54:55 2005 UTC (6 years, 11 months ago) by scottl
Branch: MAIN
Changes since 1.156: +1 -1
lines
Diff to previous 1.156 (colored)
Bugger, wiped out a needed comma in the previous commit.
Revision 1.156 / (download) - annotate - [select for diffs], Tue Mar 8 23:25:46 2005 UTC (6 years, 11 months ago) by scottl
Branch: MAIN
Changes since 1.155: +3 -3
lines
Diff to previous 1.155 (colored)
The DC driver asks for an alignment of PAGE_SIZE for data buffers, but also asks that each buffer be (2048 * 256) bytes long. I suspect that alignment isn't a real requirement since busdma only recently started honoring it. The size is also bogus. Fix both of these and stop busdma from trying to exhaust the system memory pool with bounce pages. Submitted by: Kevin Oberman MFC After: 7 days
Revision 1.148.2.4 / (download) - annotate - [select for diffs], Tue Mar 1 08:11:51 2005 UTC (6 years, 11 months ago) by imp
Branch: RELENG_5
CVS Tags: RELENG_5_4_BP
Branch point for: RELENG_5_4
Changes since 1.148.2.3: +68 -72
lines
Diff to previous 1.148.2.3 (colored) to branchpoint 1.148 (colored)
MFC: Use BUS_PROBE_DEFAULT in friends Minor whitespace diff reduction patches.
Revision 1.155 / (download) - annotate - [select for diffs], Thu Feb 24 22:33:05 2005 UTC (6 years, 11 months ago) by imp
Branch: MAIN
Changes since 1.154: +67 -71
lines
Diff to previous 1.154 (colored)
Fix style(9) issues with __P removal. Noticed by: bde
Revision 1.154 / (download) - annotate - [select for diffs], Thu Feb 24 21:32:55 2005 UTC (6 years, 11 months ago) by imp
Branch: MAIN
Changes since 1.153: +1 -1
lines
Diff to previous 1.153 (colored)
Return BUS_PROBE_DEFAULT instead of 0.
Revision 1.148.2.3 / (download) - annotate - [select for diffs], Mon Jan 31 23:26:50 2005 UTC (7 years ago) by imp
Branch: RELENG_5
Changes since 1.148.2.2: +1 -1
lines
Diff to previous 1.148.2.2 (colored) to branchpoint 1.148 (colored)
MFC: /*- and related license changes
Revision 1.153 / (download) - annotate - [select for diffs], Fri Jan 7 02:29:18 2005 UTC (7 years, 1 month ago) by imp
Branch: MAIN
Changes since 1.152: +1 -1
lines
Diff to previous 1.152 (colored)
/* -> /*- for license, minor formatting changes
Revision 1.148.2.2 / (download) - annotate - [select for diffs], Sat Oct 16 00:53:44 2004 UTC (7 years, 3 months ago) by green
Branch: RELENG_5
CVS Tags: RELENG_5_3_BP,
RELENG_5_3_0_RELEASE,
RELENG_5_3
Changes since 1.148.2.1: +23 -15
lines
Diff to previous 1.148.2.1 (colored) to branchpoint 1.148 (colored)
MFC r1.149-r1.151: add IFF_NEEDSGIANT when IS_GIANT and add ALTQ support. Approved by: re
Revision 1.148.2.1 / (download) - annotate - [select for diffs], Thu Oct 14 18:37:01 2004 UTC (7 years, 3 months ago) by mux
Branch: RELENG_5
Changes since 1.148: +4 -4
lines
Diff to previous 1.148 (colored)
Merge if_dc.c:1.152 from HEAD to RELENG_5: date: 2004/10/01 15:23:31; author: mux; state: Exp; lines: +4 -4 Read the MAC address in the EEPROM in the correct byte order. This is a no-op on little endian architectures, but fixes getting the MAC address for some dc(4) cards on big endian architectures. Approved by: re (scottl)
Revision 1.152 / (download) - annotate - [select for diffs], Fri Oct 1 15:23:31 2004 UTC (7 years, 4 months ago) by mux
Branch: MAIN
Changes since 1.151: +4 -4
lines
Diff to previous 1.151 (colored)
Read the MAC address in the EEPROM in the correct byte order. This is a no-op on little endian architectures, but fixes getting the MAC address for some dc(4) cards on big endian architectures. This is a RELENG_5 candidate. Tested by: gallatin (powerpc), marius (sparc64) First version of the patch written by: gallatin
Revision 1.151 / (download) - annotate - [select for diffs], Fri Oct 1 07:04:09 2004 UTC (7 years, 4 months ago) by green
Branch: MAIN
Changes since 1.150: +21 -15
lines
Diff to previous 1.150 (colored)
Add ALTQ support for dc(4), based upon a mostly-working patch from mlaier.
Revision 1.150 / (download) - annotate - [select for diffs], Fri Oct 1 07:01:38 2004 UTC (7 years, 4 months ago) by green
Branch: MAIN
Changes since 1.149: +3 -2
lines
Diff to previous 1.149 (colored)
Conditionalize IFF_NEEDSGIANT, like everything else here, on IS_MPSAFE. The driver doesn't look any less safe without Giant than with, and works with IS_MPSAFE set to 1 here, so others should probably test it as such.
Revision 1.149 / (download) - annotate - [select for diffs], Wed Aug 25 03:37:25 2004 UTC (7 years, 5 months ago) by rwatson
Branch: MAIN
Changes since 1.148: +2 -1
lines
Diff to previous 1.148 (colored)
if_dc includes locking, but that locking is disabled by a #ifdef by default. As such, mark if_dc as IFF_NEEDSGIANT until such time as appropriate locking review and testing can take place, and the locking can be enabled by default. RELENG_5 candidate.
Revision 1.148 / (download) - annotate - [select for diffs], Sat Aug 14 21:43:37 2004 UTC (7 years, 5 months ago) by marius
Branch: MAIN
CVS Tags: RELENG_5_BP
Branch point for: RELENG_5
Changes since 1.147: +1 -1
lines
Diff to previous 1.147 (colored)
- Make OF_getetheraddr() honour the "local-mac-address?" system config variable. If set to "true" OF_getetheraddr() will now return the unique MAC address stored in the "local-mac-address" property of the device's OFW node if present and the host address/system default MAC address if the node doesn't doesn't have such a property. If set to "false" the host address will be returned for all devices like before this change. This brings the behaviour of device drivers for NICs with OFW support/ FCode, i.e. dc(4) for on-board DM9102A on Sun machines, gem(4) and hme(4), regarding "local-mac-address?" in line with NetBSD and Solaris. The man pages of the respective drivers will be updated separately to reflect this change. - Remove OF_getetheraddr2() which was used as a stopgap in dc(4). Its functionality is now part of OF_getetheraddr().
Revision 1.147 / (download) - annotate - [select for diffs], Mon Jul 5 22:32:33 2004 UTC (7 years, 7 months ago) by bms
Branch: MAIN
Changes since 1.146: +6 -6
lines
Diff to previous 1.146 (colored)
Whitespace nits
Revision 1.146 / (download) - annotate - [select for diffs], Mon Jun 28 20:07:03 2004 UTC (7 years, 7 months ago) by imp
Branch: MAIN
Changes since 1.145: +3 -63
lines
Diff to previous 1.145 (colored)
Remove burn bridges code that saved/restored the pci config registers that are now handled in the pci bus layer. They are no longer necessary.
Revision 1.145 / (download) - annotate - [select for diffs], Wed Jun 9 14:34:03 2004 UTC (7 years, 8 months ago) by naddy
Branch: MAIN
Changes since 1.144: +3 -23
lines
Diff to previous 1.144 (colored)
Replace handrolled CRC calculation with ether_crc32_[lb]e().
Revision 1.144 / (download) - annotate - [select for diffs], Sun May 30 20:00:40 2004 UTC (7 years, 8 months ago) by phk
Branch: MAIN
Changes since 1.143: +1 -0
lines
Diff to previous 1.143 (colored)
Add missing <sys/module.h> includes
Revision 1.143 / (download) - annotate - [select for diffs], Sun May 23 21:05:06 2004 UTC (7 years, 8 months ago) by yar
Branch: MAIN
Changes since 1.142: +2 -1
lines
Diff to previous 1.142 (colored)
A handler for ioctl(SIOCSIFCAP) should not alter a bit in if_capenable unless the interface driver is actually able to toggle the respective capability on and off. Reviewed by: ru
Revision 1.9.2.56 / (download) - annotate - [select for diffs], Thu Apr 22 22:03:27 2004 UTC (7 years, 9 months ago) by ru
Branch: RELENG_4
CVS Tags: RELENG_4_11_BP,
RELENG_4_11_0_RELEASE,
RELENG_4_11
Changes since 1.9.2.55: +13 -1
lines
Diff to previous 1.9.2.55 (colored) to branchpoint 1.9 (colored) next main 1.10 (colored)
MFC: Per-interface polling(4) control.
Revision 1.142 / (download) - annotate - [select for diffs], Sun Apr 11 13:47:15 2004 UTC (7 years, 10 months ago) by ru
Branch: MAIN
Changes since 1.141: +13 -1
lines
Diff to previous 1.141 (colored)
First driver with user-configurable polling(4).
Revision 1.141 / (download) - annotate - [select for diffs], Wed Mar 17 17:50:53 2004 UTC (7 years, 10 months ago) by njl
Branch: MAIN
Changes since 1.140: +2 -3
lines
Diff to previous 1.140 (colored)
Convert callers to the new bus_alloc_resource_any(9) API. Submitted by: Mark Santcroos <marks@ripe.net> Reviewed by: imp, dfr, bde
Revision 1.140 / (download) - annotate - [select for diffs], Sun Mar 14 07:12:25 2004 UTC (7 years, 10 months ago) by mdodd
Branch: MAIN
Changes since 1.139: +0 -5
lines
Diff to previous 1.139 (colored)
Announce ethernet MAC addresss in ether_ifattach().
Revision 1.137.2.2 / (download) - annotate - [select for diffs], Sun Jan 25 05:23:21 2004 UTC (8 years ago) by scottl
Branch: RELENG_5_2
CVS Tags: RELENG_5_2_1_RELEASE
Changes since 1.137.2.1: +18 -0
lines
Diff to previous 1.137.2.1 (colored) to branchpoint 1.137 (colored) next main 1.138 (colored)
MFC the if_dc fix for sparc64 Davicom cards that store thier MAC in OFW instead in SEEPROM. Approved by: re
Revision 1.137.2.1 / (download) - annotate - [select for diffs], Fri Jan 9 21:13:55 2004 UTC (8 years, 1 month ago) by truckman
Branch: RELENG_5_2
CVS Tags: RELENG_5_2_0_RELEASE
Changes since 1.137: +4 -3
lines
Diff to previous 1.137 (colored)
MFC 1.138 - Check for transmit status and free the mbuf chain when
processing the last transmit descriptor for the frame
instead of the first descriptor. This eliminates the
bug that caused the driver to report spurious collisions
and output errors that was introduced when the driver
was changed to look at the first transmit descriptor
when it was converted to use busdma (rev 1.115).
Approved by: re (scottl)
Revision 1.139 / (download) - annotate - [select for diffs], Thu Jan 8 19:08:26 2004 UTC (8 years, 1 month ago) by mux
Branch: MAIN
Changes since 1.138: +18 -0
lines
Diff to previous 1.138 (colored)
Some integrated Davicom cards in sparc64 boxes have an all zeros MAC address in the EEPROM, and we need to get it from OpenFirmware. This isn't very pretty but time is lacking to do this in a better way this near 5.2-RELEASE. This is a RELENG_5_2 candidate. Original version by: Marius Strobl <marius@alchemy.franken.de> Tested by: Pete Bentley <pete@sorted.org> Reviewed by: jake
Revision 1.138 / (download) - annotate - [select for diffs], Thu Jan 8 06:22:15 2004 UTC (8 years, 1 month ago) by truckman
Branch: MAIN
Changes since 1.137: +4 -3
lines
Diff to previous 1.137 (colored)
The transmit frame status is stored in the last transmit descriptor for the frame, not the first. It is probably also not safe to free the mbuf chain as soon as the OWN bit is cleared on the first descriptor since the chip may not be done copying the frame into the transmit FIFO. Revert the part of of busdma conversion (if_dc.c rev 1.115) which changed dc_txeof() to look for the status in the first descriptor and free the mbuf chain when processing the first descriptor for the frame, and revert the matching changes elsewhere in the driver. This part of the busdma change caused the driver to report spurious collisions and output errors, even when running in full-duplex mode. Reverting the mbuf chain handling slightly complicates dc_dma_map_txbuf(), since it is responsible for setting the OWN bits on the descriptors, but does not normally have direct access to the mbuf chain. Tested by: Dejan Lesjak <dejan.lesjak at ijs.si> alpha/<Intel 21143 10/100BaseTX> "Xin LI" <delphij at frontfree.net> i386/<Macronix 98713 10/100BaseTX> Wiktor Niesiobedzki <bsd at w.evip.pl> i386/<3Com OfficeConnect 10/100B> Reviewed by: mux
Revision 1.9.2.55 / (download) - annotate - [select for diffs], Mon Dec 22 07:29:32 2003 UTC (8 years, 1 month ago) by sanpei
Branch: RELENG_4
CVS Tags: RELENG_4_10_BP,
RELENG_4_10_0_RELEASE,
RELENG_4_10
Changes since 1.9.2.54: +4 -0
lines
Diff to previous 1.9.2.54 (colored) to branchpoint 1.9 (colored)
MFC Rev.1.111 Add ADMtek ADM9511 and ADM9513 device ID's
Revision 1.137 / (download) - annotate - [select for diffs], Sat Dec 6 02:29:31 2003 UTC (8 years, 2 months ago) by sanpei
Branch: MAIN
CVS Tags: RELENG_5_2_BP
Branch point for: RELENG_5_2
Changes since 1.136: +2 -0
lines
Diff to previous 1.136 (colored)
Add support for ELECOM/Laneed CardBus FastEtherner Card(LD-CBL/TXA) Submitted by: Masahiro Yamagishi <night@pluto.dti.ne.jp> Approved by: re (scottl)
Revision 1.136 / (download) - annotate - [select for diffs], Fri Nov 28 05:28:29 2003 UTC (8 years, 2 months ago) by imp
Branch: MAIN
Changes since 1.135: +1 -0
lines
Diff to previous 1.135 (colored)
Sometimes cardbus attachments don't attach, so while we track down this problem put these lines back in. While they should be unnecessary, they appear to be sometimes necessary. Reviewed in concept: dfr Approved by: re (scottl@)
Revision 1.135 / (download) - annotate - [select for diffs], Fri Nov 14 19:00:31 2003 UTC (8 years, 2 months ago) by sam
Branch: MAIN
Changes since 1.134: +9 -1
lines
Diff to previous 1.134 (colored)
Drop the driver lock around calls to if_input to avoid a LOR when the packets are immediately returned for sending (e.g. when bridging or packet forwarding). There are more efficient ways to do this but for now use the least intrusive approach. Reviewed by: imp, rwatson
Revision 1.134 / (download) - annotate - [select for diffs], Fri Nov 14 17:16:57 2003 UTC (8 years, 2 months ago) by obrien
Branch: MAIN
Changes since 1.133: +3 -4
lines
Diff to previous 1.133 (colored)
Remove duplicate FBSDID's, move others to their right place.
Revision 1.133 / (download) - annotate - [select for diffs], Fri Nov 14 05:45:39 2003 UTC (8 years, 2 months ago) by imp
Branch: MAIN
Changes since 1.132: +10 -10
lines
Diff to previous 1.132 (colored)
reconst poison re-de u_intXX_t
Revision 1.132 / (download) - annotate - [select for diffs], Thu Nov 13 20:55:52 2003 UTC (8 years, 2 months ago) by obrien
Branch: MAIN
Changes since 1.131: +23 -20
lines
Diff to previous 1.131 (colored)
Try to create some sort of consistency in how the routings to find the multicast hash are written. There are still two distinct algorithms used, and there actually isn't any reason each driver should have its own copy of this function as they could all share one copy of it (if it grew an additional argument).
Revision 1.9.2.54 / (download) - annotate - [select for diffs], Tue Nov 11 17:28:15 2003 UTC (8 years, 3 months ago) by silby
Branch: RELENG_4
Changes since 1.9.2.53: +9 -9
lines
Diff to previous 1.9.2.53 (colored) to branchpoint 1.9 (colored)
MFC rev 1.127; fix a condition where dc_encap would allocate a new mbuf, causing bpf_mtap to be fed the stale, now-freed m_head.
Revision 1.131 / (download) - annotate - [select for diffs], Mon Nov 3 09:22:18 2003 UTC (8 years, 3 months ago) by dfr
Branch: MAIN
Changes since 1.130: +0 -1
lines
Diff to previous 1.130 (colored)
Remove explicit cardbus attachments from drivers where this is identical to the pci attachment. Cardbus is a derived class of pci so all pci drivers are automatically available for matching against cardbus devices. Reviewed by: imp
Revision 1.130 / (download) - annotate - [select for diffs], Sun Nov 2 21:43:29 2003 UTC (8 years, 3 months ago) by ru
Branch: MAIN
Changes since 1.129: +1 -1
lines
Diff to previous 1.129 (colored)
Correct the spelling of m_devget() in the sysctl variable description.
Revision 1.129 / (download) - annotate - [select for diffs], Fri Oct 31 18:32:13 2003 UTC (8 years, 3 months ago) by brooks
Branch: MAIN
Changes since 1.128: +1 -2
lines
Diff to previous 1.128 (colored)
Replace the if_name and if_unit members of struct ifnet with new members if_xname, if_dname, and if_dunit. if_xname is the name of the interface and if_dname/unit are the driver name and instance. This change paves the way for interface renaming and enhanced pseudo device creation and configuration symantics. Approved By: re (in principle) Reviewed By: njl, imp Tested On: i386, amd64, sparc64 Obtained From: NetBSD (if_xname)
Revision 1.9.2.53 / (download) - annotate - [select for diffs], Wed Oct 29 09:57:33 2003 UTC (8 years, 3 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.52: +3 -4
lines
Diff to previous 1.9.2.52 (colored) to branchpoint 1.9 (colored)
MFC Rev. 1.125 Don't read the MAC address from a copy of the EEPROM in the softc that has been recorded earlier and overwrite it again later by reading it directly from the EEPROM again. Read the MAC address from the PAR0/PAR1 registers instead, which are autoloaded on reboot.
Revision 1.9.2.52 / (download) - annotate - [select for diffs], Wed Oct 29 09:52:33 2003 UTC (8 years, 3 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.51: +0 -0
lines
Diff to previous 1.9.2.51 (colored) to branchpoint 1.9 (colored)
Forced commit: Previous commit message was not correct. Ignore CSR13, CSR14, CSR15 'Media Specific Data' registers for 21143 based cards which use SIA mode. MFC rev. 1.126 of if_dc.c
Revision 1.9.2.51 / (download) - annotate - [select for diffs], Wed Oct 29 09:46:10 2003 UTC (8 years, 3 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.50: +24 -9
lines
Diff to previous 1.9.2.50 (colored) to branchpoint 1.9 (colored)
MFC: Rev. 1.38 of if_dcreg.h Rev. 1.125 if if_dc.c
Revision 1.128 / (download) - annotate - [select for diffs], Thu Oct 23 16:57:38 2003 UTC (8 years, 3 months ago) by imp
Branch: MAIN
Changes since 1.127: +9 -9
lines
Diff to previous 1.127 (colored)
Const poison crc routines (why these aren't centralized, I'm not sure).
Revision 1.127 / (download) - annotate - [select for diffs], Sun Oct 19 23:05:19 2003 UTC (8 years, 3 months ago) by silby
Branch: MAIN
Changes since 1.126: +8 -8
lines
Diff to previous 1.126 (colored)
Fix a problem where m_defrag would allocate a new mbuf to replace the chain passed into dc_encap, which dc_start was unaware of. This caused the old (now invalid) mbuf to be passed to BPF_MTAP. Spotted by: Kenjiro Cho <kjc@csl.sony.co.jp>
Revision 1.126 / (download) - annotate - [select for diffs], Sun Oct 5 19:57:10 2003 UTC (8 years, 4 months ago) by mbr
Branch: MAIN
Changes since 1.125: +26 -9
lines
Diff to previous 1.125 (colored)
Ignore CSR13, CSR14, CSR15 'Media Specific Data' registers for 21143 based cards which use SIA mode. This fixes 10mbit mode for ZNYX ZX346Q cards and other 21143 based cards. PR: 32118 Submitted by: Rene de Vries <rene@tunix.nl> Geert Jan de Groot <GeertJan.deGroot@tunix.nl> Obtained from: BSDI MFC after: 2 weeks
Revision 1.125 / (download) - annotate - [select for diffs], Tue Sep 16 05:01:27 2003 UTC (8 years, 4 months ago) by mbr
Branch: MAIN
Changes since 1.124: +3 -4
lines
Diff to previous 1.124 (colored)
Don't read the MAC address from a copy of the EEPROM in the softc that has been recorded earlier and overwrite it again later by reading it directly from the EEPROM again. Read the MAC address from the PAR0/PAR1 registers instead, which are autoloaded on reboot. Tested on AN985, AN983B. According to the datasheets, it should also work for the AL981 (I don't have such a chip on a card at home) PR: 52988 Submitted by: Andrew Gordon <arg-bsd@arg.me.uk> MFC after: 2 weeks
Revision 1.124 / (download) - annotate - [select for diffs], Tue Sep 2 17:30:40 2003 UTC (8 years, 5 months ago) by jhb
Branch: MAIN
Changes since 1.123: +2 -2
lines
Diff to previous 1.123 (colored)
Use PCIR_BAR(x) instead of PCIR_MAPS. Glanced over by: imp, gibbs Tested by: i386 LINT
Revision 1.9.2.50 / (download) - annotate - [select for diffs], Wed Aug 27 13:40:35 2003 UTC (8 years, 5 months ago) by mbr
Branch: RELENG_4
CVS Tags: RELENG_4_9_BP,
RELENG_4_9_0_RELEASE,
RELENG_4_9
Changes since 1.9.2.49: +3 -2
lines
Diff to previous 1.9.2.49 (colored) to branchpoint 1.9 (colored)
MFC: rev. 1.63 and rev. 1.123 Do it right this time. All davicom cards need DC_TX_ALIGN. Avoid an unnecessary copy of a packet if it is already in a single mbuf. Introduce an additional device flag for those NICs which require the transmit buffers to be aligned to 32-bit boundaries. Approved by: murray (re)
Revision 1.9.2.49 / (download) - annotate - [select for diffs], Wed Aug 27 12:49:13 2003 UTC (8 years, 5 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.48: +0 -1
lines
Diff to previous 1.9.2.48 (colored) to branchpoint 1.9 (colored)
Back this out by request. DC_TX_ALIGN is not defined in stable. I'll have to solve this differently.
Revision 1.9.2.48 / (download) - annotate - [select for diffs], Wed Aug 27 08:29:32 2003 UTC (8 years, 5 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.47: +1 -0
lines
Diff to previous 1.9.2.47 (colored) to branchpoint 1.9 (colored)
MFC: All davicom cards seem to need DC_TX_ALIGN. Approved by: murray (re)
Revision 1.123 / (download) - annotate - [select for diffs], Wed Aug 27 08:13:34 2003 UTC (8 years, 5 months ago) by mbr
Branch: MAIN
Changes since 1.122: +1 -2
lines
Diff to previous 1.122 (colored)
All davicom cards seem to need DC_TX_ALIGN.
Revision 1.122 / (download) - annotate - [select for diffs], Sun Aug 24 23:47:44 2003 UTC (8 years, 5 months ago) by mbr
Branch: MAIN
Changes since 1.121: +2 -0
lines
Diff to previous 1.121 (colored)
Make TX on davicom 9102A working again. This chip needs its mbufs aligned on TX. PR: 53656, 42714 MFC after: 3 days
Revision 1.121 / (download) - annotate - [select for diffs], Fri Aug 22 07:13:20 2003 UTC (8 years, 5 months ago) by imp
Branch: MAIN
Changes since 1.120: +2 -2
lines
Diff to previous 1.120 (colored)
Prefer new location of pci include files (which have only been in the tree for two or more years now), except in a few places where there's code to be compatible with older versions of FreeBSD.
Revision 1.120 / (download) - annotate - [select for diffs], Tue Aug 19 17:51:10 2003 UTC (8 years, 5 months ago) by sam
Branch: MAIN
Changes since 1.119: +1 -1
lines
Diff to previous 1.119 (colored)
Change instances of callout_init that specify MPSAFE behaviour to use CALLOUT_MPSAFE instead of "1" for the second parameter. This does not change the behaviour; it just makes the intent more clear.
Revision 1.119 / (download) - annotate - [select for diffs], Sun Jul 27 14:00:02 2003 UTC (8 years, 6 months ago) by mux
Branch: MAIN
Changes since 1.118: +1 -2
lines
Diff to previous 1.118 (colored)
Use the BUS_DMA_ZERO flag.
Revision 1.118 / (download) - annotate - [select for diffs], Sat Jul 19 06:01:15 2003 UTC (8 years, 6 months ago) by imp
Branch: MAIN
Changes since 1.117: +4 -0
lines
Diff to previous 1.117 (colored)
Add support for FA-511; Submitted by: Kenneth P. Stox; Pr 42858
Revision 1.9.2.47 / (download) - annotate - [select for diffs], Mon Jul 14 21:16:01 2003 UTC (8 years, 6 months ago) by silby
Branch: RELENG_4
Changes since 1.9.2.46: +30 -34
lines
Diff to previous 1.9.2.46 (colored) to branchpoint 1.9 (colored)
MFC rev 1.96: Update if_dc to use m_defrag, removing the semi-duplicate dc_coal function. Also, use m_defrag where appropriate to defrag long mbuf chains in the same fashion as was done in if_sis.c. Before this change, if_dc would blow up and take down the interface if fed a really long mbuf chain.
Revision 1.117 / (download) - annotate - [select for diffs], Thu Jul 10 18:43:15 2003 UTC (8 years, 7 months ago) by wpaul
Branch: MAIN
Changes since 1.116: +20 -0
lines
Diff to previous 1.116 (colored)
Add support for a bunch of Microsoft networking products: - MN-110 10/100 USB ethernet (ADMtek Pegasus II, if_aue) - MN-120 10/100 cardbus (ADMtek Centaur-C, if_dc) - MN-130 10/100 PCI (ADMtek Centaur-P, if_dc) Also update dc(4) man page to mention support for MN-120 and MN-130.
Revision 1.9.2.46 / (download) - annotate - [select for diffs], Thu Jul 10 16:37:41 2003 UTC (8 years, 7 months ago) by mux
Branch: RELENG_4
Changes since 1.9.2.45: +4 -2
lines
Diff to previous 1.9.2.45 (colored) to branchpoint 1.9 (colored)
MFC: Fix a bug that could cause dc_stop() to try to m_freem() something that's not a valid mbuf pointer. Relevant HEAD revision: 1.114
Revision 1.116 / (download) - annotate - [select for diffs], Wed Jul 9 15:03:10 2003 UTC (8 years, 7 months ago) by mux
Branch: MAIN
Changes since 1.115: +50 -45
lines
Diff to previous 1.115 (colored)
Make the dc(4) driver endian-clean, so to that it works on sparc64. There are such cards in Netra X1 boxes, which should thus be fully supported now. Tested by: jake
Revision 1.115 / (download) - annotate - [select for diffs], Sun Jul 6 21:45:31 2003 UTC (8 years, 7 months ago) by mux
Branch: MAIN
Changes since 1.114: +281 -108
lines
Diff to previous 1.114 (colored)
Convert the dc(4) driver to the busdma API. This is a necessary step to have this driver working on sparc64. It still needs to be made endian-clean before it can work there. Special thanks to dragonk@evilcode.net for sending me a dc(4) card so that I was able to do this work. Many cheers to all the people that tested this change, thanks to them, this change shouldn't break anything :-). Tested by: marcel (i386 and ia64), ru (i386), wilko (alpha), mbr (i386), wpaul (i386) and Will Saxon <WillS@housing.ufl.edu> (i386)
Revision 1.114 / (download) - annotate - [select for diffs], Sun Jul 6 14:39:45 2003 UTC (8 years, 7 months ago) by mux
Branch: MAIN
Changes since 1.113: +2 -1
lines
Diff to previous 1.113 (colored)
Fix a bug that could cause dc(4) to m_freem() an already freed mbuf or something that isn't an mbuf. MFC after: 3 days
Revision 1.113 / (download) - annotate - [select for diffs], Sun Jul 6 14:36:33 2003 UTC (8 years, 7 months ago) by mux
Branch: MAIN
Changes since 1.112: +22 -14
lines
Diff to previous 1.112 (colored)
Various style(9) and readability fixes.
Revision 1.112 / (download) - annotate - [select for diffs], Thu Jul 3 21:39:53 2003 UTC (8 years, 7 months ago) by imp
Branch: MAIN
Changes since 1.111: +8 -4
lines
Diff to previous 1.111 (colored)
Due to extreme bogusness in the pci bus layer, these drivers were forced to do slightly bogus power state manipulation. However, this is one of those features that is preventing further progress, so mark them as BURN_BIRDGES like I did for the drivers in sys/dev/... This, like the other change, are a no-op unless you have BURN_BRIDGES in your kernel.
Revision 1.9.2.45 / (download) - annotate - [select for diffs], Sun Jun 8 14:31:53 2003 UTC (8 years, 8 months ago) by mux
Branch: RELENG_4
Changes since 1.9.2.44: +1 -1
lines
Diff to previous 1.9.2.44 (colored) to branchpoint 1.9 (colored)
MFC: Change a : bzero(ptr, sizeof(DC_RXLEN * 5)); which should obviously be: bzero(ptr, DC_RXLEN * 5); Looks like this bug may have reduced the effectiveness of the workaround for the hardware bug in the PNIC chips. Relevant HEAD revision: if_dc.c: 1.110
Revision 1.111 / (download) - annotate - [select for diffs], Sun Jun 8 10:11:55 2003 UTC (8 years, 8 months ago) by mbr
Branch: MAIN
Changes since 1.110: +6 -0
lines
Diff to previous 1.110 (colored)
Add ADMtek ADM9511 and ADM9513 device ID's. PR: PR51823 Submitted by: Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp> Reviewed by: phk MFC after: 2 days
Revision 1.9.2.44 / (download) - annotate - [select for diffs], Sat Jun 7 21:36:48 2003 UTC (8 years, 8 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.43: +26 -2
lines
Diff to previous 1.9.2.43 (colored) to branchpoint 1.9 (colored)
MFC Rev. 1.107 Only use a SIA/SYM media info block if no MII block is detected. Reviewed by: phk
Revision 1.9.2.43 / (download) - annotate - [select for diffs], Sat Jun 7 17:15:02 2003 UTC (8 years, 8 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.42: +5 -1
lines
Diff to previous 1.9.2.42 (colored) to branchpoint 1.9 (colored)
MFC Rev 1.105 Use only a 64bit hash filter table for ADM-Centaur cards like the Accton EN2242 and the ADMtek AN985 cards. Reviewed by: phk
Revision 1.9.2.42 / (download) - annotate - [select for diffs], Sat Jun 7 16:55:34 2003 UTC (8 years, 8 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.41: +3 -0
lines
Diff to previous 1.9.2.41 (colored) to branchpoint 1.9 (colored)
MFC rev. 1.106 (if_dc.c) and rev. 1.31 (if_dcreg.h) Add support for 3Com OfficeConnect 10/100B. Reviewed by: phk
Revision 1.110 / (download) - annotate - [select for diffs], Sun Jun 1 22:09:12 2003 UTC (8 years, 8 months ago) by mux
Branch: MAIN
Changes since 1.109: +1 -1
lines
Diff to previous 1.109 (colored)
Change a : bzero(ptr, sizeof(DC_RXLEN * 5)); which should obviously be: bzero(ptr, DC_RXLEN * 5); Looks like this bug may have reduced the effectiveness of the workaround for the hardware bug in the PNIC chips. MFC after: 1 week
Revision 1.109 / (download) - annotate - [select for diffs], Sun Jun 1 19:26:34 2003 UTC (8 years, 8 months ago) by mux
Branch: MAIN
Changes since 1.108: +371 -541
lines
Diff to previous 1.108 (colored)
- Style(9) fixes, most notably : o Remove register keyword o ANSIfy prototypes o Remove "return;" at the end of void functions o Remove trailing spaces o Don't align local variables with tabs and reorder them o Don't use /* FOO */ at the end of a #ifdef FOO block if it's a small block - Other non-functional changes : o 6 -> ETHER_ADDR_LEN o Don't initialize if_output; ether_ifattach() does it for us
Revision 1.108 / (download) - annotate - [select for diffs], Thu May 15 16:53:29 2003 UTC (8 years, 8 months ago) by mbr
Branch: MAIN
CVS Tags: RELENG_5_1_BP,
RELENG_5_1_0_RELEASE,
RELENG_5_1
Changes since 1.107: +26 -2
lines
Diff to previous 1.107 (colored)
Only use a SIA/SYM media info block if no MII block is detected. The submitter of PR 32118 told me that this patch also fixes autoselecting for znyx 4 port cards (10baseT, 100baseTX did work already). PR: 32118 Reviewed by: imp Approved by: rwatson (re)
Revision 1.107 / (download) - annotate - [select for diffs], Mon May 12 19:50:20 2003 UTC (8 years, 9 months ago) by mbr
Branch: MAIN
Changes since 1.106: +4 -0
lines
Diff to previous 1.106 (colored)
Add support for 3Com OfficeConnect 10/100B. PR: 49059, 50747 Submitted by: Dax Eckenberg <daxbert@dweebsoft.com> Reviewed by: imp, jhb Approved by: jhb MFC after: 2 weeks
Revision 1.106 / (download) - annotate - [select for diffs], Thu May 1 09:31:01 2003 UTC (8 years, 9 months ago) by mbr
Branch: MAIN
Changes since 1.105: +5 -1
lines
Diff to previous 1.105 (colored)
Use only a 64bit hash filter table for ADM-Centaur cards like the Accton EN2242 and the ADMtek AN985 cards. PR: 32699 Submitted by: Jean-Luc Richier <Jean-Luc.Richier@imag.fr> Reviewed by: phk MFC after: 2 weeks
Revision 1.105 / (download) - annotate - [select for diffs], Mon Apr 21 18:34:04 2003 UTC (8 years, 9 months ago) by imp
Branch: MAIN
Changes since 1.104: +1 -1
lines
Diff to previous 1.104 (colored)
Use newly minted device_is_attached rather than device_is_alive to see if attach succeeded. device_is_alive just tells us that probe succeeded. Since we were using it to do things like detach net interfaces, this caused problems when there were errors in the attach routine. Symptoms of problem reported by: martin blapp
Revision 1.104 / (download) - annotate - [select for diffs], Fri Apr 18 15:42:25 2003 UTC (8 years, 9 months ago) by sanpei
Branch: MAIN
Changes since 1.103: +2 -0
lines
Diff to previous 1.103 (colored)
Add support for Planex FNW-3602-T(CardBus 100M/10M). Submitted by: kazz <kazz@v001.vaio.ne.jp> Obtained from: [bsd-nomads:16637]
Revision 1.103 / (download) - annotate - [select for diffs], Thu Apr 17 20:32:06 2003 UTC (8 years, 9 months ago) by njl
Branch: MAIN
Changes since 1.102: +12 -2
lines
Diff to previous 1.102 (colored)
Revise attach/detach resource cleanup - Unconditionally call *_stop() if device is in the tree. This is to prevent callouts from happening after the device is gone. Checks for bus_child_present() should be added in the future to keep from touching potentially non-existent hardware in *_detach(). Found by iedowse@. - Always check for and free miibus children, even if the device is not in the tree since some failure cases could have gotten here. - Call ether_ifdetach() in the irq setup failure case - ti(4), xl(4): move ifmedia_init() calls to the beginning of attach so that ifmedia_removeall() can be unconditionally called on detach. There is no way to detect whether ifmedia has been initialized without using a separate variable (as tl(4) does). - Add comments to indicate assumptions of code path
Revision 1.102 / (download) - annotate - [select for diffs], Thu Apr 17 08:36:52 2003 UTC (8 years, 9 months ago) by iedowse
Branch: MAIN
Changes since 1.101: +1 -2
lines
Diff to previous 1.101 (colored)
Revert part of revision 1.97 by calling dc_stop() unconditionally in dc_detach() instead of only calling it if the hardware is preset. This is a workaround for page faults in softclock() after a `dc' device was detached, caused by not disabling a timer before freeing its memory. The bus_child_present() checks should probably be re-added later, but only to avoid the hardware accesses and not the other resource cleanups in dc_stop(). Approved by: njl
Revision 1.101 / (download) - annotate - [select for diffs], Wed Apr 16 03:16:56 2003 UTC (8 years, 9 months ago) by mdodd
Branch: MAIN
Changes since 1.100: +0 -17
lines
Diff to previous 1.100 (colored)
- Don't call pci_enable_io() in drivers (unless needed for resume). - Don't test memory/port status and emit an error message; the PCI bus code will do this now.
Revision 1.100 / (download) - annotate - [select for diffs], Tue Apr 15 06:37:29 2003 UTC (8 years, 9 months ago) by mdodd
Branch: MAIN
Changes since 1.99: +4 -2
lines
Diff to previous 1.99 (colored)
- Express hard dependencies on bus (pci, isa, pccard) and network layer (ether). - Don't abuse module names to facilitate ifconfig module loading; such abuse isn't really needed. (And if we do need type information associated with a module then we should make it explicit and not use hacks.)
Revision 1.99 / (download) - annotate - [select for diffs], Thu Apr 3 21:36:32 2003 UTC (8 years, 10 months ago) by obrien
Branch: MAIN
Changes since 1.98: +3 -7
lines
Diff to previous 1.98 (colored)
Use __FBSDID rather than rcsid[].
Revision 1.98 / (download) - annotate - [select for diffs], Mon Mar 31 20:22:00 2003 UTC (8 years, 10 months ago) by jhb
Branch: MAIN
Changes since 1.97: +1 -1
lines
Diff to previous 1.97 (colored)
Add missing ()'s so that these drivers all compile again. Noticed by: jake Tested on: i386 (compile)
Revision 1.97 / (download) - annotate - [select for diffs], Mon Mar 31 17:29:43 2003 UTC (8 years, 10 months ago) by njl
Branch: MAIN
Changes since 1.96: +32 -33
lines
Diff to previous 1.96 (colored)
Clean up locking and resource management for pci/if_* - Remove locking of the softc in the attach method, instead depending on bus_setup_intr being at the end of attach (delaying interrupt enable until after ether_ifattach is called) - Call *_detach directly in the error case of attach, depending on checking in detach to only free resources that were allocated. This puts all resource freeing in one place, avoiding thinkos that lead to memory leaks. - Add bus_child_present check to calls to *_stop in the detach method to be sure hw is present before touching its registers. - Remove bzero softc calls since device_t should do this for us. - dc: move interrupt allocation back where it was before. It was unnecessary to move it. This reverts part of 1.88 - rl: move irq allocation before ether_ifattach. Problems might have been caused by allocating the irq after enabling interrupts on the card. - rl: call rl_stop before ether_ifdetach - sf: call sf_stop before ether_ifdetach - sis: add missed free of sis_tag - sis: check errors from tag creation - sis: move dmamem_alloc and dmamap_load to happen at same time as tag creation - sk: remove duplicate initialization of sk_dev - ste: add missed bus_generic_detach - ti: call ti_stop before ether_ifdetach - ti: add missed error setting in ti_rdata alloc failure - vr: add missed error setting in I/O, memory mapping cases - xl: add missed error setting in I/O, memory mapping cases - xl: remove multi-level goto on attach failure - xl: move dmamem_alloc and dmamap_load to happen at same time as tag creation - Calls to free(9) are unconditional because it is valid to call free with a null pointer. Reviewed by: imp, mdodd
Revision 1.96 / (download) - annotate - [select for diffs], Sat Mar 29 21:27:07 2003 UTC (8 years, 10 months ago) by silby
Branch: MAIN
Changes since 1.95: +30 -35
lines
Diff to previous 1.95 (colored)
Update if_dc to use m_defrag, removing the semi-duplicate dc_coal function. Also, use m_defrag where appropriate to defrag long mbuf chains in the same fashion as was done in if_sis.c. Before this change, if_dc would blow up and take down the interface if fed a really long mbuf chain. MFC after: 2 weeks
Revision 1.95 / (download) - annotate - [select for diffs], Fri Mar 21 17:53:16 2003 UTC (8 years, 10 months ago) by mdodd
Branch: MAIN
Changes since 1.94: +2 -2
lines
Diff to previous 1.94 (colored)
- Use if_broadcastaddr from struct ifnet rather than relying on extern 'etherbroadcastaddr'. - Make 'etherbroadcastaddr' static. Reviewed by: imp
Revision 1.9.2.41 / (download) - annotate - [select for diffs], Wed Mar 5 18:42:33 2003 UTC (8 years, 11 months ago) by njl
Branch: RELENG_4
CVS Tags: RELENG_4_8_BP,
RELENG_4_8_0_RELEASE,
RELENG_4_8
Changes since 1.9.2.40: +6 -0
lines
Diff to previous 1.9.2.40 (colored) to branchpoint 1.9 (colored)
Fix resource leaks where resources weren't freed in attach() failure. Also fix memory leaks in rl(4) and wb(4) in detach(). Since contigmalloc() is not used in -current, these exact bugs are not present there. Approved by: re (murray)
Revision 1.9.2.40 / (download) - annotate - [select for diffs], Fri Feb 21 22:12:20 2003 UTC (8 years, 11 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.39: +1 -1
lines
Diff to previous 1.9.2.39 (colored) to branchpoint 1.9 (colored)
Move free() to the right place. This solves some panics on Intel cards at init. Reviewed by: phk, bmah Approved by: re (jhb, bmah) Tested by: maxim, Mike Matsnev <mike@po.cs.msu.su>
Revision 1.94 / (download) - annotate - [select for diffs], Wed Feb 19 05:47:40 2003 UTC (8 years, 11 months ago) by imp
Branch: MAIN
Changes since 1.93: +4 -4
lines
Diff to previous 1.93 (colored)
Back out M_* changes, per decision of the TRB. Approved by: trb
Revision 1.9.2.39 / (download) - annotate - [select for diffs], Wed Feb 12 22:19:33 2003 UTC (8 years, 11 months ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.38: +127 -29
lines
Diff to previous 1.9.2.38 (colored) to branchpoint 1.9 (colored)
MFC Rev. 1.80, 1.81 Dynamically configure the width of the srom. This code comes from OpenBSD who got the code (or the idea) from the NetBSD tlp driver. MFC Rev. 1.67 Fix Conexant chips which always reports carrier lost on full duplex mode. Reviewed by: phk, imp
Revision 1.93 / (download) - annotate - [select for diffs], Wed Feb 12 07:16:15 2003 UTC (9 years ago) by imp
Branch: MAIN
Changes since 1.92: +1 -1
lines
Diff to previous 1.92 (colored)
Minor correction to comment: PNIC and XIRCOM have eeprom, its just non-standard.
Revision 1.92 / (download) - annotate - [select for diffs], Fri Feb 7 23:12:51 2003 UTC (9 years ago) by mbr
Branch: MAIN
Changes since 1.91: +5 -4
lines
Diff to previous 1.91 (colored)
Fix the breakage resulting from Rev. 1.80. Get the eeprom width for all but two cards. This should fix broken cards like these: DM9102 (Davicom, DEVICE_ID: 0x9002) DM9009 (Davicom, DEVICE_ID: 0x9009) DM9100 (Davicom, DEVICE_ID: 0x9100) 98713/98713_CP (Macronix PMAC, DEVICE_ID: 0x0512) 98713_CP (Macronix PMAC, DEVICE_ID: 0x0512) 987x5 (Macronix PMAC, DEVICE_ID: 0x0531) 98727 (Macronix PMAC, DEVICE_ID: 0x0532) 82C115 (Lite-On PNIC II, DEVICE_ID: 0xc115) AX88140A (ASIX Dev_ID: DEVICE_ID: 0x1400) EN1217 (Accton EN1217, DEVICE_ID: 0x1217) Note that these cards sould still work in STABLE. Reviewed by: imp
Revision 1.91 / (download) - annotate - [select for diffs], Fri Feb 7 13:55:02 2003 UTC (9 years ago) by mbr
Branch: MAIN
Changes since 1.90: +2 -1
lines
Diff to previous 1.90 (colored)
Add missing braces. Found by: FlexeLint (phk) Reviewed by: wpaul, phk
Revision 1.9.2.38 / (download) - annotate - [select for diffs], Wed Feb 5 22:10:04 2003 UTC (9 years ago) by mbr
Branch: RELENG_4
Changes since 1.9.2.37: +7 -0
lines
Diff to previous 1.9.2.37 (colored) to branchpoint 1.9 (colored)
MFC rev. 1.26 Enable the automatic TX underrun recovery for the ADMtek chips. PR: 34236 Reviewed by: phk
Revision 1.90 / (download) - annotate - [select for diffs], Wed Feb 5 21:21:26 2003 UTC (9 years ago) by mbr
Branch: MAIN
Changes since 1.89: +7 -3
lines
Diff to previous 1.89 (colored)
Move the DC_SETBIT to the attach function. Reviewed by: phk
Revision 1.89 / (download) - annotate - [select for diffs], Tue Jan 21 08:56:11 2003 UTC (9 years ago) by alfred
Branch: MAIN
Changes since 1.88: +4 -4
lines
Diff to previous 1.88 (colored)
Remove M_TRYWAIT/M_WAITOK/M_WAIT. Callers should use 0. Merge M_NOWAIT/M_DONTWAIT into a single flag M_NOWAIT.
Revision 1.88 / (download) - annotate - [select for diffs], Tue Jan 14 19:31:27 2003 UTC (9 years ago) by njl
Branch: MAIN
Changes since 1.87: +34 -42
lines
Diff to previous 1.87 (colored)
Remove bogus locking from dc(4). Instead, move interrupt allocation and ether_ifattach() to end. This fixes a "could sleep" case and simplifies error exit cases as well. Also be sure to set errno and clean up resources in !mac error case. Tested by: Ryan Beasley
Revision 1.9.2.37 / (download) - annotate - [select for diffs], Sat Jan 11 04:25:19 2003 UTC (9 years, 1 month ago) by trhodes
Branch: RELENG_4
Changes since 1.9.2.36: +3 -0
lines
Diff to previous 1.9.2.36 (colored) to branchpoint 1.9 (colored)
MFC: Add support for the Davicom DM9009 chipset. PR: 46859 Submitted by: Boaz Haberman <boaz@ool-182f8b09.dyn.optonline.net> Approved by: rwatson, imp
Revision 1.87 / (download) - annotate - [select for diffs], Fri Jan 10 05:37:15 2003 UTC (9 years, 1 month ago) by imp
Branch: MAIN
Changes since 1.86: +3 -0
lines
Diff to previous 1.86 (colored)
Add preliminary support for the Hawking PN672TX CardBus cards. # Preliminary because there are some subtle things the NetBSD driver does # that we don't do yet. My card works for me w/o them.
Revision 1.86 / (download) - annotate - [select for diffs], Thu Jan 9 20:51:39 2003 UTC (9 years, 1 month ago) by trhodes
Branch: MAIN
Changes since 1.85: +3 -0
lines
Diff to previous 1.85 (colored)
Add support for the Davicom DM9009 chipset. PR: 46859 Submitted by: Boaz Haberman <boaz@ool-182f8b09.dyn.optonline.net> Approved by: rwatson
Revision 1.9.2.36 / (download) - annotate - [select for diffs], Mon Dec 2 23:00:18 2002 UTC (9 years, 2 months ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.35: +6 -9
lines
Diff to previous 1.9.2.35 (colored) to branchpoint 1.9 (colored)
MFC: correct handling of IFF_ALLMULTI
Revision 1.85 / (download) - annotate - [select for diffs], Wed Nov 27 07:04:10 2002 UTC (9 years, 2 months ago) by imp
Branch: MAIN
CVS Tags: RELENG_5_0_BP,
RELENG_5_0_0_RELEASE,
RELENG_5_0
Changes since 1.84: +8 -2
lines
Diff to previous 1.84 (colored)
Xircom cards store the MAC address in the CIS, so get it from the new pci_get_ether accesor, which gets it from the CIS for cardbus cards (and from other pci-like buses via whatever mechanism is used there). Submitted by: sam Approved by: re (blanket)
Revision 1.84 / (download) - annotate - [select for diffs], Mon Nov 25 19:28:01 2002 UTC (9 years, 2 months ago) by luigi
Branch: MAIN
Changes since 1.83: +7 -9
lines
Diff to previous 1.83 (colored)
Fix handling of IFF_ALLMULTI. The same bug in various forms affects
the following drivers:
dc mn sf sk ste ti tl xl an bge em gem gx ie lge sr aue cue kue wi xe
Approved by: re
Revision 1.83 / (download) - annotate - [select for diffs], Thu Nov 14 23:49:08 2002 UTC (9 years, 2 months ago) by sam
Branch: MAIN
Changes since 1.82: +6 -16
lines
Diff to previous 1.82 (colored)
o track either_ifattach/ether_ifdetach API changes o use if_input for input packet processing o don't strip the Ethernet header for input packets o use BPF_* macros bpf tapping o call ether_ioctl to handle default ioctl case o track vlan changes Reviewed by: many Approved by: re
Revision 1.82 / (download) - annotate - [select for diffs], Wed Oct 16 09:04:52 2002 UTC (9 years, 3 months ago) by phk
Branch: MAIN
Changes since 1.81: +8 -6
lines
Diff to previous 1.81 (colored)
Be consistent about functions being static. Spotted by: FlexeLint.
Revision 1.81 / (download) - annotate - [select for diffs], Mon Oct 7 05:29:13 2002 UTC (9 years, 4 months ago) by imp
Branch: MAIN
Changes since 1.80: +1 -0
lines
Diff to previous 1.80 (colored)
Ooops. Need to free dc_srom on detach to not leak memory. Pointy Hat to: The Mad Redhead of Niwot
Revision 1.80 / (download) - annotate - [select for diffs], Mon Oct 7 05:26:35 2002 UTC (9 years, 4 months ago) by imp
Branch: MAIN
Changes since 1.79: +104 -14
lines
Diff to previous 1.79 (colored)
Dynamically configure the width of the srom. This code comes from OpenBSD who got the code (or the idea) from the NetBSD tlp driver. This gets some cardbus dc cards working (either completely or nearly so). It also appears to get additional pci cards working, without breaking working ones. # Maybe some additional work is needed here. Also, the cardbus attachment # might need to match on the CIS rather than on the vendor/device so we have # a finer level of detail as to what the card is. Technically, the # vendor/device fields are undefined for CardBus (even though most cards are # using common silicon with pci models).
Revision 1.79 / (download) - annotate - [select for diffs], Fri Sep 20 15:18:13 2002 UTC (9 years, 4 months ago) by mbr
Branch: MAIN
Changes since 1.78: +2 -1
lines
Diff to previous 1.78 (colored)
Fix the support for the AN985/983 chips, which do not set the RXSTATE to STOPPED, but to WAIT. This should fix hangs which could only be solved by replugging the cable. Submitted by: jhb Reviewed by: phk MFC after: 2 weeks
Revision 1.78 / (download) - annotate - [select for diffs], Fri Sep 20 15:16:06 2002 UTC (9 years, 4 months ago) by mbr
Branch: MAIN
Changes since 1.77: +3 -0
lines
Diff to previous 1.77 (colored)
Enable the automatic TX underrun recovery for the ADMtek chips. This solves cvsup update on my laptop which aborts after a while without this patch. PR: 34236 Reviewed by: phk MFC after: 2 weeks
Revision 1.77 / (download) - annotate - [select for diffs], Wed Sep 4 18:14:17 2002 UTC (9 years, 5 months ago) by markm
Branch: MAIN
Changes since 1.76: +21 -21
lines
Diff to previous 1.76 (colored)
Make consistent; turn spaces into tabs where there is a mixture.
Revision 1.76 / (download) - annotate - [select for diffs], Fri Aug 23 23:49:02 2002 UTC (9 years, 5 months ago) by alfred
Branch: MAIN
Changes since 1.75: +116 -58
lines
Diff to previous 1.75 (colored)
style: put return values on a line by themselves. fix some paste issues where whitespace was used instead of tabs.
Revision 1.75 / (download) - annotate - [select for diffs], Sun Aug 18 07:04:59 2002 UTC (9 years, 5 months ago) by sobomax
Branch: MAIN
Changes since 1.74: +3 -3
lines
Diff to previous 1.74 (colored)
Increase size of ifnet.if_flags from 16 bits (short) to 32 bits (int). To avoid breaking application ABI use unused ifreq.ifru_flags[1] for upper 16 bits in SIOCSIFFLAGS and SIOCGIFFLAGS ioctl's. Reviewed by: -hackers, -net
Revision 1.9.2.35 / (download) - annotate - [select for diffs], Fri Aug 16 04:45:38 2002 UTC (9 years, 5 months ago) by iwasaki
Branch: RELENG_4
CVS Tags: RELENG_4_7_BP,
RELENG_4_7_0_RELEASE,
RELENG_4_7
Changes since 1.9.2.34: +82 -0
lines
Diff to previous 1.9.2.34 (colored) to branchpoint 1.9 (colored)
MFC: Add suspend/resume code. if_dc.c 1.72 -> 1.73 if_dcreg.h 1.24 -> 1.25 I've forgotten this MFC for a long time.
Revision 1.9.2.34 / (download) - annotate - [select for diffs], Mon Jul 8 21:57:05 2002 UTC (9 years, 7 months ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.33: +5 -7
lines
Diff to previous 1.9.2.33 (colored) to branchpoint 1.9 (colored)
MFC 1.74: fix timeout logic Yet another RELENG_4_6 candidate (same problem as other net drivers)
Revision 1.74 / (download) - annotate - [select for diffs], Sun Jun 30 22:05:46 2002 UTC (9 years, 7 months ago) by luigi
Branch: MAIN
Changes since 1.73: +6 -6
lines
Diff to previous 1.73 (colored)
Fix if_timer logic to make sure that there is always a timeout pending if there are packets queued for transmission. MFC after: 3 days
Revision 1.73 / (download) - annotate - [select for diffs], Mon May 6 10:55:41 2002 UTC (9 years, 9 months ago) by iwasaki
Branch: MAIN
Changes since 1.72: +81 -0
lines
Diff to previous 1.72 (colored)
Add suspend/resume code mostly merged from fxp/rl driver. This is temporary hack, better and generalized solution probably should be implemented at lower layer(MII or PCI?). Tested by: shoko.araki@soliton.co.jp MFC after: 1 week
Revision 1.72 / (download) - annotate - [select for diffs], Fri May 3 08:44:53 2002 UTC (9 years, 9 months ago) by phk
Branch: MAIN
Changes since 1.71: +7 -6
lines
Diff to previous 1.71 (colored)
Don't grab the lock until somewhat later in attach to avoid a lock reversal.
Revision 1.71 / (download) - annotate - [select for diffs], Mon Apr 29 05:32:44 2002 UTC (9 years, 9 months ago) by phk
Branch: MAIN
Changes since 1.70: +6 -6
lines
Diff to previous 1.70 (colored)
Move us yet closer to IFM_* definitions in NetBSD.
Revision 1.70 / (download) - annotate - [select for diffs], Thu Apr 4 21:03:31 2002 UTC (9 years, 10 months ago) by jhb
Branch: MAIN
Changes since 1.69: +2 -1
lines
Diff to previous 1.69 (colored)
Change callers of mtx_init() to pass in an appropriate lock type name. In most cases NULL is passed, but in some cases such as network driver locks (which use the MTX_NETWORK_LOCK macro) and UMA zone locks, a name is used. Tested on: i386, alpha, sparc64
Revision 1.69 / (download) - annotate - [select for diffs], Wed Mar 20 02:07:59 2002 UTC (9 years, 10 months ago) by alfred
Branch: MAIN
Changes since 1.68: +62 -67
lines
Diff to previous 1.68 (colored)
Remove __P.
Revision 1.9.2.33 / (download) - annotate - [select for diffs], Tue Feb 26 04:21:30 2002 UTC (9 years, 11 months ago) by ambrisko
Branch: RELENG_4
CVS Tags: RELENG_4_6_BP,
RELENG_4_6_2_RELEASE,
RELENG_4_6_1_RELEASE,
RELENG_4_6_0_RELEASE,
RELENG_4_6
Changes since 1.9.2.32: +25 -12
lines
Diff to previous 1.9.2.32 (colored) to branchpoint 1.9 (colored)
MFC: vlan support. Approved by: imp
Revision 1.9.2.32 / (download) - annotate - [select for diffs], Sat Feb 9 23:02:40 2002 UTC (10 years ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.31: +83 -0
lines
Diff to previous 1.9.2.31 (colored) to branchpoint 1.9 (colored)
MFC: device polling code for RELENG_4. Most of the code resides in kern_poll.c, plus device driver modifications to individual drivers to add the *_poll() handler, plus mostly one-line changes to a bunch of other files (listed at the end of this message) to define constants or call the appropriate functions. A device_poll(4) manpage is still missing. It should contain an explaination of what DEVICE_POLLING does, which you can find at http://info.iet.unipi.it/~luigi/polling/ To use this facility: add options DEVICE_POLLING to your kernel config file, and at runtime do sysctl kern.polling.enable=1 At the moment only the "dc", "fxp" and "sis" drivers have been modified to make use of this feature. More drivers will be modified as i have a chance to test them (patches welcome, look at the changes in the above drivers). Work supported by: the Xorp Project (www.xorp.org) sys/kern/kern_poll.c the core of the polling procedures sys/conf/files.i386 kern/kern_poll.c optional device_polling sys/conf/options.i386 DEVICE_POLLING opt_global.h sys/i386/i386/swtch.s hook to poll in the idle loop sys/i386/i386/trap.c hook to poll in traps sys/i386/include/asnames.h #define _idle_poll idle_poll sys/kern/kern_clock.c calls to init and periodic poll handlers sys/net/if.h #define IFF_POLLING 0x10000 sys/net/if_var.h prototypes for functions used in device drivers sys/net/netisr.h NETISR_POLL and NETISR_POLLMORE, renumber NETISR_NETGRAPH (not objected by julian) sys/dev/fxp/if_fxp.c sys/dev/fxp/if_fxpvar.h sys/pci/if_dc.c sys/pci/if_dcreg.h sys/pci/if_sis.c sys/pci/if_sisreg.h device driver modifications
Revision 1.68 / (download) - annotate - [select for diffs], Wed Jan 16 16:33:58 2002 UTC (10 years ago) by ambrisko
Branch: MAIN
Changes since 1.67: +26 -12
lines
Diff to previous 1.67 (colored)
Add VLAN for the dc(4) driver (ie long frame). The patch is 2 parts. One to notify the system that the MTU for VLAN can be 1500 so the vlan will automatically be configured with a 1500 MTU the other is to ignore the error case if the received frame is to long. The frame size notification came from code in the SIS driver, and the support for long frames derived from the NetBSD Tulip driver. Tested on: 4 port D-Link adapter DFE-570TX 4 Intel 21143 Netgear card with 82c169 PNIC 10/100BaseTX Reviewed by: ru (manpage), wpaul (not objected to), archie Approved by: imp Obtained from: NetBSD
Revision 1.9.2.31 / (download) - annotate - [select for diffs], Wed Dec 19 18:37:34 2001 UTC (10 years, 1 month ago) by wpaul
Branch: RELENG_4
CVS Tags: RELENG_4_5_BP,
RELENG_4_5_0_RELEASE,
RELENG_4_5
Changes since 1.9.2.30: +41 -8
lines
Diff to previous 1.9.2.30 (colored) to branchpoint 1.9 (colored)
MFC: add (long overdue) support for the Conexant LANfinity chips, supplied by Phil Kernick, including the fix for full duplex mode.
Revision 1.67 / (download) - annotate - [select for diffs], Wed Dec 19 18:23:45 2001 UTC (10 years, 1 month ago) by wpaul
Branch: MAIN
Changes since 1.66: +8 -4
lines
Diff to previous 1.66 (colored)
Fix the "conexant chips don't work in full duplexmode" problem. According to Phil Kernick: "The problem is that in full duplex mode, the Conexant chip always reports a carrier lost error, even when the frame is successfully sent. So, if we have a Conexant chip, then ignore carrier lost when in full duplex mode." Since the Xircom chips seem to have the same issue and since we already have a workaround for this, just expand the workaround test to also check for DC_IS_CONEXANT().
Revision 1.66 / (download) - annotate - [select for diffs], Wed Dec 19 18:13:44 2001 UTC (10 years, 1 month ago) by wpaul
Branch: MAIN
Changes since 1.65: +3 -0
lines
Diff to previous 1.65 (colored)
Fix compiler warning in dc_intr(): if the only code that does a "goto" to a label is inside an #ifdef block, then the label should *also* be inside an #ifdef block. Hide the "done:" label which is only used if DEVICE_POLLING is enabled under #ifdef DEVICE_POLLING.
Revision 1.65 / (download) - annotate - [select for diffs], Sat Dec 15 02:51:21 2001 UTC (10 years, 1 month ago) by peter
Branch: MAIN
Changes since 1.64: +7 -7
lines
Diff to previous 1.64 (colored)
Patch up some existing style bugs and some that crept in with the DEVICE_POLLING stuff.
Revision 1.64 / (download) - annotate - [select for diffs], Fri Dec 14 17:56:12 2001 UTC (10 years, 1 month ago) by luigi
Branch: MAIN
Changes since 1.63: +83 -0
lines
Diff to previous 1.63 (colored)
Device Polling code for -current.
Non-SMP, i386-only, no polling in the idle loop at the moment.
To use this code you must compile a kernel with
options DEVICE_POLLING
and at runtime enable polling with
sysctl kern.polling.enable=1
The percentage of CPU reserved to userland can be set with
sysctl kern.polling.user_frac=NN (default is 50)
while the remainder is used by polling device drivers and netisr's.
These are the only two variables that you should need to touch. There
are a few more parameters in kern.polling but the default values
are adequate for all purposes. See the code in kern_poll.c for
more details on them.
Polling in the idle loop will be implemented shortly by introducing
a kernel thread which does the job. Until then, the amount of CPU
dedicated to polling will never exceed (100-user_frac).
The equivalent (actually, better) code for -stable is at
http://info.iet.unipi.it/~luigi/polling/
and also supports polling in the idle loop.
NOTE to Alpha developers:
There is really nothing in this code that is i386-specific.
If you move the 2 lines supporting the new option from
sys/conf/{files,options}.i386 to sys/conf/{files,options} I am
pretty sure that this should work on the Alpha as well, just that
I do not have a suitable test box to try it. If someone feels like
trying it, I would appreciate it.
NOTE to other developers:
sure some things could be done better, and as always I am open to
constructive criticism, which a few of you have already given and
I greatly appreciated.
However, before proposing radical architectural changes, please
take some time to possibly try out this code, or at the very least
read the comments in kern_poll.c, especially re. the reason why I
am using a soft netisr and cannot (I believe) replace it with a
simple timeout.
Quick description of files touched by this commit:
sys/conf/files.i386
new file kern/kern_poll.c
sys/conf/options.i386
new option
sys/i386/i386/trap.c
poll in trap (disabled by default)
sys/kern/kern_clock.c
initialization and hardclock hooks.
sys/kern/kern_intr.c
minor swi_net changes
sys/kern/kern_poll.c
the bulk of the code.
sys/net/if.h
new flag
sys/net/if_var.h
declaration for functions used in device drivers.
sys/net/netisr.h
NETISR_POLL
sys/dev/fxp/if_fxp.c
sys/dev/fxp/if_fxpvar.h
sys/pci/if_dc.c
sys/pci/if_dcreg.h
sys/pci/if_sis.c
sys/pci/if_sisreg.h
device driver modifications
Revision 1.9.2.30 / (download) - annotate - [select for diffs], Tue Dec 11 03:02:48 2001 UTC (10 years, 2 months ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.29: +3 -1
lines
Diff to previous 1.9.2.29 (colored) to branchpoint 1.9 (colored)
MFC (done now because the code is slightly different from the one in -current): avoid an unnecessary copy when the packet is already in a single buffer. With this one-line patch, a 750MHz box goes from 128kpps to 148kpps (full wire speed) even with NICs that require packets in a single mbuf. Trivia: the 21143, which can handle multiple buffers, seems to introduce extra delay between packets when they are split over multiple tx descriptors. So if you are in this situation and have CPU cycles to burn, doing the copy is the only way to achieve wire speed (short of arranging tx descriptors as an array instead of a linked list).
Revision 1.63 / (download) - annotate - [select for diffs], Tue Dec 11 02:47:53 2001 UTC (10 years, 2 months ago) by luigi
Branch: MAIN
Changes since 1.62: +6 -2
lines
Diff to previous 1.62 (colored)
Avoid an unnecessary copy of a packet if it is already in a single mbuf. Introduce an additional device flag for those NICs which require the transmit buffers to be aligned to 32-bit boundaries. (the equivalen fix for STABLE is slightly simpler because there are no supported chips which require this alignment there.)
Revision 1.9.2.29 / (download) - annotate - [select for diffs], Sat Dec 8 00:04:15 2001 UTC (10 years, 2 months ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.28: +0 -81
lines
Diff to previous 1.9.2.28 (colored) to branchpoint 1.9 (colored)
By loud (and maybe popular) demand, back out the device polling code, so we will not risk to lose this feature when -current is released, we lose it now. For those interested, the full story is archived in tne cvs-all and freebsd-net mailing lists, and maybe in some future core monthly report.
Revision 1.62 / (download) - annotate - [select for diffs], Fri Dec 7 00:57:57 2001 UTC (10 years, 2 months ago) by peter
Branch: MAIN
Changes since 1.61: +2 -2
lines
Diff to previous 1.61 (colored)
MFS (merge from stable): rev 1.9.2.28, fix ordering of IFF_RUNNING mods. The reason we are required to commit to -current first is so that later MFC's do not risk the loss of existing bug fixes. Even if this was not strictly required in -current, it should still be fixed there too.
Revision 1.9.2.28 / (download) - annotate - [select for diffs], Wed Dec 5 22:52:36 2001 UTC (10 years, 2 months ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.27: +2 -2
lines
Diff to previous 1.9.2.27 (colored) to branchpoint 1.9 (colored)
Move the clearing of IFF_RUNNING early in *_stop(), before actually freeing resources (IFF_RUNNING means resources _are_ allocated). Because *_stop() is not protected by splimp(), and it is not always called at splimp() (e.g. from *_shutdown()), the old code could potentially cause a panic at shutdown in the very rare case you get an interrupt from a device sharing the same IRQ line in the middle of *_stop(). With polling enabled, this "rare" case become slightly more frequent because clock interrupts can also hit you in the middle of *_stop(). Note that this was a bug in the original drivers, not in the polling code. Note also that some other drivers (not all) have a similar bug. The code in CURRENT seems to be safe because *_stop() is wrapped in LOCK/UNLOCK calls. Maybe it would be more robust to use splimp() around *_stop() as well.
Revision 1.9.2.27 / (download) - annotate - [select for diffs], Wed Dec 5 01:45:46 2001 UTC (10 years, 2 months ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.26: +10 -0
lines
Diff to previous 1.9.2.26 (colored) to branchpoint 1.9 (colored)
Make sure interrupts remain disabled once you reinitialize an interface on which you have enabled polling. This fixes the problem reported by a few people who enabled polling from /etc/sysctl.conf . Fixing the "fxp" driver was interesting: as a side effect of the initialization, the chip turns interrupts on, and I was misled in believing the opposite by the "Enable interrupts" comment in the code. So i decided to make the code explicitly turn interrupts off even in the "sis" driver which already had the correct code. You never know. Note-to-self: never make assumptions on how things should work. Note-to-others: did I test this case ? Yes, on a "sis" and "dc" board, (the code for the latter was unintentionally lost during the final code cleanup). I forgot to reproduce the actual problem on the "fxp", because the interface was already initialized when i turned polling on.
Revision 1.9.2.26 / (download) - annotate - [select for diffs], Tue Dec 4 08:07:03 2001 UTC (10 years, 2 months ago) by peter
Branch: RELENG_4
Changes since 1.9.2.25: +5 -6
lines
Diff to previous 1.9.2.25 (colored) to branchpoint 1.9 (colored)
Fix some blatent style transgressions in the DEVICE_POLLING code.
Revision 1.9.2.25 / (download) - annotate - [select for diffs], Tue Dec 4 05:57:45 2001 UTC (10 years, 2 months ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.24: +72 -0
lines
Diff to previous 1.9.2.24 (colored) to branchpoint 1.9 (colored)
As approved by the Release Engineer, here comes the code for polling
in network device drivers (x86, non-SMP only at the moment, for
reasons that I have extensively explained on the -net mailing list).
This code lets network devices operate in a semi-polling mode,
which makes systems much more resilient to attacks and overloads.
If you don't enable it with an appropriate kernel option, your
kernel will be exactly the same as before this commit. No userland
code is affected.
To use polling you have to put the following options in your kernel
config file:
options DEVICE_POLLING
options HZ=1000 # not compulsory but strongly recommended
and enable it at runtime as follows (by default it is disabled):
sysctl kern.polling.enable=1
There are basically no other tunables related to this code,
though you might have a look at "sysctl kern.polling" to see
what other variables are there.
The device drivers supported at the moment are "dc", "fxp" and
"sis", with more to come (but this code only makes sense for 100M
and Gigabit devices). Unmodified drivers will continue to operate
as before.
Under little or moderate load you should see no difference in the
behaviour of your system. Under load, you should experience a
moderate improvement in peak performance, and a lot more stability
and responsiveness.
A quick description of the files affected (all in sys/)
conf/options.i386
DEVICE_POLLING option
i386/i386/swtch.s i386/i386/trap.c
hooks to call the polling code
net/if.h net/netisr.h sys/systm.h i386/include/asnames.h
misc. constants and variable definitions (mostly one-liner).
kern/kern_clock.c
The bulk of the polling code. Probably this code will be moved to a
separate file once equivalent functionality is added to -current.
dev/fxp/if_fxp.c pci/if_dc.c pci/if_dcreg.h pci/if_sis.c pci/if_sisreg.h
device driver modifications
Reviewed-by: -net
Approved by: jkh
Revision 1.9.2.24 / (download) - annotate - [select for diffs], Tue Dec 4 02:35:52 2001 UTC (10 years, 2 months ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.23: +39 -22
lines
Diff to previous 1.9.2.23 (colored) to branchpoint 1.9 (colored)
MFC: remove one useless copy on i386 architecture for incoming packets, see discussion in the HEAD commit for the same files. The old behaviour can be restored using the hw.dc_quick and hw.sis_quick sysctl variables. Also remove printf()s upon mbuf allocation failures, now that this is handled more safely in kern/uipc_mbuf.c
Revision 1.61 / (download) - annotate - [select for diffs], Tue Dec 4 02:30:53 2001 UTC (10 years, 2 months ago) by luigi
Branch: MAIN
Changes since 1.60: +2 -10
lines
Diff to previous 1.60 (colored)
Remove error messages on mbuf allocation failures, now this is done more safely in kern/subr_mbuf.c Two-days'-delay-thanks-to: @home shutting down service
Revision 1.60 / (download) - annotate - [select for diffs], Thu Nov 29 23:47:47 2001 UTC (10 years, 2 months ago) by luigi
Branch: MAIN
Changes since 1.59: +8 -3
lines
Diff to previous 1.59 (colored)
Per jlemon request, reintroduce some printf() when an mbuf allocation fails, and fix (i hope) a couple of style bugs. I believe these printf() are extremely dangerous because now they can occur on every incoming packet and are not rate limited. They were meant to warn the sysadmin about lack of resources, but now they can become a nice way to panic your system under load. Other drivers (e.g. the fxp driver) have nothing like this. There is a pending discussion on putting this kind of warnings elsewhere, and I hope we can fix this soon.
Revision 1.59 / (download) - annotate - [select for diffs], Thu Nov 29 22:46:48 2001 UTC (10 years, 2 months ago) by luigi
Branch: MAIN
Changes since 1.58: +40 -31
lines
Diff to previous 1.58 (colored)
For i386 architecture, remove an expensive m_devget() (and the underlying unaligned bcopy) on incoming packets that are already available (albeit unaligned) in a buffer. The performance improvement varies, depending on CPU and memory speed, but can be quite large especially on slow CPUs. I have seen over 50% increase on forwarding speed on the sis driver for the 486/133 (embedded systems), which does exactly the same thing. The behaviour is controlled by a sysctl variable, hw.dc_quick which defaults to 1. Set it to 0 to restore the old behaviour. After running a few experiments (in userland, though) I am convinced that doing the m_devget() is detrimental to performance in almost all cases. Even if your CPU has degraded performance with misaligned data, the bcopy() in the driver has the same overhead due to misaligment as the one that you save in the uiomove(), plus you do one extra copy and pollute the cache. But more often than not, you do not even have to touch the payload, e.g. when you are forwarding packets, and even in the often-cited case of NFS, you often end up passing a pointer to the payload to the disk controller. In any case, you can play with the sysctl variable to toggle between the two behaviours, and see if it makes a difference. MFC-after: 3 days
Revision 1.58 / (download) - annotate - [select for diffs], Wed Nov 14 18:36:37 2001 UTC (10 years, 2 months ago) by jhb
Branch: MAIN
Changes since 1.57: +0 -1
lines
Diff to previous 1.57 (colored)
Remove ifnet.if_mpsafe for now. If this is needed, it won't be needed until much later when the network stack locking is farther along. Approved by: jlemon
Revision 1.9.2.23 / (download) - annotate - [select for diffs], Sun Oct 28 17:23:24 2001 UTC (10 years, 3 months ago) by luigi
Branch: RELENG_4
Changes since 1.9.2.22: +7 -2
lines
Diff to previous 1.9.2.22 (colored) to branchpoint 1.9 (colored)
MFC: enable round robin arbitration in the 21143 between receive and
transmit DMA engines.
Revision 1.57 / (download) - annotate - [select for diffs], Sat Oct 27 00:59:17 2001 UTC (10 years, 3 months ago) by luigi
Branch: MAIN
Changes since 1.56: +7 -2
lines
Diff to previous 1.56 (colored)
Enable round-robin arbitration between transmit and receive unit in the 21143, instead of giving priority to the receive unit. This gives a 10-15% performance improvement in the forwarding rate under heavy load. Reviewed-by: Bill Paul
Revision 1.56 / (download) - annotate - [select for diffs], Sat Sep 29 19:28:31 2001 UTC (10 years, 4 months ago) by jlemon
Branch: MAIN
Changes since 1.55: +7 -10
lines
Diff to previous 1.55 (colored)
Do not call mii_pollstat() from within device tick routines; the status information is updated by mii_tick(). Pointed out by: wpaul (a while back)
Revision 1.55 / (download) - annotate - [select for diffs], Tue Sep 4 17:10:11 2001 UTC (10 years, 5 months ago) by wpaul
Branch: MAIN
CVS Tags: KSE_PRE_MILESTONE_2,
KSE_MILESTONE_2
Changes since 1.54: +29 -5
lines
Diff to previous 1.54 (colored)
Add support for Conexant LANfinity miniPCI controllers. People who have laptops with this chip should test this and report back as I don't have access to this hardware myself. People with -stable systems should try the patch at: http://www.freebsd.org/~wpaul/conexant.patch.gz Submitted by: Phil Kernick <Phil@Kernick.org>
Revision 1.9.2.22 / (download) - annotate - [select for diffs], Fri Jul 20 02:01:26 2001 UTC (10 years, 6 months ago) by brooks
Branch: RELENG_4
CVS Tags: RELENG_4_4_BP,
RELENG_4_4_0_RELEASE,
RELENG_4_4
Changes since 1.9.2.21: +3 -3
lines
Diff to previous 1.9.2.21 (colored) to branchpoint 1.9 (colored)
Upbreak the kernel by removing bogus '{'.
Revision 1.9.2.21 / (download) - annotate - [select for diffs], Thu Jul 19 18:26:15 2001 UTC (10 years, 6 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.20: +3 -3
lines
Diff to previous 1.9.2.20 (colored) to branchpoint 1.9 (colored)
MFC: try to drain send queue if we lose link during heavy transmit activity instead of letting it sit and return 'no buffer available' errors.
Revision 1.54 / (download) - annotate - [select for diffs], Thu Jul 12 22:51:59 2001 UTC (10 years, 7 months ago) by wpaul
Branch: MAIN
Changes since 1.53: +3 -3
lines
Diff to previous 1.53 (colored)
Deal with the condition where we lose link in the middle of transmitting a bunch of frames. In this case, the dc_link flag is cleared, and dc_start() stops draining the if_snd send queue, which results in lots of 'no buffers available' errors being reported to applications. The whole idea behind not draining the send queue until the link comes up was to avoid having the gratuitous ARP being lost while we're waiting for autoneg to complete after the interface is first brought up. As an optimization, change the test in dc_start() so that we only bail if dc_link is not set _and_ there are less than 10 packets in the send queue. If the queue has many frames in it, we need to drain them. If the queue has a small number of frames in it, we can hold off on sending them until the link comes up. MFC after: 1 week
Revision 1.53 / (download) - annotate - [select for diffs], Mon Jul 9 17:58:36 2001 UTC (10 years, 7 months ago) by wpaul
Branch: MAIN
Changes since 1.52: +4 -4
lines
Diff to previous 1.52 (colored)
Apply patch supplied by Jonathan Chen: use the correct arguments to pci_enable_io(). We need to use SYS_RES_IOPORT/SYS_RES_MEMORY instead of PCIM_CMD_PORTEN/PCIM_CMD_MEMEN.
Revision 1.52 / (download) - annotate - [select for diffs], Wed Jun 20 19:48:34 2001 UTC (10 years, 7 months ago) by bmilekic
Branch: MAIN
Changes since 1.51: +4 -5
lines
Diff to previous 1.51 (colored)
Change m_devget()'s outdated and unused `offset' argument to actually mean something: offset into the first mbuf of the target chain before copying the source data over. Make drivers using m_devget() with a first argument "data - ETHER_ALIGN" to use the offset argument to pass ETHER_ALIGN in. The way it was previously done is potentially dangerous if the source data was at the top of a page and the offset caused the previous page to be copied (if the previous page has not yet been appropriately mapped). The old `offset' argument in m_devget() is not used anywhere (it's always 0) and dates back to ~1995 (and earlier?) when support for ethernet trailers existed. With that support gone, it was merely collecting dust. Tested on alpha by: jlemon Partially submitted by: jlemon Reviewed by: jlemon MFC after: 3 weeks
Revision 1.9.2.20 / (download) - annotate - [select for diffs], Tue Mar 20 22:38:29 2001 UTC (10 years, 10 months ago) by mckay
Branch: RELENG_4
CVS Tags: RELENG_4_3_BP,
RELENG_4_3_0_RELEASE,
RELENG_4_3
Changes since 1.9.2.19: +3 -3
lines
Diff to previous 1.9.2.19 (colored) to branchpoint 1.9 (colored)
Revert part of the 1.51 merge. What looked like an obvious fix to an obvious bug turned out to have ill effects on PNIC and Davicom cards. A better fix will appear eventually, after more analysis.
Revision 1.9.2.19 / (download) - annotate - [select for diffs], Mon Mar 5 13:50:00 2001 UTC (10 years, 11 months ago) by mckay
Branch: RELENG_4
Changes since 1.9.2.18: +9 -3
lines
Diff to previous 1.9.2.18 (colored) to branchpoint 1.9 (colored)
MFC (revs 1.47 to 1.49): Return quickly from dc_intr if there is nothing to do, plus a spelling fix. Also add a redundant "return" I forgot to bring over with the previous MFC.
Revision 1.9.2.18 / (download) - annotate - [select for diffs], Mon Mar 5 04:17:24 2001 UTC (10 years, 11 months ago) by mckay
Branch: RELENG_4
Changes since 1.9.2.17: +58 -28
lines
Diff to previous 1.9.2.17 (colored) to branchpoint 1.9 (colored)
MFC (if_dcreg.h 1.19, if_dc.c 1.51): Faster recovery from underruns.
Revision 1.51 / (download) - annotate - [select for diffs], Thu Feb 22 19:26:55 2001 UTC (10 years, 11 months ago) by wpaul
Branch: MAIN
Changes since 1.50: +60 -28
lines
Diff to previous 1.50 (colored)
Apply patch to allow TX underrun handling without issuing a complete chip reset. Just temporarily turn off the transmitter instead. Submitted by: Stephen McKay <mckay@freebsd.org>
Revision 1.50 / (download) - annotate - [select for diffs], Wed Feb 21 20:54:21 2001 UTC (10 years, 11 months ago) by wpaul
Branch: MAIN
Changes since 1.49: +5 -5
lines
Diff to previous 1.49 (colored)
Big round of minor updates: - Use pci_get_powerstate()/pci_set_powerstate() in all the other drivers that need them so we don't have to fiddle with the PCI power management registers directly. - Use pci_enable_busmaster()/pci_enable_io() to turn on busmastering and PIO/memory mapped accesses. - Add support to the RealTek driver for the D-Link DFE-530TX+ which has a RealTek 8139 with its own PCI ID. (Submitted by Jason Wright) - Have the SiS 900/National DP83815 driver be sure to disable PME mode in sis_reset(). This apparently fixes a problem on some motherboards where the DP83815 chip fails to receive packets. (Submitted by Chuck McCrobie <mccrobie@cablespeed.com>)
Revision 1.49 / (download) - annotate - [select for diffs], Tue Feb 20 04:43:59 2001 UTC (10 years, 11 months ago) by imp
Branch: MAIN
Changes since 1.48: +6 -7
lines
Diff to previous 1.48 (colored)
Take luigi's suggestion and move the check for nothing to do to before the lock so we don't have lots of null lock/release pairs.
Revision 1.48 / (download) - annotate - [select for diffs], Tue Feb 20 04:21:27 2001 UTC (10 years, 11 months ago) by imp
Branch: MAIN
Changes since 1.47: +5 -3
lines
Diff to previous 1.47 (colored)
Add DC_UNLOCK before first return. This caused returns when dc was on a shared interrupt. Pointed out by tegge.
Revision 1.47 / (download) - annotate - [select for diffs], Sun Feb 18 07:21:28 2001 UTC (10 years, 11 months ago) by luigi
Branch: MAIN
Changes since 1.46: +6 -3
lines
Diff to previous 1.46 (colored)
Add a check in the interrupt service routine to return quickly in case there is nothing to do. This happens normally when the card shares the interrupt line with other devices. This code saves a couple of microseconds per interrupt even on a fast CPU. You normally would not care, except under heavy tinygram traffic where you can have some 50-100.000 interrupts per second... On passing, correct a spelling error.
Revision 1.46 / (download) - annotate - [select for diffs], Tue Feb 6 10:11:43 2001 UTC (11 years ago) by phk
Branch: MAIN
Changes since 1.45: +6 -6
lines
Diff to previous 1.45 (colored)
Convert if_multiaddrs from LIST to TAILQ so that it can be traversed backwards in the three drivers which want to do that. Reviewed by: mikeh
Revision 1.45 / (download) - annotate - [select for diffs], Sat Feb 3 16:29:10 2001 UTC (11 years ago) by phk
Branch: MAIN
Changes since 1.44: +6 -10
lines
Diff to previous 1.44 (colored)
Use LIST_FOREACH() to traverse ifp->if_multiaddrs list, instead of <sys/queue.h> implementation details. Created with: /usr/sbin/sed Reviewed with: /sbin/md5
Revision 1.9.2.17 / (download) - annotate - [select for diffs], Mon Jan 22 19:13:16 2001 UTC (11 years ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.16: +16 -10
lines
Diff to previous 1.9.2.16 (colored) to branchpoint 1.9 (colored)
MFC: merge in bug fixes
if_dc: conditionalize code for MX98713 so that it doesn't screw up
other chips
if_sf & if_vr: check & handle return values from encap routines correctly
Revision 1.44 / (download) - annotate - [select for diffs], Sat Jan 20 00:07:49 2001 UTC (11 years ago) by wpaul
Branch: MAIN
Changes since 1.43: +4 -4
lines
Diff to previous 1.43 (colored)
Silence compiler warnings.
Revision 1.43 / (download) - annotate - [select for diffs], Fri Jan 19 23:55:07 2001 UTC (11 years ago) by wpaul
Branch: MAIN
Changes since 1.42: +14 -8
lines
Diff to previous 1.42 (colored)
Bug fixes that I've put together while working on a project in the office:
if_vr: handle the case where vr_encap() returns failure: bust out of the
packet sending loop instead of panicking. Also add some missing
newlines to some printf()s.
if_dc: The miibus_read and miibus_write methods keep swapping in and
out of MII mode by fiddling with CSR6 for cards with MII PHYs.
This is a hack to support the original Macronix 98713 card which
has built-in NWAY that uses an MII-like management interface
even though it uses serial transceivers. Conditionalize this
so that we only do this on 98713 chips, since it does bad things
to genuine tulip chips (and maybe other clones).
Revision 1.42 / (download) - annotate - [select for diffs], Fri Jan 19 01:59:09 2001 UTC (11 years ago) by bmilekic
Branch: MAIN
Changes since 1.41: +3 -3
lines
Diff to previous 1.41 (colored)
Implement MTX_RECURSE flag for mtx_init(). All calls to mtx_init() for mutexes that recurse must now include the MTX_RECURSE bit in the flag argument variable. This change is in preparation for an upcoming (further) mutex API cleanup. The witness code will call panic() if a lock is found to recurse but the MTX_RECURSE bit was not set during the lock's initialization. The old MTX_RECURSE "state" bit (in mtx_lock) has been renamed to MTX_RECURSED, which is more appropriate given its meaning. The following locks have been made "recursive," thus far: eventhandler, Giant, callout, sched_lock, possibly some others declared in the architecture-specific code, all of the network card driver locks in pci/, as well as some other locks in dev/ stuff that I've found to be recursive. Reviewed by: jhb
Revision 1.41 / (download) - annotate - [select for diffs], Mon Dec 18 21:53:05 2000 UTC (11 years, 1 month ago) by wpaul
Branch: MAIN
Changes since 1.40: +20 -28
lines
Diff to previous 1.40 (colored)
Use pci_get_powerstate()/pci_set_powerstate() which now exists in the PCI code. This saves each driver from having to grovel around looking for the right registers to twiddle. I should eventually convert the other PCI drivers to do this; for now, these three are ones which I know need power state handling.
Revision 1.40 / (download) - annotate - [select for diffs], Mon Dec 4 22:46:50 2000 UTC (11 years, 2 months ago) by wpaul
Branch: MAIN
Changes since 1.39: +5 -4
lines
Diff to previous 1.39 (colored)
Initialize/grab the mutex earlier in the attach phase, so that bailing out to the fail: label where we release/destroy the mutex will work without exploding.
Revision 1.9.2.16 / (download) - annotate - [select for diffs], Fri Dec 1 05:43:24 2000 UTC (11 years, 2 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.15: +5 -2
lines
Diff to previous 1.9.2.15 (colored) to branchpoint 1.9 (colored)
MFC: add support for the Accton 2242 MiniPCI adapter to the dc driver. This just involves adding a new PCI ID.
Revision 1.39 / (download) - annotate - [select for diffs], Sat Nov 25 08:00:10 2000 UTC (11 years, 2 months ago) by jlemon
Branch: MAIN
Changes since 1.38: +13 -9
lines
Diff to previous 1.38 (colored)
Change the driver to allocate its own callout structure, and modify the interface to use callout_* instead of timeout(). Also add an IS_MPSAFE #define (currently off) which will mark the driver as mpsafe to the upper layers.
Revision 1.38 / (download) - annotate - [select for diffs], Tue Nov 14 19:35:22 2000 UTC (11 years, 2 months ago) by wpaul
Branch: MAIN
Changes since 1.37: +5 -2
lines
Diff to previous 1.37 (colored)
Add support for the Accton EN2242 MiniPCI adapter. This is just an ADMtek Centaur chip, so all we need is the PCI ID. Submitted by: Scott Lang <scottl@FreeBSD.org>
Revision 1.9.2.15 / (download) - annotate - [select for diffs], Fri Nov 3 05:53:28 2000 UTC (11 years, 3 months ago) by wpaul
Branch: RELENG_4
CVS Tags: RELENG_4_2_0_RELEASE
Changes since 1.9.2.14: +5 -2
lines
Diff to previous 1.9.2.14 (colored) to branchpoint 1.9 (colored)
MFC: two ethernet driver fixes. Remember to bzero() mediainfo structs in if_dc.c and tweak broadcast packet reception in if_pcn.c Approved by: jkh
Revision 1.37 / (download) - annotate - [select for diffs], Fri Nov 3 00:03:03 2000 UTC (11 years, 3 months ago) by wpaul
Branch: MAIN
Changes since 1.36: +5 -2
lines
Diff to previous 1.36 (colored)
Grrrr. Remember to bzero() the mediainfo structures after we allocate them. If we leave garbage in them, the dc_apply_fixup() routine may try to follow bogus pointers when applying the reset fixup. Noticed by: Andrew Gallatin
Revision 1.9.2.14 / (download) - annotate - [select for diffs], Tue Oct 31 00:09:30 2000 UTC (11 years, 3 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.13: +6 -2
lines
Diff to previous 1.9.2.13 (colored) to branchpoint 1.9 (colored)
MFC: call dc_apply_fixup() in dc_setcfg() for MII case.
Revision 1.36 / (download) - annotate - [select for diffs], Tue Oct 31 00:06:39 2000 UTC (11 years, 3 months ago) by wpaul
Branch: MAIN
Changes since 1.35: +6 -2
lines
Diff to previous 1.35 (colored)
Call dc_apply_fixup() in dc_setcfg() for the MII case.
Revision 1.9.2.13 / (download) - annotate - [select for diffs], Mon Oct 30 23:52:39 2000 UTC (11 years, 3 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.12: +3 -3
lines
Diff to previous 1.9.2.12 (colored) to branchpoint 1.9 (colored)
MFC: fix reg variable in dc_apply_fixup() to be correct type.
Revision 1.35 / (download) - annotate - [select for diffs], Mon Oct 30 23:51:39 2000 UTC (11 years, 3 months ago) by wpaul
Branch: MAIN
Changes since 1.34: +3 -3
lines
Diff to previous 1.34 (colored)
Grrr. The 'reg' variable in dc_apply_fixup() needs to be a u_int32_t, not a u_int8_t. Pass the conical hat. This should fix certain cardbus 21143 cards that require SROM h0h0magic in order to enable their transceivers.
Revision 1.34 / (download) - annotate - [select for diffs], Sat Oct 28 10:03:54 2000 UTC (11 years, 3 months ago) by peter
Branch: MAIN
Changes since 1.33: +3 -3
lines
Diff to previous 1.33 (colored)
Fix typo s/DE_DEVICEID_FE2500/DC_DEVICEID_FE2500/
Revision 1.33 / (download) - annotate - [select for diffs], Sat Oct 28 09:00:19 2000 UTC (11 years, 3 months ago) by wpaul
Branch: MAIN
Changes since 1.32: +10 -4
lines
Diff to previous 1.32 (colored)
Add PCI IDs for some additional cardbus cards. Yes, there really is a RealTek 8139 cardbus device. Unfortunately it doesn't quite work yet because the CIS parser barfs on it. Submitted by msmith, with some small tweaks by me.
Revision 1.9.2.12 / (download) - annotate - [select for diffs], Fri Oct 27 01:13:19 2000 UTC (11 years, 3 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.11: +9 -4
lines
Diff to previous 1.9.2.11 (colored) to branchpoint 1.9 (colored)
MFC: merge in Davicom fixes from -current. I think there's still a problem somewhere, but this does fix a couple of bugs that need to be addressed.
Revision 1.32 / (download) - annotate - [select for diffs], Fri Oct 27 00:15:04 2000 UTC (11 years, 3 months ago) by wpaul
Branch: MAIN
Changes since 1.31: +7 -2
lines
Diff to previous 1.31 (colored)
Yet another bug fix/optimization for the Davicom DM9100/9102: increase the PCI latency timer value to 0x80. Davicom's Linux driver does this, and it drastically reduces the number of TX underruns in my tests. (Note: this is done only for the Davicom chips. I'm not sure it's a good idea to do it for all of them.) Again, still waiting on confirmation before merging to stable.
Revision 1.31 / (download) - annotate - [select for diffs], Wed Oct 25 23:46:31 2000 UTC (11 years, 3 months ago) by wpaul
Branch: MAIN
Changes since 1.30: +4 -4
lines
Diff to previous 1.30 (colored)
Set the DC_TX_INTR_ALWAYS and DC_TX_STORENFWD flags for the Davicom DM9100/DM9102 chips. Do not set DC_TX_ONE. The DC_TX_USE_TX_INTR flag causes dc_encap() to set the 'interrupt on TX completion' bit only once every 64 packets. This is an attempt to reduce the number of interrupts generated by the chip. You're supposed to get a 'no more TX buffers left' interrupt once you hit the last packet whether you ask for one or not, however it seems the Davicom chip doesn't generate this interrupt, or at least it doesn't generate it under the same circumstances. The result is that if you transmit n packets, where n is less than 64, and then wait 5 seconds, you'll get a watchdog timeout whether you want one or not. The DC_TX_INTR_ALWAYS causes dc_encap() to request an interrupt for every frame. I'm still waiting on confirmation from a couple of users to see if this fixes their problems with the Davicom DM9102 before I merge this into -stable, but this fixed the problem for me in my own testing so I'm willing to make the change to -current right away.
Revision 1.30 / (download) - annotate - [select for diffs], Fri Oct 20 07:54:21 2000 UTC (11 years, 3 months ago) by jhb
Branch: MAIN
Changes since 1.29: +2 -3
lines
Diff to previous 1.29 (colored)
Remove unnecessary machine/mutex.h include.
Revision 1.29 / (download) - annotate - [select for diffs], Thu Oct 19 08:34:29 2000 UTC (11 years, 3 months ago) by jon
Branch: MAIN
Changes since 1.28: +176 -11
lines
Diff to previous 1.28 (colored)
NEWCARD/Cardbus - This commit adds support for Xircom X3201 based cardbus cards. Support for the TDK 78Q2120 MII is also added. IBM Etherjet, Intel and Xircom cards uses these chips. Note that as a result of this commit, some Intel/DEC 21143 based cardbus cards will also attach, but not get link. That is being looked at.
Revision 1.28 / (download) - annotate - [select for diffs], Sun Oct 15 14:18:58 2000 UTC (11 years, 3 months ago) by phk
Branch: MAIN
Changes since 1.27: +2 -3
lines
Diff to previous 1.27 (colored)
Remove unneeded #include <machine/clock.h>
Revision 1.9.2.11 / (download) - annotate - [select for diffs], Sat Oct 14 00:44:39 2000 UTC (11 years, 4 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.10: +233 -62
lines
Diff to previous 1.9.2.10 (colored) to branchpoint 1.9 (colored)
MFC: bring in the SROM reading code for the alpha Miatas and friends.
Revision 1.27 / (download) - annotate - [select for diffs], Sat Oct 14 00:40:14 2000 UTC (11 years, 4 months ago) by wpaul
Branch: MAIN
Changes since 1.26: +11 -6
lines
Diff to previous 1.26 (colored)
Clean up a few things in dc_setcfg() pointed out to be me by aaron@openbsd.com on IRC earlier today.
Revision 1.26 / (download) - annotate - [select for diffs], Fri Oct 13 18:35:49 2000 UTC (11 years, 4 months ago) by wpaul
Branch: MAIN
Changes since 1.25: +3 -3
lines
Diff to previous 1.25 (colored)
Use device_get_nameunit(dev) as the mutex string when calling mtx_init() instead of hard-coded string constant. Also remember to do the mutex changes to the ste driver, which I forgot in the first commit.
Revision 1.25 / (download) - annotate - [select for diffs], Fri Oct 13 17:54:17 2000 UTC (11 years, 4 months ago) by wpaul
Branch: MAIN
Changes since 1.24: +51 -33
lines
Diff to previous 1.24 (colored)
First round of converting network drivers from spls to mutexes. This takes care of all the 10/100 and gigE PCI drivers that I've done. Next will be the wireless drivers, then the USB ones. I may pick up some stragglers along the way. I'm sort of playing this by ear: if anyone spots any places where I've screwed up horribly, please let me know.
Revision 1.24 / (download) - annotate - [select for diffs], Thu Oct 5 17:36:14 2000 UTC (11 years, 4 months ago) by wpaul
Branch: MAIN
Changes since 1.23: +224 -58
lines
Diff to previous 1.23 (colored)
Add support for parsing the media blocks from the SROM on 21143 adapters. This is necessary in order to make this driver work with the built-in ethernet on the alpha Miata machines. These systems have a 21143-PC chip on-board and optional daughtercards with either a 10/100 MII transceiver or a 10baseT/10base2 transceiver. In both cases, you need to twiddle the GPIO bits on the controller in order to turn the transceivers on, and you have to read the media info from the SROM in order to find out what bits to twiddle.
Revision 1.9.2.10 / (download) - annotate - [select for diffs], Thu Sep 21 20:33:42 2000 UTC (11 years, 4 months ago) by wpaul
Branch: RELENG_4
CVS Tags: RELENG_4_1_1_RELEASE
Changes since 1.9.2.9: +11 -6
lines
Diff to previous 1.9.2.9 (colored) to branchpoint 1.9 (colored)
MFC: merge in HomePNA PHY fix.
Revision 1.23 / (download) - annotate - [select for diffs], Wed Sep 20 00:59:17 2000 UTC (11 years, 4 months ago) by wpaul
Branch: MAIN
Changes since 1.22: +11 -6
lines
Diff to previous 1.22 (colored)
If this is a Davicom DM9102A and we're enabling the homePNA link, force dc_link to 1 and don't activate the tick routine. Without this, dc_start() always thinks the link is down and never transmits in homePNA mode.
Revision 1.9.2.9 / (download) - annotate - [select for diffs], Thu Sep 7 18:51:48 2000 UTC (11 years, 5 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.8: +13 -4
lines
Diff to previous 1.9.2.8 (colored) to branchpoint 1.9 (colored)
MFC: don't twiddle the LED enable bits on the NEC VersaPro NoteBook PC.
Revision 1.22 / (download) - annotate - [select for diffs], Thu Sep 7 18:51:04 2000 UTC (11 years, 5 months ago) by wpaul
Branch: MAIN
Changes since 1.21: +13 -4
lines
Diff to previous 1.21 (colored)
Special-case the LED twiddling code so that it doesn't do anything on the NEC VersaPro NoteBook PC. This 21143 implementation has no LEDs, and flipping the LED control bits somehow stops it from establishing a link. We check the subsystem ID and don't flip the LED control bits for the NEC NIC.
Revision 1.9.2.8 / (download) - annotate - [select for diffs], Sat Sep 2 00:05:23 2000 UTC (11 years, 5 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.7: +11 -0
lines
Diff to previous 1.9.2.7 (colored) to branchpoint 1.9 (colored)
MFC: make link and activity LEDs work on non-MII 21143 cards
Revision 1.21 / (download) - annotate - [select for diffs], Fri Sep 1 23:59:54 2000 UTC (11 years, 5 months ago) by wpaul
Branch: MAIN
CVS Tags: PRE_SMPNG
Changes since 1.20: +13 -2
lines
Diff to previous 1.20 (colored)
Make the blinkylights on non-MII 21143 cards work. We need to enable the link and activity LED control bits in CSR15 in order for the controller to drive the LEDs correctly. This was largely done for the ZNYX multiport cards, but should also work with the DEC DE500-BA and other non-MII cards.
Revision 1.9.2.7 / (download) - annotate - [select for diffs], Mon Aug 7 17:14:03 2000 UTC (11 years, 6 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.6: +17 -6
lines
Diff to previous 1.9.2.6 (colored) to branchpoint 1.9 (colored)
MFC: sync with current: fix PR 20438 (make LED fix conditional on Intel chip), add support for newer Macronix PCI chips).
Revision 1.20 / (download) - annotate - [select for diffs], Mon Aug 7 17:03:20 2000 UTC (11 years, 6 months ago) by wpaul
Branch: MAIN
Changes since 1.19: +9 -5
lines
Diff to previous 1.19 (colored)
Close PR 20438. Make fix for preserving LED settings conditional on presence Intel 21143 chip.
Revision 1.9.2.6 / (download) - annotate - [select for diffs], Tue Aug 1 19:36:03 2000 UTC (11 years, 6 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.5: +15 -4
lines
Diff to previous 1.9.2.5 (colored) to branchpoint 1.9 (colored)
MFC: fix LED handling on some cards
Revision 1.19 / (download) - annotate - [select for diffs], Tue Aug 1 19:34:13 2000 UTC (11 years, 6 months ago) by wpaul
Branch: MAIN
Changes since 1.18: +15 -4
lines
Diff to previous 1.18 (colored)
Apply patch supplied by John Hood <jhood@sitaranetworks.com> to fix problems with LEDs on some cards being stomped on when clearing the "jabber disable" bit. Using DC_SETBIT() has an unwanted side effect of setting a write enable bit in the watchdog timer register which we really want to be cleared when we do a write.
Revision 1.9.2.5 / (download) - annotate - [select for diffs], Mon Jul 17 21:24:38 2000 UTC (11 years, 6 months ago) by archie
Branch: RELENG_4
CVS Tags: RELENG_4_1_0_RELEASE
Changes since 1.9.2.4: +5 -8
lines
Diff to previous 1.9.2.4 (colored) to branchpoint 1.9 (colored)
MFC: make all Ethernet drivers use ether_ifattach() ether_ifdetach()
Revision 1.18 / (download) - annotate - [select for diffs], Mon Jul 17 19:27:41 2000 UTC (11 years, 6 months ago) by wpaul
Branch: MAIN
Changes since 1.17: +10 -3
lines
Diff to previous 1.17 (colored)
Add the PCI IDs for the Macronix 98727 and 98732 parts. These are 3.3volt PCI/cardbus chipsets similar to the 98715 (and they have 512-bit hash tables). Also update the man page to mention the 98727/98732 and the SOHOware SFA110A Rev B4 card with the 98715AEC-C chip.
Revision 1.9.2.4 / (download) - annotate - [select for diffs], Sat Jul 15 17:56:38 2000 UTC (11 years, 6 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.3: +32 -9
lines
Diff to previous 1.9.2.3 (colored) to branchpoint 1.9 (colored)
MFC: fix support for Macronix MX98715AEC-C/D/E chips with small multicast hash tables
Revision 1.17 / (download) - annotate - [select for diffs], Sat Jul 15 17:54:30 2000 UTC (11 years, 6 months ago) by wpaul
Branch: MAIN
Changes since 1.16: +32 -9
lines
Diff to previous 1.16 (colored)
Apply patch to the dc driver to handle Macronix MX98715AEC-C/D/E chips, which differ slightly from the Macronix MX98715AEC chip on the sample adapter that I have in that the multicast hash table is only 128 bits wide instead of 512. New adapters are popping up with this chip, and due to improper handling of the smaller hash table, broadcast packets were not being received correctly.
Revision 1.9.2.3 / (download) - annotate - [select for diffs], Fri Jul 14 20:48:33 2000 UTC (11 years, 6 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.2: +6 -2
lines
Diff to previous 1.9.2.2 (colored) to branchpoint 1.9 (colored)
MFC: merge in support for Accton EN1217D card. (Macronix chip: just add the PCI IDs.)
Revision 1.16 / (download) - annotate - [select for diffs], Thu Jul 13 22:54:31 2000 UTC (11 years, 7 months ago) by archie
Branch: MAIN
Changes since 1.15: +5 -8
lines
Diff to previous 1.15 (colored)
Make all Ethernet drivers attach using ether_ifattach() and detach using ether_ifdetach(). The former consolidates the operations of if_attach(), ng_ether_attach(), and bpfattach(). The latter consolidates the corresponding detach operations. Reviewed by: julian, freebsd-net
Revision 1.15 / (download) - annotate - [select for diffs], Sun Jun 11 11:54:52 2000 UTC (11 years, 8 months ago) by asmodai
Branch: MAIN
Changes since 1.14: +6 -2
lines
Diff to previous 1.14 (colored)
Add support for the Accton EN1217. PR: 18735 Submitted by: Adoal Xu <adoal@iname.com>
Revision 1.9.2.2 / (download) - annotate - [select for diffs], Wed Jun 7 17:11:22 2000 UTC (11 years, 8 months ago) by wpaul
Branch: RELENG_4
Changes since 1.9.2.1: +42 -17
lines
Diff to previous 1.9.2.1 (colored) to branchpoint 1.9 (colored)
MFC the autoneg fixes to the if_dc and dcphy driver(s).
Revision 1.14 / (download) - annotate - [select for diffs], Wed Jun 7 17:07:44 2000 UTC (11 years, 8 months ago) by wpaul
Branch: MAIN
Changes since 1.13: +14 -9
lines
Diff to previous 1.13 (colored)
When I tweaked if_dc.c to alter the polling interval for non-MII 21143 chips, I accidentally removed the DC_MII_REDUCED_POLL flag for all 21143 cards. This caused problems with timer-instigated TCP retransmits, which happened to occur at the same time as an MII poll tick on MII-based cards (e.g. D-Link DFE-570TX). Fixed this, plus made some other cleanups. The autoneg fixes for the non-MII cards still work. Also tested the PNIC II now that I have one again.
Revision 1.13 / (download) - annotate - [select for diffs], Wed May 31 05:40:52 2000 UTC (11 years, 8 months ago) by wpaul
Branch: MAIN
Changes since 1.12: +37 -17
lines
Diff to previous 1.12 (colored)
Rework the support for the internal autonegotiation on the 21143 and workalike chips (Macronix 98713A/98715 and PNIC II). Timing is somewhat critical: you need to bring the link as soon as possible after NWAY is done, and the old one second polling interval was too long. Now we poll every 10th of a second until NWAY completes (at which point we return to the 1 second interval again to keep an eye on the link state). I tested all the other cards I had on hand to make sure I didn't bust any of them and they seem to work (including the MII-based 21143 card). This should fix some autoneg problems with DE500-BA cards and the built-in 10/100 ethernet on some alpha systems. (Now before anyone asks why I never noticed this before, the old code worked just find with the Intel swich I used for testing back in NY. Apparently not all switches are as picky about the timing.)
Revision 1.12 / (download) - annotate - [select for diffs], Sun May 28 16:02:05 2000 UTC (11 years, 8 months ago) by peter
Branch: MAIN
Changes since 1.11: +5 -5
lines
Diff to previous 1.11 (colored)
Use the correct register names. s/PCI_COMMAND_STATUS_REG/PCIR_COMMAND/
Revision 1.9.2.1 / (download) - annotate - [select for diffs], Wed May 24 01:47:58 2000 UTC (11 years, 8 months ago) by archie
Branch: RELENG_4
Changes since 1.9: +2 -42
lines
Diff to previous 1.9 (colored)
MFC: Move BPF and bridging code into ether_input()
Revision 1.11 / (download) - annotate - [select for diffs], Sun May 14 02:18:42 2000 UTC (11 years, 9 months ago) by archie
Branch: MAIN
Changes since 1.10: +2 -42
lines
Diff to previous 1.10 (colored)
Move code to handle BPF and bridging for incoming Ethernet packets out of the individual drivers and into the common routine ether_input(). Also, remove the (incomplete) hack for matching ethernet headers in the ip_fw code. The good news: net result of 1016 lines removed, and this should make bridging now work with *all* Ethernet drivers. The bad news: it's nearly impossible to test every driver, especially for bridging, and I was unable to get much testing help on the mailing lists. Reviewed by: freebsd-net
Revision 1.10 / (download) - annotate - [select for diffs], Sat Apr 29 13:41:54 2000 UTC (11 years, 9 months ago) by peter
Branch: MAIN
Changes since 1.9: +4 -2
lines
Diff to previous 1.9 (colored)
Depend on miibus. Note that if_aue doesn't strictly depend on usb because it uses the method interface for calls rather than using internal symbols, and because it's a child driver of usb and therefore will not try and do anything unless the parent usb code is loaded at some point. if_aue does strictly depend on miibus as it will fail to link if it is missing.
Revision 1.9 / (download) - annotate - [select for diffs], Sat Mar 11 05:20:56 2000 UTC (11 years, 11 months ago) by msmith
Branch: MAIN
CVS Tags: RELENG_4_BP,
RELENG_4_0_0_RELEASE
Branch point for: RELENG_4
Changes since 1.8: +42 -2
lines
Diff to previous 1.8 (colored)
Teach the 'dc' driver how to pick up settings left over by the SRM on alpha systems. This is an expedient if not entirely elegant solution to the problem. Submitted by: gallatin Approved by: jkh
Revision 1.8 / (download) - annotate - [select for diffs], Thu Mar 9 19:28:19 2000 UTC (11 years, 11 months ago) by rwatson
Branch: MAIN
Changes since 1.7: +27 -6
lines
Diff to previous 1.7 (colored)
Introduce ethernet bridge support for if_dc Approved by: jkh
Revision 1.7 / (download) - annotate - [select for diffs], Mon Jan 24 17:19:37 2000 UTC (12 years ago) by wpaul
Branch: MAIN
Changes since 1.6: +79 -9
lines
Diff to previous 1.6 (colored)
Add support for DM9102A boards with Davicom DM9801 HomePNA PHYs.
Revision 1.6 / (download) - annotate - [select for diffs], Wed Jan 19 19:03:06 2000 UTC (12 years ago) by wpaul
Branch: MAIN
Changes since 1.5: +18 -7
lines
Diff to previous 1.5 (colored)
Add support for the Davicom DM9102A 10/100 ethernet controller chip. This is just to make sure we initialize the chip correctly: we need to make the sure the port select bit in CSR6 is set properly so that we use the internal PHY for 10/100 support. (The eval boards I have also include an external HomePNA PHY, but I need to play with that more before I can support it.)
Revision 1.5 / (download) - annotate - [select for diffs], Wed Jan 12 22:24:05 2000 UTC (12 years, 1 month ago) by wpaul
Branch: MAIN
Changes since 1.4: +45 -3
lines
Diff to previous 1.4 (colored)
Reintroduce the dc_coal() workaround routine for coalescing outbound packets into a single buffer, and set the DC_TX_COALESCE flag for the Davicom DM9102 chip. I thought I had escaped this problem, but... This chip appears to silently corrupt or discard transmitted frames when using scatter/gather DMA (i.e. DMAing each packet fragment in place with a separate descriptor). The only way to insure reliable transmission is to coalesce transmitted packets into a single cluster buffer. (There may also be an alignment constraint here, but mbuf cluster buffers are naturally aligned on 2K boundaries, which seems to be good enough.) The DM9102 driver for Linux written by Davicom also uses this workaround. Unfortunately, the Davicom datasheet has no errata section describing this or any other apparently known defect. Problem noted by: allan_chou@davicom.com.tw
Revision 1.4 / (download) - annotate - [select for diffs], Mon Jan 3 15:28:46 2000 UTC (12 years, 1 month ago) by wpaul
Branch: MAIN
Changes since 1.3: +55 -4
lines
Diff to previous 1.3 (colored)
It appears that under certain circumstances that I still can't quite pin down, the dc driver and receiver can fall out of sync with one another, resulting in a condition where the chip continues to receive packets but the driver never notices. Normally, the receive handler checks each descriptor starting from the current producer index to see if the chip has relinquished ownership, indicating that a packet has been received. The driver hands the packet off to ether_input() and then prepares the descriptor to receive another frame before moving on to the next descriptor in the ring. But sometimes, the chip appears to skip a descriptor. This leaves the driver testing the status word in a descriptor that never gets updated. The driver still gets "RX done" interrupts but never advances further into the RX ring, until the ring fills up and the chip interrupts again to signal an error condition. Sometimes, the driver will remain in this desynchronized state, resulting in spotty performance until the interface is reset. Fortunately, it's fairly simple to detect this condition: if we call the rxeof routine but the number of received packets doesn't increase, we suspect that there could be a problem. In this case, we call a new routine called dc_rx_resync(), which scans ahead in the RX ring to see if there's a frame waiting for us somewhere beyond that the driver thinks is the current producer index. If it finds one, it bumps up the index and calls the rxeof handler again to snarf up the packet and bring the driver back in sync with the chip. (It may actually do this several times in the event that there's more than one "hole" in the ring.) So far the only card supported by if_dc which has exhibited this problem is a LinkSys LNE100TX v2.0 (82c115 PNIC II), and it only seems to happen on one particular system, however the fix is general enough and has low enough overhead that we may as well apply it for all supported chipsets. I also implemented the same fix for the 3Com xl driver, which is apparently vulnerable to the same problem. Problem originally noted and patch tested by: Matt Dillon
Revision 1.3 / (download) - annotate - [select for diffs], Mon Dec 13 21:45:11 1999 UTC (12 years, 2 months ago) by wpaul
Branch: MAIN
Changes since 1.2: +16 -3
lines
Diff to previous 1.2 (colored)
Fix some problems reported by Mike Pritchard: - Add a flag DC_TX_INTR_ALWAYS which causes the transmit code to request a TX done interrupt for every packet. The PNIC seems to need this to insure that the sent TX buffers get reaped in a timely fashion. - Try to unreset the SIA as soon as possible after resetting the whole chip. - Change dcphy to support either 10/100 or 10Mbps only NICs. The built-in 21143 ethernet in Compaq Presario machines is 10Mbps only and it doesn't work right if we try to advertise 100Mbps modes during autoneg. When restricted to only 10mbps modes, it works fine. Note that for now, I detect this condition by checking the PCI subsystem ID on this NIC (which has a Compaq vendor/device ID). Yes, I know that's what the SROM is supposed to be for. I'm deliberately ignoring the SROM wherever possible. Sue me. The latter two fixes allow if_dc to work correctly with the built-in ethernet on certain Compaq Presario boxes. There are liable to be quite a few people using these as their home systems who might want to try FreeBSD; may as well be nice to them. Now if anybody out there has an Alpha miata with 10Mbps ethernet and can show me the output from pciconf -l on their system, I'd be grateful.
Revision 1.2 / (download) - annotate - [select for diffs], Tue Dec 7 19:18:41 1999 UTC (12 years, 2 months ago) by wpaul
Branch: MAIN
Changes since 1.1: +4 -4
lines
Diff to previous 1.1 (colored)
Tweak the DC_REDUCED_MII_POLL code in dc_mii_tick() for the DC_IS_INTEL() case. The idea is to reduce how often we call mii_tick(), however currently it may not be called often enough, which prevents autonegotiation from being driven correctly. This should improve the chances of successfully autonegotiating media settings on non-MII 21143 NICs. (Still waiting for confirmation from some testers, but the code is clearly wrong in any case.)
Revision 1.1 / (download) - annotate - [select for diffs], Sat Dec 4 17:41:07 1999 UTC (12 years, 2 months ago) by wpaul
Branch: MAIN
Add the if_dc driver and remove all of the al, ax, dm, pn and mx drivers which it replaces. The new driver supports all of the chips supported by the ones it replaces, as well as many DEC/Intel 21143 10/100 cards. This also completes my quest to convert things to miibus and add Alpha support.